Re: [Libreoffice] [REVIEW-3-5-0] Revert of UNO interface publishing

2012-01-27 Thread Norbert Thiebaud
pushed on 3-5-0 as http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=13ce4a57c1d20a767a7f4d818f063b19b95b5d48 Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/l

Re: [Libreoffice] [REVIEW-3-5-0] Revert of UNO interface publishing

2012-01-27 Thread Norbert Thiebaud
On Fri, Jan 27, 2012 at 3:41 AM, Michael Meeks wrote: > > On Fri, 2012-01-27 at 09:56 +0100, Stephan Bergmann wrote: >> I'm not happy with this, either, but all the additional changes brought >> in with Thorsten's commits appeared to me to be minuscule and harmless, >> so I would not bother to cle

Re: [Libreoffice] [REVIEW-3-5-0] Revert of UNO interface publishing

2012-01-27 Thread Michael Meeks
On Fri, 2012-01-27 at 09:56 +0100, Stephan Bergmann wrote: > I'm not happy with this, either, but all the additional changes brought > in with Thorsten's commits appeared to me to be minuscule and harmless, > so I would not bother to clean them up further, at least not on -3-5-0. So you

Re: [Libreoffice] [REVIEW-3-5-0] Revert of UNO interface publishing

2012-01-27 Thread Norbert Thiebaud
On Fri, Jan 27, 2012 at 2:56 AM, Stephan Bergmann wrote: > On 01/27/2012 09:46 AM, Norbert Thiebaud wrote: >> >> in the original commit by thorsten 9and not 'fixed by Stephan's) >> --- a/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl >> +++ b/offapi/com/sun/star/drawing/framewo

Re: [Libreoffice] [REVIEW-3-5-0] Revert of UNO interface publishing

2012-01-27 Thread Stephan Bergmann
On 01/27/2012 09:46 AM, Norbert Thiebaud wrote: in the original commit by thorsten 9and not 'fixed by Stephan's) --- a/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl +++ b/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl @@ -35,8 +35,9 @@ module com { module

Re: [Libreoffice] [REVIEW-3-5-0] Revert of UNO interface publishing

2012-01-27 Thread Norbert Thiebaud
in the original commit by thorsten 9and not 'fixed by Stephan's) --- a/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl +++ b/offapi/com/sun/star/drawing/framework/ConfigurationChangeEvent.idl @@ -35,8 +35,9 @@ module com { module sun { module star { module uno { interface XInterf

Re: [Libreoffice] [REVIEW-3-5-0] Revert of UNO interface publishing

2012-01-27 Thread Thorsten Behrens
Stephan Bergmann wrote: > >I'd have preferred if you just removed the "published" tag and did not > >also remove documentation-in-comment, as in: > [...] > > Indeed. I reviewed and cherry-picked this to -3-5, lumping together > the original revert with Thorsten's follow-up > Thanks Stephan - yep