Re: [Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency

2011-12-14 Thread Thorsten Behrens
Michael Meeks wrote: > I'd be happier to see the nMethod being compared if we had removed the > comment, and/or at least understood whether it is still relevant: are we > using/changing nMethod elsewhere ? > Yep, good point. Tweaked for master. That comment looks false, did not find any plac

Re: [Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency

2011-12-14 Thread Michael Meeks
On Wed, 2011-12-14 at 13:38 +0100, Thorsten Behrens wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=309f56174aca6adca879f70958892492361dac6e > fixes an import problem for files generated with an apparently > different code base for zip archives - the deviation is benign, and > sho

[Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency

2011-12-14 Thread Thorsten Behrens
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=309f56174aca6adca879f70958892492361dac6e fixes an import problem for files generated with an apparently different code base for zip archives - the deviation is benign, and should be accepted on import. Original bugreport: https://