Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-02-08 Thread Cedric Bosdonnat
Hi Kendy, all, On Tue, 2012-01-31 at 15:50 +0100, Jan Holesovsky wrote: > > Looked fine. Worked reasonable => pushed into 3-5-0, see > > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=4632a18dae5e1770aa1da4ac55719a09c1ae461b > > http://cgit.freedesktop.org/libreoffice/

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-31 Thread Jan Holesovsky
Hi Petr, Cedric, all, On 2012-01-31 at 15:26 +0100, Petr Mladek wrote: > Looked fine. Worked reasonable => pushed into 3-5-0, see > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=4632a18dae5e1770aa1da4ac55719a09c1ae461b > http://cgit.freedesktop.org/libreoffice/core/c

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-31 Thread Petr Mladek
Noel Power píše v Út 31. 01. 2012 v 11:24 +: > On 30/01/12 17:16, Cedric Bosdonnat wrote: > > Hi Michael, > > > > On Thu, 2012-01-26 at 19:35 +0100, Michael Stahl wrote: > >> On 26/01/12 19:30, Michael Stahl wrote: > >>> On 26/01/12 16:21, Cedric Bosdonnat wrote: > Hi all, > > Co

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-31 Thread Noel Power
On 30/01/12 17:16, Cedric Bosdonnat wrote: Hi Michael, On Thu, 2012-01-26 at 19:35 +0100, Michael Stahl wrote: On 26/01/12 19:30, Michael Stahl wrote: On 26/01/12 16:21, Cedric Bosdonnat wrote: Hi all, Could someone review and cherry-pick this commit to -3-5, -3-5-0 and -3-4? http://cgit.fre

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-30 Thread Michael Stahl
On 30/01/12 18:16, Cedric Bosdonnat wrote: > Fixed in > http://cgit.freedesktop.org/libreoffice/core/commit/?id=458d56d9b35f2ecb2eea2589737079390b10ee26 looking better... > Would be nice to cherry-pick these two commits to -3-5, -3-4 and 3-5-0 > (if it's not too late). pushed to libreoffice-3-

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-30 Thread Cedric Bosdonnat
Hi Michael, On Thu, 2012-01-26 at 19:35 +0100, Michael Stahl wrote: > On 26/01/12 19:30, Michael Stahl wrote: > > On 26/01/12 16:21, Cedric Bosdonnat wrote: > >> Hi all, > >> > >> Could someone review and cherry-pick this commit to -3-5, -3-5-0 and > >> -3-4? > >> http://cgit.freedesktop.org/libre

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-28 Thread Cedric Bosdonnat
Hi Michael, On Thu, 2012-01-26 at 19:35 +0100, Michael Stahl wrote: > > sal_uInt16 nMaxDstId = *aIds.end(); > > oops, now it occurs to me that dereferencing end() is a bad idea in any > case, you probably want to use rbegin() instead :) I can only agree with you... I don't really see the subtl

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-26 Thread Michael Stahl
On 26/01/12 19:30, Michael Stahl wrote: > On 26/01/12 16:21, Cedric Bosdonnat wrote: >> Hi all, >> >> Could someone review and cherry-pick this commit to -3-5, -3-5-0 and >> -3-4? >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889 > > your fix looks

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-26 Thread Michael Stahl
On 26/01/12 16:21, Cedric Bosdonnat wrote: > Hi all, > > Could someone review and cherry-pick this commit to -3-5, -3-5-0 and > -3-4? > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889 your fix looks good to me, except for the line: sal_uInt16 nM

[Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

2012-01-26 Thread Cedric Bosdonnat
Hi all, Could someone review and cherry-pick this commit to -3-5, -3-5-0 and -3-4? http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889 Thanks, -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freede