Re: [Libreoffice] [REVIEW] patch for 2 bitwiseOnBoolean detected cppcheck

2011-09-15 Thread David Tardon
On Thu, Sep 15, 2011 at 02:43:06PM -0700, julien2412 wrote: > Hello, > > Here is a patch on 2 different code parts. Cppcheck detected these : > core/vcl/source/gdi/sallayout.cxx > 743 bitwiseOnBooleanstyle Boolean variable 'bAllOk' is used in > bitwise > operation. Did you mean && ?

[Libreoffice] [REVIEW] patch for 2 bitwiseOnBoolean detected cppcheck

2011-09-15 Thread julien2412
Hello, Here is a patch on 2 different code parts. Cppcheck detected these : core/vcl/source/gdi/sallayout.cxx 743 bitwiseOnBooleanstyle Boolean variable 'bAllOk' is used in bitwise operation. Did you mean && ? core/sfx2/source/appl/workwin.cxx 1073bitwiseOnBooleanstyle