Re: [Libreoffice] [REVIEW] fix for fdo#37628: pssword button is always disabled

2011-07-26 Thread Kohei Yoshida
On Tue, 2011-07-26 at 18:25 +0100, Michael Meeks wrote: > On Tue, 2011-07-26 at 10:37 -0400, Kohei Yoshida wrote: > > Just to spell out my intention more clearly, if nobody disagrees that > > this minor quirk will not cause any issues (after all, right now, the > > whole functionality is not workin

Re: [Libreoffice] [REVIEW] fix for fdo#37628: pssword button is always disabled

2011-07-26 Thread Michael Meeks
On Tue, 2011-07-26 at 10:37 -0400, Kohei Yoshida wrote: > Just to spell out my intention more clearly, if nobody disagrees that > this minor quirk will not cause any issues (after all, right now, the > whole functionality is not working) within the next few days, I will > push Markus' patch with

Re: [Libreoffice] [REVIEW] fix for fdo#37628: pssword button is always disabled

2011-07-26 Thread Kohei Yoshida
On Tue, 2011-07-26 at 01:37 -0400, Kohei Yoshida wrote: > There is one minor issue. The dialog that gets launched from the Change > Password button also contains the optional password input for modifying > document, and setting a new password there doesn't appear to change the > modify-document p

Re: [Libreoffice] [REVIEW] fix for fdo#37628: pssword button is always disabled

2011-07-25 Thread Kohei Yoshida
Hello Markus, On Sun, 2011-07-24 at 20:22 +0200, Markus Mohrhard wrote: > Hello Kohei, all, > > this is a possible patch for the problem that the button at > File->Properties is always disabled even if you have a password > protected file. > > The problem was that SID_PASSWORD, which saved the p

[Libreoffice] [REVIEW] fix for fdo#37628: pssword button is always disabled

2011-07-24 Thread Markus Mohrhard
Hello Kohei, all, this is a possible patch for the problem that the button at File->Properties is always disabled even if you have a password protected file. The problem was that SID_PASSWORD, which saved the plain text password, is no longer used but we use SID_ENCRYPTIONDATA which saves the has