Re: [Libreoffice] [REVIEW] Speed up range name lookup from formula interpreter

2011-09-05 Thread Eike Rathke
Hi Kohei, On Sunday, 2011-09-04 20:09:30 -0400, Kohei Yoshida wrote: > > I didn't test with any Excel document yet to verify. Actually > > I currently have zero original Excel documents ;) I'll have to copy the > > testcase farm of the old OOo tree Daniel used to maintain [should do > > that whil

Re: [Libreoffice] [REVIEW] Speed up range name lookup from formula interpreter

2011-09-04 Thread Kohei Yoshida
Hi Eike, On Sun, Sep 4, 2011 at 7:09 PM, Eike Rathke wrote: > On Friday, 2011-09-02 17:13:22 -0400, Kohei Yoshida wrote: > >> I'd like to have the attached patch reviewed and pushed to the -3-4 >> branch. > > That would also need > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bf8fd62

Re: [Libreoffice] [REVIEW] Speed up range name lookup from formula interpreter

2011-09-04 Thread Eike Rathke
Hi Kohei, On Friday, 2011-09-02 17:13:22 -0400, Kohei Yoshida wrote: > I'd like to have the attached patch reviewed and pushed to the -3-4 > branch. That would also need http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bf8fd627afc8567ae8ec6fad8edf20a11f143ad > It makes range name lookup

[Libreoffice] [REVIEW] Speed up range name lookup from formula interpreter

2011-09-02 Thread Kohei Yoshida
Hi there, I'd like to have the attached patch reviewed and pushed to the -3-4 branch. It makes range name lookups by index a constant time which drastically improves formula calculation performance especially with documents with a larger number of named ranges. This also improves the import perf