Re: [Libreoffice] [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-11 Thread Michael Meeks
On Fri, 2011-02-11 at 00:14 +, Luke Dixon wrote: > I hope I'm not waffling but I'm very thankful to you guys for looking > at this. And thanks for taking care of closing the bugs. The pleasure really is entirely mine :-) thanks for your great work on starmath ! Quick question

Re: [Libreoffice] [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-10 Thread Luke Dixon
Hello Michael, Jonas, Caolán, > Great - pushed there; > > Thanks, > > Michael. > I hope I'm not waffling, but I'm very thankful to you guys for looking at this. And thanks for taking care of closing the bugs. Thanks, Luke

Re: [Libreoffice] [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-10 Thread Michael Meeks
On Thu, 2011-02-10 at 18:10 +0100, Jonas Finnemann Jensen wrote: > If we get another review of the patch, we could put it into > libreoffice-3-3-1 .. > If there both a libreoffice-3-3 and libreoffice-3-3-1, and think it's > fine to push it to both... Great - pushed there;

Re: [Libreoffice] [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-10 Thread Jonas Finnemann Jensen
Hi, Sorry, I'm so slow to reply... School is keeping me busy... Anyway, the patch looks fine... I've pushed your patch for libreoffice-3-3 Great... - again sorry I'm so slow... If we get another review of the patch, we could put it > into libreoffice-3-3-1 If there both a libreoffice-3-3 and

[Libreoffice] [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-10 Thread Michael Meeks
Hi Luke, On Tue, 2011-02-08 at 20:50 +, Luke Dixon wrote: > I guess I'm too late now, so maybe for 3.3.2, but maybe there are a > couple of bugs that could be fixed for libreoffice-3-3. I've pushed your patch for libreoffice-3-3 - but really, with you and Jonas' review you could have