Re: [Libreoffice] [REVIEW] Listbox form fields fixes

2011-02-10 Thread Cedric Bosdonnat
Hello Michael, On Thu, 2011-02-10 at 12:33 +, Michael Meeks wrote: > So - I think this is way too big to ship between 3.3.1 RC1 and our > final release of that; so - I'd say no for 3.3.1. I'd say yes for 3.3 > (and hence 3.3.2) but I have a few questions: Ok. > When writing we do

Re: [Libreoffice] [REVIEW] Listbox form fields fixes

2011-02-10 Thread Michael Meeks
Hi Cedric, On Thu, 2011-02-10 at 12:08 +0100, Cedric Bosdonnat wrote: > Could you please review the patch attached to this bug report for > inclusion in 3.3 and 3.3.1 branches? So - I think this is way too big to ship between 3.3.1 RC1 and our final release of that; so - I'd say no for 3.

Re: [Libreoffice] [REVIEW] Listbox form fields fixes

2011-02-10 Thread Noel Power
Hi Cedric On 10/02/11 11:08, Cedric Bosdonnat wrote: Hello fellow hackers, Could you please review the patch attached to this bug report for inclusion in 3.3 and 3.3.1 branches? https://bugs.freedesktop.org/show_bug.cgi?id=34064 The corresponding code has been pushed to master, but cherry-pick

[Libreoffice] [REVIEW] Listbox form fields fixes

2011-02-10 Thread Cedric Bosdonnat
Hello fellow hackers, Could you please review the patch attached to this bug report for inclusion in 3.3 and 3.3.1 branches? https://bugs.freedesktop.org/show_bug.cgi?id=34064 The corresponding code has been pushed to master, but cherry-picking may not be easy due to conflicting changes in maste