Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Kohei Yoshida
On Tue, 2011-05-17 at 12:04 -0400, Kohei Yoshida wrote: > The attached patch fixes the crasher reported in the following bug: > > https://bugs.freedesktop.org/show_bug.cgi?id=37226 And if possible. I'd like to have two more sign-off's so that we can put this in for 3.4. It's a crasher bug, so

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Kohei Yoshida
On Wed, 2011-05-18 at 15:12 +0100, Noel Power wrote: > Anyway +1 from me regardless of which version of the patch ( really > referring the patch I attached as *mine* is rich ;-) I only omitted > some changes you did ) Thanks Noel. Incidentally, I accidentally pushed mine to the -3-4 branch al

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Noel Power
Hi Kohei On 18/05/11 12:52, Kohei Yoshida wrote: On Wed, 2011-05-18 at 12:08 +0100, Noel Power wrote: [...] So, we (Rafael, Norbert, Joseph and I) talked about this last night on IRC, and one question raised was whether or not boost::bind allows pointers to data members rather than member funct

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Kohei Yoshida
On Wed, 2011-05-18 at 12:08 +0100, Noel Power wrote: > On 17/05/11 17:04, Kohei Yoshida wrote: > > Hi there, > > > > The attached patch fixes the crasher reported in the following bug: > > > > https://bugs.freedesktop.org/show_bug.cgi?id=37226 > > > > and also several other usage of standard algori

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-18 Thread Noel Power
On 17/05/11 17:04, Kohei Yoshida wrote: Hi there, The attached patch fixes the crasher reported in the following bug: https://bugs.freedesktop.org/show_bug.cgi?id=37226 and also several other usage of standard algorithms which I believe is incorrect, since the existing code passes the result o

[Libreoffice] [REVIEW] Fix for fdo#37226

2011-05-17 Thread Kohei Yoshida
Hi there, The attached patch fixes the crasher reported in the following bug: https://bugs.freedesktop.org/show_bug.cgi?id=37226 and also several other usage of standard algorithms which I believe is incorrect, since the existing code passes the result of an evaluation which is always boolean (u