Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-24 Thread Kohei Yoshida
Hi Markus, It took me a little to get to your patch, but finally I've been able to get around to reviewing it. On Thu, 2011-03-24 at 17:43 +0100, Markus Mohrhard wrote: > so there is the next try. I've just followed Koheis' suggestions and > made the anonymous db a part of ScTable. So, this loo

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-24 Thread Markus Mohrhard
Hello, so there is the next try. I've just followed Koheis' suggestions and made the anonymous db a part of ScTable. Patch is of course under LGPLv3+/MPL. Markus P.S. Sry that patch is not created with git format-patch but I don't know how to create a patch against a specific point 2011/3/22 K

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-22 Thread Kohei Yoshida
On Tue, 2011-03-22 at 19:59 +0100, Markus Mohrhard wrote: > This time with the patch. Sry. > > 2011/3/22 Markus Mohrhard > Hello, > > > > so I have reworked it. I haven't reworked the import and > export as these affect some areas I don't fully u

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-22 Thread Markus Mohrhard
This time with the patch. Sry. 2011/3/22 Markus Mohrhard > Hello, > > so I have reworked it. I haven't reworked the import and export as these > affect some areas I don't fully understand. > > Patch is under LGPLv3+/MPL. > > Markus > 0002-support-for-one-anonymous-db-range-per-sheet-and-one.pa

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-22 Thread Markus Mohrhard
Hello, so I have reworked it. I haven't reworked the import and export as these affect some areas I don't fully understand. Patch is under LGPLv3+/MPL. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/m

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-21 Thread Kohei Yoshida
On Tue, 2011-03-22 at 00:22 +0100, Markus Mohrhard wrote: > Ok, > > > thanks for your advice. I will rework it but suggest that the static > method will be placed in ScDBCollection. Ah, yes. My finger slipped. I meant to type ScDB*, not ScDP*. :-P So many ScFooCollection in Calc core... Gla

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-21 Thread Markus Mohrhard
Ok, thanks for your advice. I will rework it but suggest that the static method will be placed in ScDBCollection. But there is then there is the question whether an Undo should undo the last change in the active sheet or undo the last change in any sheet. Note that ,as I see it, this will only af

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-21 Thread Kohei Yoshida
Hello Markus, On Mon, 2011-03-21 at 19:33 +0100, Markus Mohrhard wrote: > this patch allows one anonymous db range per sheet instead of one per > document. There are still some places the old anonymous db range is > used, but I#m not quite sure whether i should change these. Probably yes. The i

[Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-21 Thread Markus Mohrhard
Hi, this patch allows one anonymous db range per sheet instead of one per document. There are still some places the old anonymous db range is used, but I#m not quite sure whether i should change these. Additionally it allows one autofilter per sheet. I'd appreciate a better solution for generati