Re: [Libreoffice] [Patch] Accelerate Perl installer builder

2011-02-25 Thread Jan Darmochwal
Hi! This patch speeds up make_installer.pl by about 5% on linux (probably much less speedup on windows). The Patch is LGPLv3+/MPL. The next patch will focus on Windows speed (if I succeed in setting up a Windows build environment for LibreOffice). Jan >From b00c14d851996150da952eb71d84eee50cf68a

Re: [Libreoffice] [Patch] Accelerate Perl installer builder

2011-02-03 Thread Jan Darmochwal
On 2011-01-28 Michael Meeks wrote: > > > Can you confirm your work is under LGPLv3+/MPL please too ? > > Yes, of course. The patch is released under LGPLv3+. > > Heh - we ask for a dual LGPLv3+ -and- MPL license for changes; so > LGPLv3+/MPL is the question :-) OK, it's LGPLv3+/MPL then.

Re: [Libreoffice] [Patch] Accelerate Perl installer builder

2011-01-28 Thread Michael Meeks
Hi Jan, On Thu, 2011-01-27 at 22:51 +0100, Jan Darmochwal wrote: > At the moment I have no idea how the installer actually works. Lol :-) the perl is mangled enough that I suspect you can be productive like that just fine to start with. The basic idea is that make_installer is li

Re: [Libreoffice] [Patch] Accelerate Perl installer builder

2011-01-27 Thread Jan Darmochwal
On 2011-01-27 Michael Meeks wrote: > Incidentally, if changing the format of the scp2 files to make them > easier to parse is sensible, we should do that too - the files all come > from scp2/ (as you can see). > > Also wrt. semantic differences, you can see the setup_osl.ins that much

Re: [Libreoffice] [Patch] Accelerate Perl installer builder

2011-01-27 Thread Jan Darmochwal
On 2011-01-27 Christian Lohmaier wrote: > So my question is: Did you just skim over the installer to identify > the part that is slow, or did you profile it yourself? And how did you > measure the improvement? I added "-d:DProf" to the perl calls in ooinstall to profile it. I measured the improv

Re: [Libreoffice] [Patch] Accelerate Perl installer builder

2011-01-27 Thread Christian Lohmaier
Hi Jan, *, On Thu, Jan 27, 2011 at 2:21 AM, Jan Darmochwal wrote: > > The attached patch makes make_installer.pl save up to 25% time on my > linux machine. Wow - impressive :-) So my question is: Did you just skim over the installer to identify the part that is slow, or did you profile it yours

Re: [Libreoffice] [Patch] Accelerate Perl installer builder

2011-01-27 Thread Michael Meeks
Hi Jan, On Thu, 2011-01-27 at 02:21 +0100, Jan Darmochwal wrote: > I found this on the easy hacks page: > http://wiki.documentfoundation.org/Development/Easy_Hacks .. > The attached patch makes make_installer.pl save up to 25% time on my > linux machine. Brilliant work :-) Incide

[Libreoffice] [Patch] Accelerate Perl installer builder

2011-01-26 Thread Jan Darmochwal
Hi! I found this on the easy hacks page: http://wiki.documentfoundation.org/Development/Easy_Hacks The attached patch makes make_installer.pl save up to 25% time on my linux machine. I'm going to do some more patching on make_installer.pl. Is it okay to post my patches on this mailing list? >Fr