Re: [Libreoffice] [PUSHED] Re: [PATCH] And another one

2010-11-29 Thread Michael Meeks
On Mon, 2010-11-29 at 20:04 +, Caolán McNamara wrote: > There's another, (in my opinion more interesting), class of dead-code > and that's the stuff that's compiled in but isn't called by anything. Ah yes. > I've yet to get in gear and get up-to-date runs for LibreOffice, but see > h

Re: [Libreoffice] [PUSHED] Re: [PATCH] And another one

2010-11-29 Thread Michael Meeks
On Mon, 2010-11-29 at 16:56 +, Wols Lists wrote: > That's all of base scanned. Unless I've missed something (and I've > deliberately skipped a few bits, eg that marked with TODO), there > shouldn't be any dead code or end-of-if/end-of-switch type comments left > there. Nice :-) is it

Re: [Libreoffice] [PUSHED] Re: [PATCH] And another one

2010-11-29 Thread Caolán McNamara
On Mon, 2010-11-29 at 16:56 +, Wols Lists wrote: > That's all of base scanned. Unless I've missed something (and I've > deliberately skipped a few bits, eg that marked with TODO), there > shouldn't be any dead code or end-of-if/end-of-switch type comments left There's another, (in my opinion m

Re: [Libreoffice] [PUSHED] Re: [PATCH] And another one

2010-11-29 Thread Wols Lists
On 29/11/10 16:14, Caolán McNamara wrote: > On Mon, 2010-11-29 at 15:48 +, Wols Lists wrote: >> Cheers, > Looks good, pushed, thanks for that. > > C. > That's all of base scanned. Unless I've missed something (and I've deliberately skipped a few bits, eg that marked with TODO), there shouldn't

[Libreoffice] [PUSHED] Re: [PATCH] And another one

2010-11-29 Thread Caolán McNamara
On Mon, 2010-11-29 at 15:48 +, Wols Lists wrote: > Cheers, Looks good, pushed, thanks for that. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice