Re: [Libreoffice] [PUSHED] Re: [PATCH] Some build breakage fixes for MSVC2008

2011-02-12 Thread Fridrich Strba
Hello, Steven On 12/02/11 23:46, Steven Butler wrote: I had to disable some unit tests to get through the build as cppunittester was crashing on exit. Eh ;) The purpose of unit tests is to catch problems early :) If cppunittester crashes, it means that the unit test is not passing :) But nev

[Libreoffice] [PUSHED] Re: [PATCH] Some build breakage fixes for MSVC2008

2011-02-12 Thread Steven Butler
Hi Fridrich, > On Sat, 2011-02-12 at 20:54 +1000, Steven Butler wrote: >> unopkg_app_stl_fix.patch fixes apparent breakage in the use of fill_n > Thanks for your precious work. BTW, do the smoketests run for you? Here > they run, but there is a crash on exit :( I had to disable some unit tests

[Libreoffice] [PUSHED] Re: [PATCH] Some build breakage fixes for MSVC2008

2011-02-12 Thread Fridrich Strba
Hello, Steven, Sorry, I pushed my fixes before reading your e-mail :( On Sat, 2011-02-12 at 20:54 +1000, Steven Butler wrote: > I didn't want to break anything so I took an easy out and made it > mutable but I would think it would be better fixed by using const_cast > wherever a non-const iterato