Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-12-08 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Michael Em 28-11-2011 18:18, Michael Meeks escreveu: > Hi Olivier, > (snip) > Anyhow - it looks great; no doubt we should add this to: > > http://wiki.documentfoundation.org/ReleaseNotes/3.5 > > With suitable credits etc. & c

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-11-29 Thread Lubos Lunak
On Tuesday 29 of November 2011, Michael Meeks wrote: > Ah - but this is what I added: > > Window* Window::GetParentDialog() const One 'const' missing (or one too much). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@li

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-11-29 Thread Caolán McNamara
On Tue, 2011-11-29 at 13:46 +, Michael Meeks wrote: > Window* Window::GetParentDialog() const > > for - surely ? :-) [ at least to reduce the cut/paste of that code > inside cui/ ;-] - it just walks up the hierarchy in a nasty way looking > for a dialog parent. Yeah, once found its fixa

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-11-29 Thread Michael Meeks
Hi Caolan, On Tue, 2011-11-29 at 12:32 +, Caolán McNamara wrote: > > Caolan - after the 'word count' victim dialog, it seems that the > > extensions dialog has a foul nightmare of manual size calulation all > > over it ;-) cf. the ~90 lines of: > > Bah, just weeping with sadness with my r

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-11-29 Thread Caolán McNamara
On Tue, 2011-11-29 at 10:31 +, Michael Meeks wrote: > Hi Olivier, > > Caolan - after the 'word count' victim dialog, it seems that the > extensions dialog has a foul nightmare of manual size calulation all > over it ;-) cf. the ~90 lines of: Bah, just weeping with sadness with my recent

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-11-29 Thread Michael Meeks
Hi Olivier, Caolan - after the 'word count' victim dialog, it seems that the extensions dialog has a foul nightmare of manual size calulation all over it ;-) cf. the ~90 lines of: desktop/source/deployment/gui/dp_gui_dialog2.cxx /Resize/ That also happen to do rather a ba

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-11-28 Thread Olivier Hallot
(I forgot to attach the patch) -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 >From 1ad41faf91e8c82b812b0135cca3374eae9e8db6 Mon Sep 17 00:00:00 2001 From: Olivier Hallot Date: Mon, 28 Nov 2

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-11-28 Thread Olivier Hallot
Hi Michael Em 28-11-2011 18:18, Michael Meeks escreveu: Some post-commit I missed (I don't know how to fix a patch): in /desktop/source/deployment/gui/dp_gui.hrc, please drop the line +#define RID_EM_BTN_SELECT 23 in /desktop/source/deployment/gui/dp_gui_dialog2.cxx, pl