Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-25 Thread Michael Meeks
Hi Saito, On Fri, 2011-03-25 at 14:50 -0300, saito wrote: > I discovered what is wrong with the perl files that dows not uses > shebangs. The perl file postprocess/rebase.pl is a valid executable > script, but it does not uses shebang. Right - it uses this env trick to avoid hard-coding the path

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-25 Thread saito
I discovered what is wrong with the perl files that dows not uses shebangs. The perl file postprocess/rebase.pl is a valid executable script, but it does not uses shebang.I took /usr/share/file/magic and there it is a mention for that kind of "magic" sign:... # commands:  file(1) magic for various

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-24 Thread Miklos Vajna
On Wed, Mar 23, 2011 at 11:58:44PM -0600, Tor Lillqvist wrote: > > Can you send me the git-hook pre-commit so I can try to modify it to make > > this tests automatically? > > but it should be in your git clone, surely? And whenever you invoke './g', it enables them in the local repo. Do a 'g d

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-23 Thread Tor Lillqvist
> Note: The exclusion pattern was needed because I have noted that some perl > files are not using shebang, so the "file command" cannot detect it as > executable. But if a Perl (or some other) script doesn't start with a #!, then it isn't executable. It can't be run as a command just by itsel

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-23 Thread saito
Hi,My script does not uses file extensions to check if a file is meant to be executable.It uses file extensions just for exclusion pattern. Mainly because I have found perl files that does not use shebangs (like postprocess/base/rebase.pl)The script uses the Unix/Linux command "file" to check if t

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-23 Thread Thomas Arnhold
Hi, only short note from me: You won't find all wrong chmod'ed files with the help of extensions. For example in bootstrap, there are the file "post_download" or "download". These need to be executable. You could check for these files if you do "head -n1 FILE" and look if this first line has a /b

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-23 Thread saito
Hi,I have written an simple script based on find and file commands.To use it, first it needs to set the exclusion pattern inside the script.After that, you can run the script using "test" as argument to list the files that are not meant to be executable, example:./find-non-executables-with-executi

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-23 Thread Tor Lillqvist
> OK. I will pass something like this (with more extensions) on all source > tree and will send patches after this: > > find -name "*.cxx" -o -name "*.hxx" -o -name "*.mk" -exec chmod -x '{}' \; Thanks, but it is simpler to just send the script, once you have a good set of file extensions to h

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-23 Thread saito
Hi,OK. I will pass something like this (with more extensions) on all source tree and will send patches after this: find -name "*.cxx" -o -name "*.hxx" -o -name "*.mk" -exec chmod -x '{}' \;I have also tried to look for git-hooks but it looks like it is outside the source tree or I was unable to fi

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-23 Thread Tor Lillqvist
Thanks, but maybe we should simply run a script over all the repos to chmod -x any .cxx .hxx .mk etc files? And then add a git hook to remove x bits in the future if they are accidentally introduced to source files or makefiles. --tml ___ LibreOffic

[Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-23 Thread Francisco Kem Iti Saito
Hi, This will remove execution bit from some source files on the project filters. patch sended under LPGLv3+/MPL ! -- Francisco Kem Iti Saito 4Linux - Brazil diff below: diff --git a/oox/source/token/tokens.hxx.head b/oox/source/token/tokens.hxx.head old mode 100755 new mode 1