Re: [Libreoffice] [PATCH] remove dead codes never passed through even in case of MACOSX

2010-12-25 Thread Takeshi Abe
Hi, On Thu, 23 Dec 2010 01:12:40 +0900 (JST), Takeshi Abe wrote: > The lines surrounded by #ifdef/#endif in InterpretCommandLineParameter() > are indeed only for Mac OS X, according to the original issue: > http://qa.openoffice.org/issues/show_bug.cgi?id=84053 > You can browse corresponding OOo

Re: [Libreoffice] [PATCH] remove dead codes never passed through even in case of MACOSX

2010-12-22 Thread Takeshi Abe
Hi Radek, On Wed, 22 Dec 2010 12:02:57 +0100, Radek Doulik wrote: >> Still loitering on EasyHack 3.7, I encountered dead codes as attached. >> They seems safely removable because if -psn given, the call of >> InterpretCommandLineParameter() will catch it and return sal_True, so >> the lines in qu

Re: [Libreoffice] [PATCH] remove dead codes never passed through even in case of MACOSX

2010-12-22 Thread Radek Doulik
Hi Takeshi, On Wed, 2010-12-22 at 17:21 +0900, Takeshi Abe wrote: > Hi, > > Still loitering on EasyHack 3.7, I encountered dead codes as attached. > They seems safely removable because if -psn given, the call of > InterpretCommandLineParameter() will catch it and return sal_True, so > the lines i

[Libreoffice] [PATCH] remove dead codes never passed through even in case of MACOSX

2010-12-22 Thread Takeshi Abe
Hi, Still loitering on EasyHack 3.7, I encountered dead codes as attached. They seems safely removable because if -psn given, the call of InterpretCommandLineParameter() will catch it and return sal_True, so the lines in question will be never passed through. It looks odd noneththeless. Any though