On Mon, Jan 31, 2011 at 6:04 AM, Kenneth Venken
wrote:
>
>
> I think i've implemented all the suggestions. There's one hard coded limit
> (i < 0x1FFF) i don't get. Why isn't it 0x2000 since existMark has a size of
> 0x1. I changed it to i < 0x2000. This will not have an influence on
> xdiction
On Sun, 2011-01-30 at 14:35 +0100, Kenneth Venken wrote:
> So, should i make the changes to the code or have you already done
> them?
Judging by the git log (they're not pushed), I'd say that Norbert
wanted you to re-submit a patch with his suggestions :-)
Looks like some nice cl
On Sun, Jan 30, 2011 at 7:35 AM, Kenneth Venken
wrote:
>> what's the point passing cont as a parameter if you are going to
>> override it's value right away ? (note: ok so, patch 0005 actually fix
>> that...)
>
> these patches should be viewed as a wholel. The refactoring was a process.
> But you'
Norbert,
thanks for the feedback.
2011/1/30 Norbert Thiebaud
> On Sat, Jan 29, 2011 at 5:43 PM, Kenneth Venken
> wrote:
> > Hi,
> >
> > i came across gendict.cxx while fixing a possible memleak. It took me
> some
> > time to figure out what the code did.
> > I notice a lot of very very long fu
On Sat, Jan 29, 2011 at 5:43 PM, Kenneth Venken
wrote:
> Hi,
>
> i came across gendict.cxx while fixing a possible memleak. It took me some
> time to figure out what the code did.
> I notice a lot of very very long function bodies in LO-code, gendict was no
> exception. So i refactored the code, d
Hi,
i came across gendict.cxx while fixing a possible memleak. It took me some
time to figure out what the code did.
I notice a lot of very very long function bodies in LO-code, gendict was no
exception. So i refactored the code, did some google searches on gendict and
was able to fix the memleak.
