Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks [RESOLVED]

2011-01-21 Thread Michael Meeks
On Thu, 2011-01-20 at 20:27 +0100, Bircher Florian wrote: > Seems like M.Meeks did make some changes and PUSHED it to master: > "cope with change of path, and broken absolute links this generates" > SHA1 ID: 52dc7cfbcdd2b71d789ec1068bebcde44235dcdc :-) Hope I didn't break anything too bad

Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks [RESOLVED]

2011-01-20 Thread Bircher Florian
Hi Seems like M.Meeks did make some changes and PUSHED it to master: "cope with change of path, and broken absolute links this generates" SHA1 ID: 52dc7cfbcdd2b71d789ec1068bebcde44235dcdc My comment to the patch: You don't need to use force for ln if you delete the symlink before. ___

Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks

2011-01-19 Thread Norbert Thiebaud
On Wed, Jan 19, 2011 at 5:29 PM, Bircher Florian wrote: > that's one solution ... the other to compare the DIR and RAWBUILDDIR sure, but making it clear _why_ has some merit. Explicitly excluding "bootstrap" it is a bit more clear (to me). especially since it is already done earlier in the code

Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks

2011-01-19 Thread Miklos Vajna
On Wed, Jan 19, 2011 at 11:36:21PM +0100, Bircher Florian wrote: > for cygwin -e check seems to check if the "target of the symlink" > exists, not the symlink ifself... AFAIK, that's not specific to cygwin. Use -h to check if the path is an existing symlink, use -e to check if the path is a) a s

Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks

2011-01-19 Thread Bircher Florian
that's one solution ... the other to compare the DIR and RAWBUILDDIR Am 19.01.2011 23:43, schrieb Norbert Thiebaud: > On Wed, Jan 19, 2011 at 4:36 PM, Bircher Florian wrote: > ahh, yes: once upon a time bootstrap was a cloned git repo like the > other... but now there is no need for links since

Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks

2011-01-19 Thread Norbert Thiebaud
On Wed, Jan 19, 2011 at 4:36 PM, Bircher Florian wrote: > for cygwin -e check seems to check if the "target of the symlink" > exists, not the symlink ifself... > But there is a error in the script that this function gets called in the > main repro (bootstrap) ... and create symlinks like "ln -s te

Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks

2011-01-19 Thread Bircher Florian
for cygwin -e check seems to check if the "target of the symlink" exists, not the symlink ifself... But there is a error in the script that this function gets called in the main repro (bootstrap) ... and create symlinks like "ln -s test test". I will create a new patch. Am 19.01.2011 23:03, schr

Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks

2011-01-19 Thread Norbert Thiebaud
On Wed, Jan 19, 2011 at 3:46 PM, Bircher Florian wrote: > Hi, > I moved the full repo on win7. After that the symlinks where still > pointing to the old destination (they are absolute). The small patch > force the recreation of this links on ./g pull|clone. > > for all my commits here: > Contribut

[Libreoffice] [PATCH] g warper: forcing the recreation of symlinks

2011-01-19 Thread Bircher Florian
Hi, I moved the full repo on win7. After that the symlinks where still pointing to the old destination (they are absolute). The small patch force the recreation of this links on ./g pull|clone. for all my commits here: Contributed under the LGPLv3+ / MPL >From 69d361ff62e4eb25acb6c86418adc3b0a357