Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-29 Thread Miklos Vajna
On Mon, Mar 28, 2011 at 09:54:56AM +0200, Cedric Bosdonnat wrote: > Ok, go and push it: it looks OK to me... Just make sure to leave another > easy hack for the position thing ;) Done: http://wiki.documentfoundation.org/Development/Easy_Hacks#Save_position_of_tab_dialogs pgpu9Rxljbxi1.pgp Desc

Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-28 Thread Michael Meeks
Hi Miklos, On Sat, 2011-03-26 at 17:16 +0100, Miklos Vajna wrote: > So I just went the route what Michael suggested, to keep the patch sort, > see the attachement. So - of course you should push that :-) > Of course, in a separate future patch it would be interesting to fix > SfxTabDialo

Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-28 Thread Cedric Bosdonnat
Hi Miklos, On Sat, 2011-03-26 at 17:16 +0100, Miklos Vajna wrote: > On Sat, Mar 26, 2011 at 12:42:36AM +0100, Miklos Vajna > wrote: > > Ah, I didn't see it. We talked about this with Cedric and he explained > > an idea which avoids any modification in vcl, so I'm not planning to > > push this ve

Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-26 Thread Bernhard Dippold
Hi Miklos, all, thanks for this feature! Complex style modifications will become much easier this way, when you don't need to close the window every time you want to have a look at the changes. Is somebody of the documentation team aware of such changes, so it might be included in the next

Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-26 Thread Miklos Vajna
On Sat, Mar 26, 2011 at 12:42:36AM +0100, Miklos Vajna wrote: > Ah, I didn't see it. We talked about this with Cedric and he explained > an idea which avoids any modification in vcl, so I'm not planning to > push this version, a better one will come soon. > > The main problem is not with the mod

Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-25 Thread Miklos Vajna
On Fri, Mar 25, 2011 at 08:48:25PM +, Michael Meeks wrote: > Looks lovely to me - though I guess it might be nice to just pick a > large number for RET_APPLY and not put that in vcl; that seems to be > how others do it eg. > > sfx2/inc/docvor.hxx:#define RET_EDIT_STYLE 100 > sfx

Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-25 Thread Michael Meeks
Hi Miklos, On Thu, 2011-03-24 at 12:17 +0100, Miklos Vajna wrote: > I'm attaching two patches, one for vcl, one for sw. Of course I could > introduce the define in sw, but that would cause problems when someone > would introduce a new define in vcl, so I did it this way. Looks lovely to m

[Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-24 Thread Miklos Vajna
Hi, I'm attaching two patches, one for vcl, one for sw. Of course I could introduce the define in sw, but that would cause problems when someone would introduce a new define in vcl, so I did it this way. Also, I can change the indentation in sw/source/ui/app/docst.cxx, I didn't do it yet for easi