Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-09 Thread Michael Stahl
On 08.09.2011 02:40, Norbert Thiebaud wrote: > On Wed, Sep 7, 2011 at 7:23 PM, Norbert Thiebaud wrote: >> >> I suppose that to be perfect that should bu tuck under >> gb_LinkTarget_use_Mesa in RepositoryExternal.mk to properly deal with >> the case when using system-mesa vs internal-mesa... >> >>

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Norbert Thiebaud
On Thu, Sep 8, 2011 at 1:03 AM, Norbert Thiebaud wrote: > I've had some success with the attached modifed version of you patch btw Peter, I ran a quick test on a Linux box that has SYSTEM_MESA_HEADERS=NO .. it would be nice to test that the case SYSTEM_MESA_HEADER=YES is not borked... If that w

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Norbert Thiebaud
I've had some success with the attached modifed version of you patch Norbert mesa.modified.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Peter Foley
On Wed, 7 Sep 2011, Norbert Thiebaud wrote: > On Wed, Sep 7, 2011 at 6:47 PM, Peter Foley wrote: > > On Wed, 7 Sep 2011, Bjoern Michaelsen wrote: > > > >> On Wed, 7 Sep 2011 15:32:21 -0500 > >> Norbert Thiebaud > >> wrote: > >> > >> > I wonder would that work dep wise to just have a packaging st

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Norbert Thiebaud
On Wed, Sep 7, 2011 at 7:23 PM, Norbert Thiebaud wrote: > > I suppose that to be perfect that should bu tuck under > gb_LinkTarget_use_Mesa in RepositoryExternal.mk to properly deal with > the case when using system-mesa vs internal-mesa... > > and then just add Mesa to the list of 'use_externals'

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Norbert Thiebaud
On Wed, Sep 7, 2011 at 6:47 PM, Peter Foley wrote: > On Wed, 7 Sep 2011, Bjoern Michaelsen wrote: > >> On Wed, 7 Sep 2011 15:32:21 -0500 >> Norbert Thiebaud >> wrote: >> >> > I wonder would that work dep wise to just have a packaging step ? >> >> $(call gb_Library_get_headers_target,libthatneedsm

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Peter Foley
On Wed, 7 Sep 2011, Bjoern Michaelsen wrote: > On Wed, 7 Sep 2011 15:32:21 -0500 > Norbert Thiebaud > wrote: > > > I wonder would that work dep wise to just have a packaging step ? > > $(call gb_Library_get_headers_target,libthatneedsmesa) : \ > $(call gb_Package_get_target,Mesa_inc) > > Of co

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Norbert Thiebaud
argh... bjorn use of gmane screw-up my reply-all thing... On Wed, Sep 7, 2011 at 5:04 PM, Norbert Thiebaud wrote: > On Wed, Sep 7, 2011 at 4:24 PM, Bjoern Michaelsen > wrote: >> >> >> On Wed, 7 Sep 2011 15:32:21 -0500 >> Norbert Thiebaud >> wrote: >> >>> I wonder would that work dep wise to jus

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Michael Stahl
On 07.09.2011 22:32, Norbert Thiebaud wrote: > On Wed, Sep 7, 2011 at 2:45 PM, Michael Stahl wrote: >> On 07.09.2011 21:15, Peter Foley wrote: >>> >>> This is my first attempt at converting a module to gbuild so I'd >>> appreciate it if someone knowlegeable about gbuild could take a look. >>> >>>

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Bjoern Michaelsen
On Wed, 7 Sep 2011 15:32:21 -0500 Norbert Thiebaud wrote: > I wonder would that work dep wise to just have a packaging step ? $(call gb_Library_get_headers_target,libthatneedsmesa) : \ $(call gb_Package_get_target,Mesa_inc) Of course, we could create a new name for that, but IMHO that is simple

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Michael Stahl
On 07.09.2011 22:40, Tor Lillqvist wrote: >>> ok, fits in better with the other RepositoryFoo.mk stuff. >>> but why not just RepositoryModule.mk? > >> Some hope/anticipation that there may be more than one product sharing >> the same spaces ? not sure... > > I have never fully understood why we

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Tor Lillqvist
>> ok, fits in better with the other RepositoryFoo.mk stuff. >> but why not just RepositoryModule.mk? > Some hope/anticipation that there may be more than one product sharing > the same spaces ?  not sure... I have never fully understood why we have these Repository*.mk files in the top directory

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Norbert Thiebaud
On Wed, Sep 7, 2011 at 2:45 PM, Michael Stahl wrote: > On 07.09.2011 21:15, Peter Foley wrote: >> >> This is my first attempt at converting a module to gbuild so I'd >> appreciate it if someone knowlegeable about gbuild could take a look. >> >> Thanks, >> >> Peter > > hi Peter, > > looks good, did

Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Michael Stahl
On 07.09.2011 21:15, Peter Foley wrote: > > This is my first attempt at converting a module to gbuild so I'd > appreciate it if someone knowlegeable about gbuild could take a look. > > Thanks, > > Peter hi Peter, looks good, didn't know we have such a simple module :) only thing missing is t

[Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-07 Thread Peter Foley
This is my first attempt at converting a module to gbuild so I'd appreciate it if someone knowlegeable about gbuild could take a look. Thanks, Peter From 10805bdc9f4213e4e50a13575c41b3b222453af3 Mon Sep 17 00:00:00 2001 From: Peter Foley Date: Wed, 7 Sep 2011 15:07:40 -0400 Subject: [PATCH] co