Re: [Libreoffice] [PATCH] bug fdo#37164

2011-09-20 Thread Noel Power
On 20/09/11 16:27, Caolán McNamara wrote: On Tue, 2011-09-20 at 09:59 +0100, Noel Power wrote: I'm looking for someone to bless/approve ( and or ) commit the patch to the 3.4 branch The only things outside of testtool which are touched look like an early return from SbFormFactory::CreateObject

Re: [Libreoffice] [PATCH] bug fdo#37164

2011-09-20 Thread Caolán McNamara
On Tue, 2011-09-20 at 09:59 +0100, Noel Power wrote: > I'm looking for someone to bless/approve ( and or ) commit the patch to > the 3.4 branch The only things outside of testtool which are touched look like an early return from SbFormFactory::CreateObject if vba is enabled and a removed HelpID f

[Libreoffice] [PATCH] bug fdo#37164

2011-09-20 Thread Noel Power
Hi, The automation testtool thingy is broken on 3.4 ( and master too... but that's a different story ) The root cause of the problem was caused by cws changehid which replaced numerical hid's by strings and additionally removed the class SmartId. The testtool code was adjusted ( but not complet