Re: [Libreoffice] [PATCH] avoid ambiguous else

2011-02-03 Thread Takeshi Abe
Hi Kohei, Thomas, On Wed, 02 Feb 2011 17:44:37 -0500, Kohei Yoshida wrote: > On Wed, 2011-02-02 at 23:27 +0100, Thomas Arnhold wrote: >> Oh, I think this was a mistake o mine. I removed the brackets, didn't >> really thought, that the else statement could be associated with the >> inner if. I att

Re: [Libreoffice] [PATCH] avoid ambiguous else

2011-02-02 Thread Thomas Arnhold
Thanks ;) On 02/02/2011 11:44 PM, Kohei Yoshida wrote: > On Wed, 2011-02-02 at 23:27 +0100, Thomas Arnhold wrote: >> Oh, I think this was a mistake o mine. I removed the brackets, didn't >> really thought, that the else statement could be associated with the >> inner if. I attached the patch to br

Re: [Libreoffice] [PATCH] avoid ambiguous else

2011-02-02 Thread Kohei Yoshida
On Wed, 2011-02-02 at 23:27 +0100, Thomas Arnhold wrote: > Oh, I think this was a mistake o mine. I removed the brackets, didn't > really thought, that the else statement could be associated with the > inner if. I attached the patch to bring the brackets back. No worries I'd already put the fix in

Re: [Libreoffice] [PATCH] avoid ambiguous else

2011-02-02 Thread Thomas Arnhold
Oh, I think this was a mistake o mine. I removed the brackets, didn't really thought, that the else statement could be associated with the inner if. I attached the patch to bring the brackets back. -Thomas On 02/02/2011 08:38 PM, Kohei Yoshida wrote: > On Thu, 2011-02-03 at 03:20 +0900, Takeshi A

Re: [Libreoffice] [PATCH] avoid ambiguous else

2011-02-02 Thread Kohei Yoshida
On Thu, 2011-02-03 at 03:20 +0900, Takeshi Abe wrote: > Hi, > > On building calc, I found a warning suggesting an ambiguous "else". > The attached patch is under LGPLv3+/MPL. Hmm... But your patch may change the intention of that code block based on how the lines are indented. Here is the code w

Re: [Libreoffice] [PATCH] avoid ambiguous else

2011-02-02 Thread Kohei Yoshida
On Thu, 2011-02-03 at 03:20 +0900, Takeshi Abe wrote: > Hi, > > On building calc, I found a warning suggesting an ambiguous "else". > The attached patch is under LGPLv3+/MPL. Hmm... But your patch may change the intention of that code block based on how the lines are indented. Here is the code w

[Libreoffice] [PATCH] avoid ambiguous else

2011-02-02 Thread Takeshi Abe
Hi, On building calc, I found a warning suggesting an ambiguous "else". The attached patch is under LGPLv3+/MPL. Cheers, -- Takeshi Abe >From 5f9df0274b47fbf81bf2dc3789dd5e8719360549 Mon Sep 17 00:00:00 2001 From: Takeshi Abe Date: Thu, 3 Feb 2011 03:13:53 +0900 Subject: [PATCH] avoid ambiguous