Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-19 Thread Michael Meeks
Hi Mike, On Mon, 2011-07-18 at 16:07 -0700, Mike Eberdt wrote: > seriously yet. And as I understand it, a transition is underway to GNU > make, so I guess I've been a bit reluctant to put a lot of time into > learning the old build system. Yes - there is some horrible sterilisation of

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-18 Thread David Tardon
On Mon, Jul 18, 2011 at 05:33:56PM -0700, Mike Eberdt wrote: > Hi Christian, > > On 07/18/11 04:56, Christian Lohmaier wrote: > > > >Hi MIke, *, > > > >On Fri, Jul 15, 2011 at 9:34 PM, Mike Eberdt wrote: > >> > >>Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD > >>/bin/sh

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-18 Thread Tor Lillqvist
> My 'dmake' fu is basically non-existent, so I haven't poked at this seriously > yet. [...] a transition is underway to GNU make Oh, (unfortunately) you have it backwards regarding the complexity;) dmake is mostly a normal make with few special features. Understanding how things work in the ol

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-18 Thread Tor Lillqvist
> So as long as the OS check is first, we don't evaluate $EUID except on Cygwin. But it wasn't as such the existence or not of $EUID that was the problem here, was it? The problem was the use of -eq operator when the left-hand side of the operator, "$EUID" , was an empty string and thus not a nu

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-18 Thread Mike Eberdt
Hi Christian, On 07/18/11 04:56, Christian Lohmaier wrote: Hi MIke, *, On Fri, Jul 15, 2011 at 9:34 PM, Mike Eberdt wrote: Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD /bin/sh is not synonymous with bash. Therefore, bash-isms in configure.in can be problematic.

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-18 Thread Mike Eberdt
Hi Mike, On 07/18/11 04:23, Michael Meeks wrote: Hi Mike, On Fri, 2011-07-15 at 12:34 -0700, Mike Eberdt wrote: This patch eliminates a "test: : bad number" diagnostic on FreeBSD. Contributed under LGPL3+/MPL. Thanks; I pushed it, and then updated it to use: if test "z$EUID" = "z0"

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-18 Thread Mike Eberdt
On 07/17/11 23:47, Tor Lillqvist wrote: Would it not be simpler to change the -eq to = ? Anyway, good catch! --tml I guess I didn't go that route because my brain tends to avoid the "zFoo" = "zBar" construct if possible. But yes, I should have written it in the form that Michael Meeks check

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-18 Thread Christian Lohmaier
Hi MIke, *, On Fri, Jul 15, 2011 at 9:34 PM, Mike Eberdt wrote: > > Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD > /bin/sh is not synonymous with bash.  Therefore, bash-isms in configure.in > can be problematic. I don't understand your patch then. -if test "$EUID" -eq

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-18 Thread Michael Meeks
Hi Mike, On Fri, 2011-07-15 at 12:34 -0700, Mike Eberdt wrote: > This patch eliminates a "test: : bad number" diagnostic on FreeBSD. > Contributed under LGPL3+/MPL. Thanks; I pushed it, and then updated it to use: if test "z$EUID" = "z0" -a "z`uname -o 2>/dev/null`" = "zCygwin"; then

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-17 Thread Tor Lillqvist
Would it not be simpler to change the -eq to = ? Anyway, good catch! --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-15 Thread Mike Eberdt
Greetings, Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD /bin/sh is not synonymous with bash. Therefore, bash-isms in configure.in can be problematic. This patch eliminates a "test: : bad number" diagnostic on FreeBSD. Contributed under LGPL3+/MPL. Thanks, Mike E