Re: [Libreoffice] [PATCH] Simple fix for frmsh.cxx to review (from cppcheck report)

2012-01-15 Thread julien2412
You're absolutely right ! It can't be both at the same time :-( Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-Simple-fix-for-frmsh-cxx-to-review-from-cppcheck-report-tp3658800p3662400.html Sent from the Dev mailing list archive at Nabble.com.

Re: [Libreoffice] [PATCH] Simple fix for frmsh.cxx to review (from cppcheck report)

2012-01-15 Thread David Tardon
On Sat, Jan 14, 2012 at 04:08:46AM -0800, julien2412 wrote: > Hello, > > cppcheck reported this : > core/sw/source/ui/shells/frmsh.cxx > 516 duplicateExpression style Same expression on both sides of '&&' > > After a quick reading, i thought about this page but perhaps it's less > straigh

[Libreoffice] [PATCH] Simple fix for frmsh.cxx to review (from cppcheck report)

2012-01-14 Thread julien2412
Hello, cppcheck reported this : core/sw/source/ui/shells/frmsh.cxx 516 duplicateExpression style Same expression on both sides of '&&' After a quick reading, i thought about this page but perhaps it's less straightforward than I think diff --git a/sw/source/ui/shells/frmsh.cxx b/sw/sou