Sorry to waste your time, I'll have another run at this on Wednesday,
when I get back from a business trip.
On Sat, Jan 14, 2012 at 00:32, Kohei Yoshida wrote:
> On Fri, 2012-01-13 at 17:00 -0500, Kohei Yoshida wrote:
>> On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote:
>> > Let me do a tho
On Fri, 2012-01-13 at 17:00 -0500, Kohei Yoshida wrote:
> On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote:
> > Let me do a thorough review of your patch one more time, and I'll push
> > to master.
>
> Unfortunately one of the filters-test fails on master, after applying
> the patch. The c
On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote:
> Let me do a thorough review of your patch one more time, and I'll push
> to master.
Unfortunately one of the filters-test fails on master, after applying
the patch. The crash occurs in ScColumn::CloneCell, at line 824 which
is
switch
On Fri, 2012-01-13 at 20:36 +0200, Noel Grandin wrote:
> Hi
>
> Oh no!, I was testing some stuff and accidentally commented out the
> critical line in ScColumn::Append().
>
> This line
> +//aItems.resize(nSize);
> should be
> +aItems.resize(nSize);
I guess you meant ScColumn::Resize()?
Hi
Oh no!, I was testing some stuff and accidentally commented out the
critical line in ScColumn::Append().
This line
+//aItems.resize(nSize);
should be
+aItems.resize(nSize);
We could call reserve() on the vector to allocate extra capacity, but
I don't think there is any way to get exac
On Fri, 2012-01-13 at 10:39 -0500, Kohei Yoshida wrote:
> The only thing I'd like to check is that, I believe we had some sort
> of
> column array resizing policy which controls whether we should increase
> its size only to the minimum necessary size or increase it to a size
> larger than necessary
On Fri, 2012-01-13 at 09:06 +0200, Noel Grandin wrote:
> Hi
>
> This patch converts open-coded array management to std::vector in ScColumn
Hello Noel,
I just took a quick look at your patch, and it looks good & I'm more
than willing to push this change verbatim.
The only thing I'd like to check
I forgot to say that the patch passes the unit tests, and a valgrind run
(I love that tool).
On 2012-01-13 09:06, Noel Grandin wrote:
Hi
This patch converts open-coded array management to std::vector in
ScColumn
Regards, Noel Grandin
Disclaimer: http://www.peralex.com/disclaimer.html
__
