Re: [Libreoffice] [PATCH] SIMIAN: Reduced duplicate code

2012-01-31 Thread Chr. Rossmanith
Am 31.01.2012 11:43, schrieb Noel Power: On 31/01/12 09:11, Chr. Rossmanith wrote: please have a look at the comments marked with "crossmanith". I can push on my own but a short review (and feedback) would be nice. isn't it that nInc can only be either 2, 4, 10 or 20 so that line indicated c

Re: [Libreoffice] [PATCH] SIMIAN: Reduced duplicate code

2012-01-31 Thread Noel Power
On 31/01/12 09:11, Chr. Rossmanith wrote: Hi, please have a look at the comments marked with "crossmanith". I can push on my own but a short review (and feedback) would be nice. isn't it that nInc can only be either 2, 4, 10 or 20 so that line indicated can't afaics be reached and nSteps wo

[Libreoffice] [PATCH] SIMIAN: Reduced duplicate code

2012-01-31 Thread Chr. Rossmanith
Hi, please have a look at the comments marked with "crossmanith". I can push on my own but a short review (and feedback) would be nice. Christina >From ac8d464245852f701478039f89ae876d6584fb88 Mon Sep 17 00:00:00 2001 From: Christina Rossmanith Date: Tue, 31 Jan 2012 10:07:19 +0100 Subject: [