Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-04-13 Thread Noel Power
On 12/04/11 19:44, Christina Roßmanith wrote: Removed last occurences of _USE_UNO, built successfully and pushed. Christina great and thanks for your excellent efforts !!! Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://li

Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-04-12 Thread Christina Roßmanith
Removed last occurences of _USE_UNO, built successfully and pushed. Christina Am 12.04.2011 10:49, schrieb Noel Power: On 11/04/11 15:55, Thorsten Behrens wrote: Noel Power wrote: As far as I understand the code it consists merely of test calls to functions in order to see if they return a v

Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-04-12 Thread Korrawit Pruegsanusak
Hello On Tue, Apr 12, 2011 at 19:27, Christina Roßmanith wrote: > Is there a way to search for all commits I've done so far? I'll finish that, of course! Maybe using search box in the top-right of the page like this works for you? http://cgit.freedesktop.org/libreoffice/libs-core/log/?qt=author&

Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-04-12 Thread Christina Roßmanith
_USE_UNO: I thought, that I had removed everything #ifdef'ed with _USE_UNO. BUT I've found some occurences in ./basic. Is there a way to search for all commits I've done so far? I'll finish that, of course! Christina Am 12.04.2011 10:49, schrieb Noel Power: On 11/04/11 15:55, Thorsten Behrens

Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-04-12 Thread Noel Power
On 11/04/11 15:55, Thorsten Behrens wrote: Noel Power wrote: As far as I understand the code it consists merely of test calls to functions in order to see if they return a valid result. I'm quite sure that you already know whether it has side effects or not... I vote for "it hasn't", but I'm abs

Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-04-11 Thread Thorsten Behrens
Noel Power wrote: > >As far as I understand the code it consists merely of test calls > >to functions in order to see if they return a valid result. I'm > >quite sure that you already know whether it has side effects or > >not... I vote for "it hasn't", but I'm absolutely not sure > nah, just seems

Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-03-22 Thread Noel Power
Hi Christina On 21/03/11 22:28, Christina Roßmanith wrote: nd calls nothing that does that ? As far as I understand the code it consists merely of test calls to functions in order to see if they return a valid result. I'm quite sure that you already know whether it has side effects or not... I

Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-03-21 Thread Christina Roßmanith
Am 21.03.2011 18:10, schrieb Michael Meeks: On Mon, 2011-03-21 at 13:44 +0100, Christina Roßmanith wrote: I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it was never defined. It builds successfully. Could someone please review to make sure that nothing was deleted accidental

Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-03-21 Thread Christina Roßmanith
Am 21.03.2011 18:10, schrieb Michael Meeks: On Mon, 2011-03-21 at 13:44 +0100, Christina Roßmanith wrote: I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it was never defined. It builds successfully. Could someone please review to make sure that nothing was deleted accidental

Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-03-21 Thread Michael Meeks
On Mon, 2011-03-21 at 13:44 +0100, Christina Roßmanith wrote: > I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it > was never defined. It builds successfully. Could someone please review > to make sure that nothing was deleted accidentally? @@ -427,7 +425,7 @@ void OslStrea

[Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

2011-03-21 Thread Christina Roßmanith
Hi, I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it was never defined. It builds successfully. Could someone please review to make sure that nothing was deleted accidentally? Thank you, Christina >From 665f2746fe89509f5e3e44ce9f263b5befe3cc34 Mon Sep 17 00:00:00 2001 Fr