On Wed, Jan 5, 2011 at 12:56 PM, Soeren Moeller
wrote:
> Hi and thank you for your comments
>
> 2011/1/5 Kohei Yoshida :
>> Hi Sören,
>>>
>>> +#include
>>> #include "address.hxx"
>>
>> This should not be necessary (though it won't hurt) as the address.hxx
>> already includes sal types. Does it
On Thu, 2011-01-06 at 11:27 +, Michael Meeks wrote:
> On Wed, 2011-01-05 at 19:56 +0100, Soeren Moeller wrote:
> > It is not an attachment as I used "git send-email"
>
> Heh - the kernel guys prefer in-line patches it seems; they find them
> easier to review and comment on that way; per
On Wed, 2011-01-05 at 19:56 +0100, Soeren Moeller wrote:
> It is not an attachment as I used "git send-email"
Heh - the kernel guys prefer in-line patches it seems; they find them
easier to review and comment on that way; personally - I don't care, its
easy enough to save a file as an mb
Hi and thank you for your comments
2011/1/5 Kohei Yoshida :
> Hi Sören,
>
> Thanks for the patch. Is there a reason why this one is not an
> attachment? :-)
It is not an attachment as I used "git send-email" to send it to the
mailing list, but the result seems a bit wierd when reading the list,
a
Hi Sören,
Thanks for the patch. Is there a reason why this one is not an
attachment? :-)
Anyway, I have some comments.
On Tue, 2011-01-04 at 20:20 +0100, Sören Möller wrote:
> Replaced datatypes from tools/solar.h with corresponding types from
> sal/types.h in drawpage.hxx/.cxx and added missi
Replaced datatypes from tools/solar.h with corresponding types from sal/types.h
in drawpage.hxx/.cxx and added missing include of sal/types.h in docparam.hxx
---
sc/inc/docparam.hxx |1 +
sc/inc/drawpage.hxx |4 ++--
sc/source/core/data/drawpage.cxx |2 +-
3
