[PUSHED] Re: [Libreoffice] [PATCH] Remove unused code

2012-02-06 Thread Jan Holesovsky
Noel Power píše v Út 31. 01. 2012 v 12:39 +: > ok, pushed, Just marking the thread [PUSHED] :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove unused code

2012-01-31 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 4eaa8adb17c0334f08c83509644b45553254376e Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Tue, 31 Jan 2012 19:59:31 +0100 Subject: [PATCH] Remove unused code. --- chart2/source/view/axes/Tickmarks_Equidistant.cxx | 27 -

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-31 Thread Noel Power
On 31/01/12 11:05, Elton Chung wrote: Hi Noel, *, I have attached the patch as an attachment. I also confirm that this contribution, as well as future ones are licensed under MPL 1.1 / GPL v3+ / LGPL v3+. ok, pushed, thank, ps. next time don't chop off the header of the formatted patch 'cause '

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-31 Thread Elton Chung
Hi Noel, *, I have attached the patch as an attachment. I also confirm that this contribution, as well as future ones are licensed under MPL 1.1 / GPL v3+ / LGPL v3+. Best Regards, Elton -- Elton Chung Administrator, sponsor of mirror.layerjet.com Language Maintainer of ReactOS Open Source operat

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-31 Thread Noel Power
Hi Elton First thanks for submitting your patch, it's appreciated however could I ask if you could please repost your patch as an attachment [1] ? patch content inline in a mail message just does't work as the mail client breaks the lines in such a way as the patch program no longer understand

[Libreoffice] [PATCH] Remove unused code

2012-01-30 Thread Elton Chung
--- sc/inc/scdll.hxx |1 - sc/source/core/inc/ddelink.hxx|1 - sc/source/core/tool/ddelink.cxx | 11 - sc/source/ui/app/scdll.cxx| 10 sc/source/ui/dbgui/fieldwnd.cxx |5 sc/source/ui/inc/areasave.hxx

[Libreoffice] [PATCH] Remove unused code

2012-01-27 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From 7696cfebc875621dd68cbc65dc45772e530a79e7 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Fri, 27 Jan 2012 21:45:33 +0100 Subject: [PATCH] Remove unused code as listed in unusedcode.easy --- sc/source/ui/vba/vbachart.cxx |

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Eike Rathke
Hi Michael, On Friday, 2012-01-20 21:57:25 +0100, Michael Stahl wrote: > > -VclEventListeners2::~VclEventListeners2() > > -{ > > -} > > i'm not sure this is right; if a destructor of a class is unused, but > its other methods are used, then that usually indicates a memory leak: > the destructor

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Stephan Bergmann
On 01/20/2012 09:57 PM, Michael Stahl wrote: i'm not sure this is right; if a destructor of a class is unused, but its other methods are used, then that usually indicates a memory leak: the destructor is never called because all instances are leaked. It might make sense to treat destructors spe

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Michael Stahl
On 20/01/12 20:13, Santiago Martinez wrote: > -VclEventListeners2::~VclEventListeners2() > -{ > -} i'm not sure this is right; if a destructor of a class is unused, but its other methods are used, then that usually indicates a memory leak: the destructor is never called because all instances are

Re: [Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Michael Stahl
On 20/01/12 19:56, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy thanks Santiago for the patch, pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7ce98f34150d430b12804eb9796e4142b7c6517c ___ LibreO

[Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Santiago Martinez
From b42ee34845fdaf5e794a8b9319cf5a736fcbf653 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Fri, 20 Jan 2012 20:06:44 +0100 Subject: [PATCH] Remove unused code. --- unusedcode.easy |1 - vcl/inc/vcl/vclevent.hxx|1 - vcl/source/app/vclevent.cxx |4 3 fi

[Libreoffice] [PATCH] Remove unused code

2012-01-20 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From aea46d66c3f360782436ff53150d92877b687a45 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Fri, 20 Jan 2012 19:42:48 +0100 Subject: [PATCH] Removed unused code as listed in unusedcode.easy --- filter/inc/filter/msfilter/mstool

[Libreoffice] [PATCH] Remove unused code

2011-12-28 Thread Marcel Metz
Hello lo-devs, There is never an instance of mpDateTable allocated and a lot of code is never executed because of that. This patch removes the unused code. regards Marcel --- svtools/inc/svtools/calendar.hxx|3 - svtools/source/control/calendar.cxx | 119 ++-

[Libreoffice] [PATCH] Remove unused code

2011-01-11 Thread Anders Jonsson
Some more commented code, this time in calc. All code has been commented out at least since 2005. Anders Jonsson, (LGPLv3+,MPL) >From 732c13e33612b80ce4e4479698e0710f791de2c4 Mon Sep 17 00:00:00 2001 From: Anders Jonsson Date: Tue, 11 Jan 2011 22:17:44 +0100 Subject: Remove commented code --- s

[Libreoffice] [PATCH] Remove unused code and fix typos

2011-01-08 Thread Takeshi Abe
Hi, Here is a bunch of cleanup on base. Cheers, -- Takeshi Abe >From 17a5c538b6e9ed1c13efda786e39986a82163a98 Mon Sep 17 00:00:00 2001 From: Takeshi Abe Date: Sun, 9 Jan 2011 02:04:00 +0900 Subject: [PATCH] Remove unused code and fix typos --- dbaccess/source/core/api/RowSetCache.cxx

Re: [Libreoffice] [PATCH] Remove unused code

2010-12-22 Thread Radek Doulik
On Wed, 2010-12-22 at 12:00 +0100, Radek Doulik wrote: > On Wed, 2010-12-22 at 11:29 +0100, Radek Doulik wrote: > > Hi Anders, > > > > thanks for your patch. Looks good to me so I pushed it. > > > > It contains sd/ module changes only though, so maybe you forget the ure > > part? > > ops, sorry.

Re: [Libreoffice] [PATCH] Remove unused code

2010-12-22 Thread Radek Doulik
On Wed, 2010-12-22 at 11:29 +0100, Radek Doulik wrote: > Hi Anders, > > thanks for your patch. Looks good to me so I pushed it. > > It contains sd/ module changes only though, so maybe you forget the ure > part? ops, sorry. I managed to miss it when reading your mail, I will review it as well.

Re: [Libreoffice] [PATCH] Remove unused code

2010-12-22 Thread Radek Doulik
Hi Anders, thanks for your patch. Looks good to me so I pushed it. It contains sd/ module changes only though, so maybe you forget the ure part? Cheers Radek On Wed, 2010-12-22 at 08:31 +0100, Anders Jonsson wrote: > Some more unused code, this time in ure and impress. All code has been > comme

[Libreoffice] [PATCH] Remove unused code

2010-12-21 Thread Anders Jonsson
Some more unused code, this time in ure and impress. All code has been commented out at least since 2005. Anders Jonsson (LGPLv3+,MPL) >From 055470cbc7c315c37032667822417f109b7235d1 Mon Sep 17 00:00:00 2001 From: Anders Jonsson Date: Wed, 22 Dec 2010 08:22:12 +0100 Subject: Remove commented code

[Libreoffice] [PATCH] Remove unused code

2010-12-18 Thread Anders Jonsson
Some more blocks of unused code in libs-gui and libs-core. All have been commented out since at least 2006. Anders Jonsson (LGPLv3+,MPL) 0001-Remove-large-blocks-of-commented-code.patch Description: application/mbox 0002-Remove-large-blocks-of-commented-code.patch Description: application/mbo