Re: [Libreoffice] [PATCH] Remove DECLARE_LIST(TOXControlList, Control*)

2010-12-14 Thread Michael Meeks
Hi Joseph, On Mon, 2010-12-13 at 22:12 -0800, Joseph Powers wrote: > Currently I can't build due to a non-related issue so I can't trouble > shoot it. Ah - could that be my icon problems from last night, or the vcl/ dependency issue (just remove the unxlngi6.pro directory) caused by auto

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST(TOXControlList, Control*)

2010-12-13 Thread Joseph Powers
I found where this code is used: Writer -> Insert -> Indexes and Tables -> Indexes and Tables -> Entries. Currently I can't build due to a non-related issue so I can't trouble shoot it. My git foo is also bad enough that I can't figure out how to remove it... Needless to say, my patch causes a

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST(TOXControlList, Control*)

2010-12-13 Thread Michael Meeks
On Sun, 2010-12-12 at 20:26 -0800, Joseph Powers wrote: > I played around in writer a little bit but couldn't figure out where > this code was being used. If someone could point me in the right > direction, I'll do a little more testing. Quite possibly it is simply not used :-) I guess, c

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST(TOXControlList, Control*)

2010-12-12 Thread David Tardon
On Sun, Dec 12, 2010 at 08:26:02PM -0800, Joseph Powers wrote: > > IMPL_LINK(SwTokenWindow, TbxFocusHdl, SwTOXEdit*, pEdit) > IMPL_LINK(SwTokenWindow, TbxFocusBtnHdl, SwTOXButton*, pBtn ) > > I played around in writer a little bit but couldn't figure out where this > code was being used. If some

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST(TOXControlList, Control*)

2010-12-12 Thread Joseph Powers
The patch for DECLARE_LIST( SwXMLFrmFmts_Impl, SwFrmFmtPtr ) was really easy so I pushed it... However, long story short, I also ended up pushing this patch. If anyone has any issues, it can be reverted. I'm sorry for the confusion. Joe P. On Dec 12, 2010, at 8:26 PM, Joseph Powers wrote: >

[Libreoffice] [PATCH] Remove DECLARE_LIST(TOXControlList, Control*)

2010-12-12 Thread Joseph Powers
TOXControlList is used more like a list<> then a vector<>; however, the code was written using mostly [] style accessors. Thus, I had to rewrite a lot of control logic and would like someone else to review it before it gets installed.Two methods where looping through the list list.size() times. Loo