Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian

2012-01-26 Thread Eike Rathke
Hi Christina, Nice find. Just to mention that this > +SAL_DLLPRIVATE Color ImplDrawModeToColor( Color ); > +Color OutputDevice::ImplDrawModeToColor( const Color rColor ) not only should be a const method as Stephan mentioned, but also should get passed a const Color& rColor reference ins

Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian

2012-01-24 Thread Stephan Bergmann
On 01/24/2012 10:32 PM, Christina Roßmanith wrote: Could someone please review it? It builds successfully but I'm unsure about where to use "const"... In short, marking a member function const can (and should) be done whenever the function does not modify its object, and does not itself call

[Libreoffice] [PATCH] Reduced duplicate code detected by simian

2012-01-24 Thread Christina Roßmanith
Hi, after replacing string data types I looked for duplicated code in vcl with simian. Could someone please review it? It builds successfully but I'm unsure about where to use "const"... Thank you, Christina >From 94b9a014e07133fef3f7432d4d6945cd76e66d4d Mon Sep 17 00:00:00 2001 From: Christi