On 17/11/11 20:11, Ivan Timofeev wrote:
> 16.11.2011 21:27, Ivan Timofeev пишет:
>> Can not reproduce crash with removed lines.
>
> Oh, what a terrible formulation! I mean, "Can not reproduce crash, even
> without the mentioned lines of code."
> So, should I commit this removal?
hi Ivan,
certai
16.11.2011 21:27, Ivan Timofeev пишет:
Can not reproduce crash with removed lines.
Oh, what a terrible formulation! I mean, "Can not reproduce crash, even
without the mentioned lines of code."
So, should I commit this removal?
Best Regards,
Ivan
__
2011/11/16 Michael Stahl :
> please try it out: remove the 4 lines, then try print and cancel, then
> try print and close-the-document (to get a high page count just print
> 1000 copies), see that we survive that in Calc and Writer.
Can not reproduce crash with removed lines. :-) Have tried in Wri
On 16/11/11 17:30, Michael Stahl wrote:
> On 16/11/11 17:15, Ivan Timofeev wrote:
>> 2011/11/16 Michael Stahl :
>> When canceling in the print dialog, PrinterController::abortJob() is
>> called, and abortJob calls getPageFile. Your code above returns
>> *before* the call to printPage and this cause
On 16/11/11 17:15, Ivan Timofeev wrote:
> 2011/11/16 Michael Stahl :
>> your workaround looks good (but please add an assertion for the case
>> that we don't get any page number, i.e. OSL_ENSURE(pPreView,...))
>
> Ok!
>
>> isn't m_pPrintUIOptions supposed to be deleted when
>> SwXTextDocument::re
2011/11/16 Michael Stahl :
> your workaround looks good (but please add an assertion for the case
> that we don't get any page number, i.e. OSL_ENSURE(pPreView,...))
Ok!
> isn't m_pPrintUIOptions supposed to be deleted when
> SwXTextDocument::render is called for the last page (and there is
> spe
On 16/11/11 14:35, Ivan Timofeev wrote:
> Hi there,
>
> I have fixed https://bugs.freedesktop.org/show_bug.cgi?id=42178 :-) ,
> but I think an additional review will not be superfluous, since I am
> still a newbie.
>
> The fact is SwDocShell::GetWrtShell() always returns 0 in page
> preview. And
On 16/11/11 13:35, Ivan Timofeev wrote:
Hi there,
I have fixed https://bugs.freedesktop.org/show_bug.cgi?id=42178 :-) ,
but I think an additional review will not be superfluous, since I am
still a newbie.
The fact is SwDocShell::GetWrtShell() always returns 0 in page
preview. And Writer dies du
Hi there,
I have fixed https://bugs.freedesktop.org/show_bug.cgi?id=42178 :-) ,
but I think an additional review will not be superfluous, since I am
still a newbie.
The fact is SwDocShell::GetWrtShell() always returns 0 in page
preview. And Writer dies due to that in "lcl_GetPrintUIOptions"
funct
