Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hi John, Korrawit, On Wed, 2011-07-06 at 22:51 +0700, Korrawit Pruegsanusak wrote: > On Fri, Jun 24, 2011 at 14:38, John LeMoyne Castle > wrote: > > -- you (and others) cannot reproduce fdo#37584 (redlined text disappears) > > in 3-3 or 3-3-3 because my patch referenced in your original post [OP

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hello John, all, First, sorry for my late reply. On Fri, Jun 24, 2011 at 14:38, John LeMoyne Castle wrote: >  -- you (and others) cannot reproduce fdo#37584 (redlined text disappears) > in 3-3 or 3-3-3 because my patch referenced in your original post [OP] is > not in the 3-3 branches. Hmm? I th

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hi Korrawit, My take is: -- you (and others) cannot reproduce fdo#37584 (redlined text disappears) in 3-3 or 3-3-3 because my patch referenced in your original post [OP] is not in the 3-3 branches. -- you and others cannot reproduce 'leading quote as word' in your 3-3 build because the patch

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hello Cedric, Tor, John, all, Yesterday, @vilpan (in irc) and I tested on official 3.3.3 build and can reproduce fdo#33774 ('leading quote as word') But we both can't reproduce fdo#37584. So we should fix only fdo#33774. However, I've found two patches about this in -3-4 and master: http://cgit.f

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

On Wed, 2011-06-22 at 20:58 +0700, Korrawit Pruegsanusak wrote: > Two issues John mentioned are: > 1. fdo#37584: redline text disappear I would be really surprised if that one didn't appear... -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hello all, On Wed, Jun 22, 2011 at 12:59, Tor Lillqvist wrote: > Thanks, committed and pushed to 3-3. (With a slightly improved commit > message.) Thanks :-) On Wed, Jun 22, 2011 at 19:48, Tor Lillqvist wrote: >> Did you backport also the fixes mentioned by John? > > No, the mail thread was o

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

> Did you backport also the fixes mentioned by John? No, the mail thread was otherwise too confusing to me... --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hi Tor, On Tue, 2011-06-21 at 23:59 -0600, Tor Lillqvist wrote: > > Attached patch is a fix for fdo#30550 in comment 11-12 > > Thanks, committed and pushed to 3-3. (With a slightly improved commit > message.) Did you backport also the fixes mentioned by John? -- Cédric Bosdonnat LibreOffice h

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

> Attached patch is a fix for fdo#30550 in comment 11-12 Thanks, committed and pushed to 3-3. (With a slightly improved commit message.) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Attached is another patch (in libs-gui repo) that is in 3.4 but not in 3.3 found with lo-commit-stat using: /bin $>perl lo-commit-stat --log-dir='./' --log-suffix='mjWCRL-3.3' --rev-list ../ --until='2010-12-01' --author='Johnsson' origin/libreoffice-3-4 ^origin/libreoffice-3-3 and shown more di

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hi Korrawit, Cedric, all ... A first, quick reply is that this patch of mine contains the dread redline wipeout: + // make a copy of the text + String& rTextCopy = const_cast(m_Text); The latter needs to be modified to include (or be immediately followed by) Cedric's fix: - String& rTe

[Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hello all, Attached patch is a fix for fdo#30550 in comment 11-12 This is specific to -3-3 only, because it was later fixed in -3-4 and master by http://cgit.freedesktop.org/libreoffice/writer/commit/?id=335534df4946437a12cd3c18b4a24beee188317b by John LeMoyne Castle, but not in -3-3. So, it woul