Hi All.
Once again I wish to thank Joost for taking on this project. I also
wish to thank Kohei for his work and assistance after the fact so that I
could get at look at the results. I am quite happy with what I see and
the way the process works. I have uploaded a pdf of screen shots at
ht
Hi Andy and Kohei,
Hereby additional patch with:
* Check on pName is NULL.
* Showing original sheet name in input box, when Rename option is checked.
Not implemented: OrgName_#.
Joost
2010/12/12 Joost Eekhoorn
> Hi Andy,
>
> Point made.
> I will do the same as in the Rename dialog, thus if
Hi Andy,
Point made.
I will do the same as in the Rename dialog, thus if 'Sheet1' is selected,
the rename input box will show 'Sheet1', when Rename is checked.
I must also fix something in my last patch, now that MoveTable has a pointer
as last argument:
if( rName.Len() )
is changed to:
i
On Sat Dec 11 2010 13:54:38 GMT-0800 (PST) Joost Eekhoorn wrote:
Hi Kohei,
> * I think it would be more user-friendly if the Rename input box
> showed the default sheet name. When moving a sheet, this would be
> the original sheet name, while when copying a sheet it would be the
> origi
Hi Kohei,
Thanks for your review. Hereby an additional patch with changes on 4
comment-items. 2 items are not done.
MPL 1.1 / GPLv3+ / LGPLv3+
> About UI
> * Let's remove the 'New Name' string as I feel this is redundant. And
> let' place the rename box either to the immediate right of 'Rename
On Fri, 2010-12-10 at 20:31 -0500, Kohei Yoshida wrote:
> I'll CC Christoph in case he has some comments on this feature as well
> as on my comments above. Christoph, please feel free to add your
> comments as well if you have any. :-)
And these are the screenshots of the new dialog.
Rename unc
Hi Joost,
On Fri, 2010-12-10 at 20:56 +0100, Joost Eekhoorn wrote:
> Please review if this patch is realy correct and complete.
Good work! This is definitely a step in the right direction. There are
some comments from my side, which I provide below.
About UI
* Let's remove the 'New Name' str
On Fri Dec 10 2010 11:56:32 GMT-0800 (PST) Joost Eekhoorn wrote:
Hi,
Please review if this patch is realy correct and complete.
- 'Rename input box' is only visible when 'Rename check box' is checked.
- Rename is only done when 'Rename check box' is checked and 'Rename
input box'
has a strin
Hi,
Please review if this patch is realy correct and complete.
- 'Rename input box' is only visible when 'Rename check box' is checked.
- Rename is only done when 'Rename check box' is checked and 'Rename input
box'
has a string.
- Rename works for copied and moved sheets.
- Rename works when the
