Re: [Libreoffice] [PATCH] Easy hack patches, remove non-compiled code

2010-11-04 Thread Thorsten Behrens
Kevin Hunter wrote: > Further (with exceptions, of course), automagic tools provide a much > more consistent and at least acceptable-by-all metric for how code > should look. (And I would argue that how code looks via the > squint-test is very *much* pertinent for longer term gathering of > new de

Re: [Libreoffice] [PATCH] Easy hack patches, remove non-compiled code

2010-11-04 Thread Thorsten Behrens
Kevin Hunter wrote: > Further (with exceptions, of course), automagic tools provide a much > more consistent and at least acceptable-by-all metric for how code > should look. (And I would argue that how code looks via the > squint-test is very *much* pertinent for longer term gathering of > new de

Re: [Libreoffice] [PATCH] Easy hack patches, remove non-compiled code

2010-11-04 Thread Kevin Hunter
At 9:47am -0400 Thu, 04 Nov 2010, Thorsten Behrens wrote: I'm sorry if [the request not to make any formatting changes] was not too obvious from the EasyHacks page - do you think adding something like this to the preamble would make it more clear: "please avoid larger reformatting of the code fo

[Libreoffice] [PATCH] Easy hack patches, remove non-compiled code

2010-11-04 Thread Kevin Hunter
Hullo LO Git committers, Patches against calc/.../miscdlgs/ to remove non-compiled code and other minor refactors. Patches created with: $ git format-patch --patience -19 -o ~/tmp/easy_hack_non_compiled $ cd ~/tmp/ # tar -cjf easy_hack_non_compiled{.tbz,} $ sha1sum easy_hack_non_compiled.tbz