Re: [Libreoffice] [PATCH] Commented out some unused functions in calc

2011-02-05 Thread Enrico Weigelt
* Alfonso Eusebio schrieb: > If it's ok to remove the functions from the unused list directly I'm happy to > do > that. I was a bit concerned because some of those functions might be required > at > some point. That's what we have an VCS w/ proper history for ;-p > In most cases they are ju

Re: [Libreoffice] [PATCH] Commented out some unused functions in calc

2011-01-31 Thread Alfonso Eusebio
Hi Cedric, I guess you are right. Keeping the code in there, even if only temporarily, might not make much sense. If it's ok to remove the functions from the unused list directly I'm happy to do that. I was a bit concerned because some of those functions might be required at some point. In m

Re: [Libreoffice] [PATCH] Commented out some unused functions in calc

2011-01-31 Thread Cedric Bosdonnat
Hi Alfonso, On Sat, 2011-01-29 at 15:10 +, Alfonso Eusebio wrote: > Hi, > > I've been going through the list of identified unused functions in calc and > commenting out those that don't seem to be used anywhere. Why don't you simply remove them and check if it still builds? Regards, -- Cé

[Libreoffice] [PATCH] Commented out some unused functions in calc

2011-01-29 Thread Alfonso Eusebio
Hi, I've been going through the list of identified unused functions in calc and commenting out those that don't seem to be used anywhere. Attached is the patch (LGPLv3+/MPL) that comments out some 10 functions and a text file with those investigated so far, and the results. I chose to comment o