On 22/12/10 10:13, Tor Lillqvist wrote:
It seems that this patch is now in master, and it causes compilation errors on
Windows (slightly edited compiler messages for brevity):
sbxdec.cxx(735) : error C2065: 'n' : undeclared identifier
sbxdec.cxx(749) : error C2039: 'pULong64' : is not a member
On 15/12/10 10:04, Noel Power wrote:
Hi John,
On 06/12/10 17:58, Noel Power wrote:
Hi John,
[...]
in sbxToUnoValueImpl ( convert to uno without known target class )
in basic/source/classes/sbunoobj.cxx previously an Double or Float
basic value ( within the range of an int ) was transfered a
It seems that this patch is now in master, and it causes compilation errors on
Windows (slightly edited compiler messages for brevity):
sbxdec.cxx(735) : error C2065: 'n' : undeclared identifier
sbxdec.cxx(749) : error C2039: 'pULong64' : is not a member of 'SbxValues'
sbxdec.cxx(749) : error C38
On Wed, 2010-12-15 at 10:04 +, Noel Power wrote:
> did you look at the changes I committed to the branch ? ( of course
> there are some more changes to look at now :-) ) I'd be interested in
> your thoughts as I would like to get this stuff into master asap
With this rather more tes
Hi John,
On 06/12/10 17:58, Noel Power wrote:
Hi John,
[...]
in sbxToUnoValueImpl ( convert to uno without known target class ) in
basic/source/classes/sbunoobj.cxx previously an Double or Float basic
value ( within the range of an int ) was transfered as a the smallest
type e.g. sal_Int8,
Noel Power wrote:
> b) I also made some changes [one change I made was in ImpCurrencyToString
> ...]
> so I think it makes sense for me to
> create the feature branch ( I will do that today )
Understandable, I apologize that I did not separate the core Currency
changes from the string handling '
Hi John,
On 30/11/10 09:35, John LeMoyne Castle wrote:
Currency is presently implemented with a 64bit struct of 2 Int32s and the
math is done by the tools/bigint class.
The attached patches replace the code to implement the Currency type with an
ISO C99 compiler supported 64 bit integer.
Abso
Hi John,
On Tue, 2010-11-30 at 04:22 -0700, Noel Power wrote:
> > Main patch makes 1/2 kLOC reduction in sbx.
> yeah, so you will have to give me some time to look at this ( not really
> familar with the Currently type ) and I need to somehow filter out the
> whitespace changes too ( probably I can
Hi John,
On Tue, 2010-11-30 at 04:09 -0800, John LeMoyne Castle wrote:
> Hi Noel,
> Sorry about the whitespace problem. Is it because I cleaned up the header
> formatting? I would regenerate the patch but I don't understand clearly what
> the whitespace problem is. Please let me know what I did
Hi John,
On Tue, 2010-11-30 at 01:35 -0800, John LeMoyne Castle wrote:
> Nothing says 'run away' like mangling the money numbers.
:-)
> The attached CurTestODS.ods spreadsheet Basic program CurTestRunAll
> demonstrates the errors from the old implementation:
> -- flagrantly wrong va
More About the Tester -- CurTestODS.ods :: Standard :: CurTestRunAll :
Most of the fix has been done for over a week, but a Basic test program was
required to identify the existing errors, to sort out the scaling factor
application and to demonstrate that the fix does not completely break Basic.
Hi Noel,
Sorry about the whitespace problem. Is it because I cleaned up the header
formatting? I would regenerate the patch but I don't understand clearly what
the whitespace problem is. Please let me know what I did wrong.
There are at least two more iz issues - they are in the primary commit
sending again ( whilst attempting to preserve the threading this time )
On Tue, 2010-11-30 at 01:35 -0800, John LeMoyne Castle wrote:
> OOo Basic has had issues with its fixed point Currency type for a long
time.
> I think the Basic Currency type deficiencies create a bar to adoption
in the
> min
On Tue, 2010-11-30 at 01:35 -0800, John LeMoyne Castle wrote:
> OOo Basic has had issues with its fixed point Currency type for a long time.
> I think the Basic Currency type deficiencies create a bar to adoption in the
> minds of business users.
> Nothing says 'run away' like mangling the mone
OOo Basic has had issues with its fixed point Currency type for a long time.
I think the Basic Currency type deficiencies create a bar to adoption in the
minds of business users.
Nothing says 'run away' like mangling the money numbers.
Currency is presently implemented with a 64bit struct of
15 matches
Mail list logo
