Hello Michael,
I think Eike is already working on this problem, but finally we got that
there is no really good solution, maybe my first advised option could be
applied with success(storing for each comment if there is a query in the
same line in a bool variable). I guess you should consult wi
Hi Jenei,
On Monday, 2011-08-29 19:10:32 +0200, Jenei Gábor wrote:
> Let me to have some questions about your review:
Sure.
> >>+const sal_Unicode* sCopy=sQuery.getStr();
> >>+int nQueryLen=sQuery.getLength();
> >>+bool bIsText1=false;
> >>+bool bIsText2=false;
> >>+bool bCo
Hello Eike,
Let me to have some questions about your review:
2011. 08. 22. 21:47 keltezéssel, Eike Rathke írta:
Hi Jenei,
On Sunday, 2011-08-21 14:59:26 +0200, Jenei Gábor wrote:
+::rtl::OUStringBuffer sTemp;
Construct the buffer with a sufficient capacity beforehand so no memory
alloca
Yes,naturally, I just didn't react because I am already working on
another job, but as soon as I am done I'll do your recommendations, and
your comments were actually useful, I did not know about Stringandclear
method of OUString, and also some notes about memory allocation. So I am
going to do
Hi Jenei,
On Sunday, 2011-08-21 14:59:26 +0200, Jenei Gábor wrote:
> +::rtl::OUStringBuffer sTemp;
Construct the buffer with a sufficient capacity beforehand so no memory
allocation needs to be done in between:
::rtl::OUStringBuffer sTemp( nQueryLen);
> [...]
> +return (::rtl::O
Hello,
Here is a patch for bug 36594. It deletes the comments from the SQL
query and puts them beck for saving and execution. Please review it,and
push it to git.
Gabor
>From 73ff25834cca39cd8d4c08210556aa532b48fb77 Mon Sep 17 00:00:00 2001
From: Gabor Jenei
Date: Sun, 21 Aug 2011 14:51:15 +0200
