Re: [Libreoffice] [PATCH]: fixes compiler warnings for vcl/workben/svpclient.cxx

2011-05-23 Thread Tor Lillqvist
> Together with svptest, it excersises the headless mode - so you can > watch vcl render to some framebuffer device. Still useful code. OK. So shouldn't we then fix the code to work correctly, not just get rid of compiler warnings? I.e., in +nBytes = write( nSocket, rCommand.getSt

Re: [Libreoffice] [PATCH]: fixes compiler warnings for vcl/workben/svpclient.cxx

2011-05-23 Thread Thorsten Behrens
Tor Lillqvist wrote: > Normally, for code that goes into LO. I don't think we want to > introduce perror() calls; they are fairly pointless there. Normal > users will never see the output. > > But yeah, this is for code in a "workben" directory, aren't those > just random old test and whatnot stuf

Re: [Libreoffice] [PATCH]: fixes compiler warnings for vcl/workben/svpclient.cxx

2011-05-23 Thread Tor Lillqvist
Normally, for code that goes into LO. I don't think we want to introduce perror() calls; they are fairly pointless there. Normal users will never see the output. But yeah, this is for code in a "workben" directory, aren't those just random old test and whatnot stuff that aren't even built? What

[Libreoffice] [PATCH]: fixes compiler warnings for vcl/workben/svpclient.cxx

2011-05-21 Thread Kenneth Venken
Hi, this patch fixes two "unchecked return value"-warnings in svpclient // Kenneth diff --git a/vcl/workben/svpclient.cxx b/vcl/workben/svpclient.cxx index e7e32d7..af56dc3 100644 --- a/vcl/workben/svpclient.cxx +++ b/vcl/workben/svpclient.cxx @@ -248,10 +248,15 @@ rtl::OString MyWin::processComm