[GSoC] Cleanup internal drawing units in Calc

2015-07-06 Thread Krisztian Pinter
Hi all! Work has been difficult on this project, I got a bit stuck. ScOutputData::DrawRotatedBorder() turned out to be trickier than I thought; when I try changing the points of the polygon to be drawn, it has no effect on what is actually being drawn, and a Processor is used for drawing which als

Re: [GSoC] Cleanup internal drawing units in Calc

2015-06-22 Thread Krisztian Pinter
Hi! Thanks for taking a look, you are right! I think my mistake was that I forgot to negate the bools, which lead me to believe that bSkipX/Y were always true. All the best, Krisztian On 22 June 2015 at 13:04, Eike Rathke wrote: > Hi Krisztian, > > On Sunday, 2015-06-21 22:11:44 +0200, Kriszti

Re: [GSoC] Cleanup internal drawing units in Calc

2015-06-22 Thread Eike Rathke
Hi Krisztian, On Sunday, 2015-06-21 22:11:44 +0200, Krisztian Pinter wrote: > I also think I found some dead code, if someone could shed some light on > the history of it, I would appreciate it. This is my patch which removes > it: https://gerrit.libreoffice.org/#/c/16351/ > ScOutputData::DrawExt

[GSoC] Cleanup internal drawing units in Calc

2015-06-21 Thread Krisztian Pinter
Hi all! I am still working my way down ScGridWindow::DrawContent, converting functions to use HMMs as I go. I also think I found some dead code, if someone could shed some light on the history of it, I would appreciate it. This is my patch which removes it: https://gerrit.libreoffice.org/#/c/1635

[GSoC] Cleanup internal drawing units in Calc

2015-06-01 Thread Krisztian Pinter
Hi all! Last week I started work on ScOutputData, I changed DrawDocumentBackground and DrawGrid to draw in logic units. https://gerrit.libreoffice.org/#/c/15984/ https://gerrit.libreoffice.org/#/c/16008/ I still use PixelToLogic conversions, but I think in the first stage of the work I will rewr