Re: [GSOC] Using cached formula results during ODS import

Hi, On Wednesday, 2012-07-04 19:44:53 +0200, Eike Rathke wrote: > > > 1) ScMyTables::SetMatrix() uses a call chain down to > > > ScFormulaCell::SetMatColsRows() which sets the ScFormulaCell dirty. > > > > This one might be legitimate. We need to check if we can also import > > the cached values

Re: [GSOC] Using cached formula results during ODS import

Hi, On Wednesday, 2012-07-04 18:07:31 +0200, Markus Mohrhard wrote: > > 1) ScMyTables::SetMatrix() uses a call chain down to > > ScFormulaCell::SetMatColsRows() which sets the ScFormulaCell dirty. > > This one might be legitimate. We need to check if we can also import > the cached values of mat

Fwd: Re: [GSOC] Using cached formula results during ODS import

Sorry, I meant to also CC Kohei and mailing list. I having trouble trying to think of a way to prevent ScFormulaCells from being set dirty without my hackish ScDocument libreoffice-generated-doc flag. During the import of the functions.ods unit test file, ScFormulaCells are set dirty at th

Re: [GSOC] Using cached formula results during ODS import

Hello Daniel, > I having trouble trying to think of a way to prevent ScFormulaCells from > being set dirty without my hackish ScDocument libreoffice-generated-doc > flag. > > During the import of the functions.ods unit test file, ScFormulaCells are > set dirty at three different times in three dif

Re: [GSOC] Using cached formula results during ODS import

Hi, Markus and Kohei, I having trouble trying to think of a way to prevent ScFormulaCells from being set dirty without my hackish ScDocument libreoffice-generated-doc flag. During the import of the functions.ods unit test file, ScFormulaCells are set dirty at three different times in three d

Re: [GSOC] Using cached formula results during ODS import

On 07/03/2012 04:46 PM, Daniel Bankston wrote: If an ScFormulaCell is set to dirty, it will be re-Interpreted (recalculated). The goal is to avoid this during ODS import of a LibreOffice generated document and instead use cached formula results imported from the document itself to achieve bet

[GSOC] Using cached formula results during ODS import

Hi, Kohei and Markus, I have commited my initial implementation of using imported formula results during ODS import if the document was generated by LibreOffice. It's not as clean and symmetric as I would have liked, but it's the best I have right now. I hope it's not too hackish, ;-) and I aw