Re: [GSOC] ODS Styles Import Performance Work Update

2012-08-17 Thread Daniel Bankston
On 08/17/2012 07:20 PM, Kohei Yoshida wrote: Interesting thing is, we used to have similar performance problem with styles import with Excel files. And I did take a very similar approach to what you just tried. The difference is that, I set the styles directly to ScDocument using the same data

Re: [GSOC] ODS Styles Import Performance Work Update

2012-08-17 Thread Kohei Yoshida
Hi Daniel, On Fri, Aug 17, 2012 at 5:50 PM, Daniel Bankston wrote: > Hi, Kohei, > > From what I understand, ScXMLImport::SetStyleToRanges was being called for > each row. For each of it's calls, the result was multiple calls to where > the time was being spent in ScMarkArray::SetMarkArea and > S

Re: [GSOC] ODS Styles Import Performance Work Update

2012-08-17 Thread Daniel Bankston
Hi, Kohei, From what I understand, ScXMLImport::SetStyleToRanges was being called for each row. For each of it's calls, the result was multiple calls to where the time was being spent in ScMarkArray::SetMarkArea and ScMarkArray::Search. This is from the call chain of ScXMLImport::SetStyleTo

Re: [GSOC] ODS Styles Import Performance Work Update

2012-08-15 Thread Daniel Bankston
On 08/15/2012 10:45 PM, Daniel Bankston wrote: On 08/15/2012 09:36 PM, Daniel Bankston wrote: These multiple calls to ScCellRangesBase::GetMarkData are happening because the data that ScCellRangesBase::GetMarkData gets is being reset every time a style range is added. I'm trying to see if we

Re: [GSOC] ODS Styles Import Performance Work Update

2012-08-15 Thread Daniel Bankston
On 08/15/2012 09:36 PM, Daniel Bankston wrote: These multiple calls to ScCellRangesBase::GetMarkData are happening because the data that ScCellRangesBase::GetMarkData gets is being reset every time a style range is added. I'm trying to see if we can stop resetting this data and just append i

[GSOC] ODS Styles Import Performance Work Update

2012-08-15 Thread Daniel Bankston
Hi, Kohei, Just an update on improving import performance of setting style ranges in george-ou-perf.ods... I've been slowly stepping through code, looking at callgrind outputs, and looking at the document xml to try to understand how this area of code and xml work. (Actually, I'm using a ve