Re: [GSOC] ODS Row height import

2012-06-26 Thread Noel Power
On 26/06/12 10:35, Eike Rathke wrote: >I'm not sure if we need to recalculate the row height in case of >style:use-optimal-row-height > but that is something we can figure out later. Except for this case I >currently see no reason why we would need to calculate row height but >Kohei or Eike may

Re: [GSOC] ODS Row height import

2012-06-26 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Em 26-06-2012 06:35, Eike Rathke escreveu: > Hi, > > On Tuesday, 2012-06-26 03:46:47 +0200, Markus Mohrhard wrote: > >>> ScXMLImport::endDocument() did use ScMyTables::UpdateRowHeights() which used >>> ScTable::SetOptimalHeightOnly() to set the r

Re: [GSOC] ODS Row height import

2012-06-26 Thread Eike Rathke
Hi, On Tuesday, 2012-06-26 03:46:47 +0200, Markus Mohrhard wrote: > > ScXMLImport::endDocument() did use ScMyTables::UpdateRowHeights() which used > > ScTable::SetOptimalHeightOnly() to set the row heights for the visible sheet > > and any sheets with tabs.  I removed the call to this method, and

Re: [GSOC] ODS Row height import

2012-06-25 Thread Markus Mohrhard
Hello Daniel, 2012/6/25 Daniel Bankston : > Hi, Markus, > > I was right about some things, and I was wrong about some other things. > > XMLTableStylesContext::EndElement() did use ScXMLImport::InsertStyles() > which used ScTable::SetOptimalHeight() (or something similar) to set the row > heights.

Re: [GSOC] ODS Row height import

2012-06-24 Thread Daniel Bankston
Hi, Markus, I was right about some things, and I was wrong about some other things. XMLTableStylesContext::EndElement() did use ScXMLImport::InsertStyles() which used ScTable::SetOptimalHeight() (or something similar) to set the row heights. I used ScDocument::EnableAdjustHeight(false) to pre

[GSOC] ODS Row height import

2012-06-23 Thread Daniel Bankston
Hi, Markus, A little update on ODS row height import... During import, ScXMLImport::endDocument() uses ScMyTables::UpdateRowHeights() to set the row heights for the visible tab and any tabs with shapes. I initially thought this was the only place row heights were calculated during import so