[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #31 from Thomas Arnhold --- Thanks, Carl. Great work! :) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesk

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 Jens Carl changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #29 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8e115c60081b245541408889295bc0c147091e0c fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #27 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c3245fc69de59cb1de219203c489d891073ced9 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #28 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dcb32a33a32665a6fa54df224fcfb2efad411567 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #26 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=158672fda5e9d82906972d9168025d42f3b38ac3 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #25 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e15732bc96c903b2e85bcc30c32fad2cceda5610 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #24 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=57217e1e9f995ec413e5eecaf171481373a0a8d0 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #23 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f0160a10dd2a5746c531040ffbf638e356f6d5d fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #22 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f3e1f476e9cffb75d0620ab2dcfdc1ea077cd9d3 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #21 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7610a80ad1a47f2401b4d6aca9d4f77e5be7c630 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #20 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9e3cc6b47444f988a68ca3ddcad779ed0480b00c fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #18 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3ddb928061531a8742565bfa91c0aaa76ef88863 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #19 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bcd5da6cb3d24801be4b84b3339a4d77e255a917 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #17 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=54b85bf51e42f0e74dfaab40dc0a6923dd1f876b fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #16 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=626a4283672be163085b90d2240638eb0126c654 fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #15 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=49a0d8eedf6758c8bceaf7824945167d669b71ff fdo#68849: Add hea

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 Jens Carl changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |j.car...@gmx.de |desktop.o

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 Commit Notification changed: What|Removed |Added Whiteboard|BSA EasyHack|BSA EasyHack |Di

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 Commit Notification changed: What|Removed |Added Whiteboard|BSA EasyHack|BSA EasyHack |Di

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #12 from Miklos Vajna --- Just go ahead and push your change for review; even if you don't add anyone to CC, we try to review trivial patches within a few days. -- You are receiving this mail because: You are on the CC list for the

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #11 from Jason Gerlowski --- I'm interested in working on this EasyHack as a little intro project. I actually have some changes mocked up that I'd like to push for review. Is anyone interested/willing to be a reviewer on Gerrit? (I

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 Thomas Arnhold changed: What|Removed |Added See Also||https://bugs.freedesktop.or

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 Thomas Arnhold changed: What|Removed |Added Attachment #85069|0 |1 is obsolete|

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #10 from Thomas Arnhold --- fixincludeguards.sh (commit b009e8fd4fce06d9abae8aaac8750ece7df212e4) spits out a warning "guard not detectable" if no include guard is found in a header file (or some other stuff like #pragma once is found

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #9 from Commit Notification --- Thomas Arnhold committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d6b80337fb76e31b2e6a11c18c3ae989767c8118 fdo#68849 add

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #8 from Stephan Bergmann --- (In reply to comment #7) > I'll use the following scheme for all new or changed header guards: > > All uppercase: INCLUDED_%modulename_%filename_%extension > > Examples: > > basic/source/runtime/rtlprot

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #7 from Thomas Arnhold --- I'll use the following scheme for all new or changed header guards: All uppercase: INCLUDED_%modulename_%filename_%extension Examples: basic/source/runtime/rtlproto.hxx -> INCLUDED_BASIC_RTLPROTO_HXX embe

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 --- Comment #6 from Thomas Arnhold --- Thanks Stephan, I'll take care of it. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 Stephan Bergmann changed: What|Removed |Added CC||sberg...@redhat.com --- Comment #5 fr

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 Commit Notification changed: What|Removed |Added Whiteboard|BSA EasyHack|BSA EasyHack |Di

[Bug 68849] Other: Add header guards to all include files

https://bugs.freedesktop.org/show_bug.cgi?id=68849 Björn Michaelsen changed: What|Removed |Added CC||libreoffice@lists.freedeskt