Hi,
On Wed, Jul 18, 2012 at 07:11:53PM +0200, Jan Holesovsky wrote:
> Luckily, the Qt guys apparently had the same problem, and
> have a solution (the entire diff on one page, without abandoning the
> inline commenting):
>
> http://qt.gitorious.org/qtqa/gerrit/commit/737400d1bad4fa8bfd39cb326636a
On Wed, Jul 18, 2012 at 10:10:38PM +0200, David Ostrovsky wrote:
> https://gerrit.libreoffice.org/#/c/328/
The "gitweb" link on that page says "404 no such project".
--
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists
Hi Kendy,
On 18.07.2012 19:11, Jan Holesovsky wrote:
Another thing are the mail templates - can you please commit the current
mail templates that we are using on gerrit.libreoffice.org to
dev-tools/gerrit/gerrit_site/etc/mail, so that we can tweak them [eg. to
get rid of the . line], in a ve
Hi Bjoern,
On 2012-07-02 at 18:44 +0200, Bjoern Michaelsen wrote:
> > When I click "Diff All Side-by-Side" (or "Diff All Unified"), it shows
> > me only the first file with a link to the (diff) of the next file. I
> > expected to see the diff for *all* files on one page. That is much
> > more con
On 09.07.2012 08:53, Norbert Thiebaud wrote:
QT have patched their gerrit to do the 'right thing'
we too and we are even better: we pushed it upstream ;-)
https://gerrit-review.googlesource.com/#/c/36640/
Regards
David
___
LibreOffice mailing list
L
\> Now I went to https://gerrit.libreoffice.org/#/c/267/; there are at
> this time three patchsets, but it seems there is no easy / convenient
> way to see the differences (interdiff) between them.
QT have patched their gerrit to do the 'right thing'
See https://codereview.qt-project.org/#patch,al
On Mon, Jul 02, 2012 at 06:13:50PM +0200, Lionel Elie Mamane wrote:
> On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote:
>> gerrit is documented and ready to go. Please use it for code review
>> as much as possible now as it simplifies things a lot over manual
>> patch fiddling on
On 02.07.2012 18:44, Bjoern Michaelsen wrote:
On Mon, Jul 02, 2012 at 06:13:50PM +0200, Lionel Elie Mamane wrote:
When I click "Diff All Side-by-Side" (or "Diff All Unified"), it shows
>me only the first file with a link to the (diff) of the next file. I
>expected to see the diff for*all* files
On Mon, Jul 02, 2012 at 06:13:50PM +0200, Lionel Elie Mamane wrote:
> Then I click on "sw/source/core/bastyp/SwSmartTagMgr.cxx" just to
> *see* what this patch is about. I go back to previous page, and now
> this line has a green mark in "Reviewed". This gives the idea that
> I somehow approve of t
On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote:
> gerrit is documented and ready to go. Please use it for code review
> as much as possible now as it simplifies things a lot over manual
> patch fiddling on mailing lists.
So, I went to https://gerrit.libreoffice.org/#/c/255/
Th
On Thu, Jun 21, 2012 at 07:08:46PM +0200, Pierre-André Jacquod wrote:
> Just to say, I basically just really do not like the fact of having
> to use openId, would prefer to have an account at fd.o. I did it
> really for the LibO, a kind of forced to. And NO, I do NOT have any
> google, flickr, fac
On Fri, Jun 22, 2012 at 01:13:50PM +0200, Lionel Elie Mamane wrote:
> No. When I have some free / floating time, I hunt for low-hanging
> fruit in the review queue (patches I can review without understanding
> the area), so that the "big" reviewers can focus on the more
> complicated reviews. So r
On Thu, Jun 21, 2012 at 10:06:28AM +0200, Bjoern Michaelsen wrote:
> On Thu, Jun 21, 2012 at 07:53:42AM +0200, Lionel Elie Mamane wrote:
>> As I review very few patches, keeping me happy in this respect is
>> probably not high priority, except maybe as a long tail argument (if
>> we have 100 commi
On 19/06/12 14:44, Jan Holesovsky wrote:
> Hi Norbert,
>
> On 2012-06-19 at 07:23 -0500, Norbert Thiebaud wrote:
>
>>> Thanks Robert for doing that! Please - is there any chance to use cgit
>>> instead, so that it is compatible / familiar with the freedesktop
>>> browsing?
>>
>> in theory it is.
On Thu, Jun 21, 2012 at 12:08 PM, Pierre-André Jacquod
wrote:
> I push to gerrit and let tinderbox run. In case of success I get ? a +1 of
> each tinderbox ?
Right now we don;t have tinderbox doing that yet... but when we do,
you'll need to asd a Review +1 to get the auto-build happen
> How do I
Hi Pierre-André!
On Thu, Jun 21, 2012 at 07:08:46PM +0200, Pierre-André Jacquod wrote:
> I push to gerrit and let tinderbox run. In case of success I get ? a
> +1 of each tinderbox ? How do I know it passes with success.
a tinderbox would give you a +1verified, which means that it builds (and pas
Hello,
well as free time contributor with commit access to current repository,
I followed this gerrit story. So not kind of surprise, but yeah, until
THIS mail and posts, was me very unclear what it would mean.
To say it, first I had a lot of doubt. Reading mails, entry in the wiki,
looking t
On Wed, 2012-06-20 at 22:46 +0200, Bjoern Michaelsen wrote:
> Hi,
>
> On Wed, Jun 20, 2012 at 09:47:48PM +0200, Lionel Elie Mamane wrote:
>
> > My point is basically that it is too much of an investment for a
> > casual contributor... If we could make that easier by allowing plain
> > username+pa
On Thu, Jun 21, 2012 at 08:07:45AM -0400, Terrence Enger wrote:
> On Wed, 2012-06-20 at 22:46 +0200, Bjoern Michaelsen wrote:
>> On Wed, Jun 20, 2012 at 09:47:48PM +0200, Lionel Elie Mamane wrote:
>>> My point is basically that it is too much of an investment for a
>>> casual contributor... If we
On Thu, Jun 21, 2012 at 10:13:38AM +0100, Michael Meeks wrote:
> On Wed, 2012-06-20 at 22:46 +0200, Bjoern Michaelsen wrote:
>> we vaguely considered running a TDF OpenID provider in the distant future,
>> but so shied away from that for the nontrivial cost (security is hard to
>> get right)
>
Hi Kendy,
On Thu, Jun 21, 2012 at 11:25:18AM +0200, Jan Holesovsky wrote:
> I believe this way we might keep both camps ("everything into ML" like
> me, and "only discussions on the ML" like Bjoern) happy - because the
> people who want to have only discussions on the ML would be able to
> filter
Hi,
On 2012-06-21 at 10:55 +0200, d.ostrov...@idaia.de wrote:
> > Something like:
> > - a short dialy digest of changes to keep reviewers in the loop
> > - _one_ mail once a change goes in with all the comments/revisions and
> > back-and-forth for this change in context in it
> >
> > or somethi
On Wed, 2012-06-20 at 22:46 +0200, Bjoern Michaelsen wrote:
> we vaguely considered running a TDF OpenID provider in the distant future,
> but so shied away from that for the nontrivial cost (security is hard to
> get right)
I imagine if Lionel wanted to re-open that decision, and has don
Zitat von Bjoern Michaelsen :
Something like:
- a short dialy digest of changes to keep reviewers in the loop
- _one_ mail once a change goes in with all the comments/revisions and
back-and-forth for this change in context in it
or something completely different? We might get rid of the firs
Hi Winfried!
On Thu, Jun 21, 2012 at 08:26:09AM +0200, Winfried Donkers wrote:
> Not wanting to interfere, just to provide some feedback:
> being a volunteer and being on the brink of newcomer and not-quite newcomer,
> the mailing list gives me a lot of information. Comments on submitted patches
>
On Thu, Jun 21, 2012 at 09:46:54AM +0200, Bjoern Michaelsen wrote:
> On Thu, Jun 21, 2012 at 07:09:15AM +0200, Lionel Elie Mamane wrote:
>> But frankly, why should Google, AOL, Wordpress or another person be
>> able to impersonate me at the TDF systems?
> If you created an account at one of those
Hi,
On Thu, Jun 21, 2012 at 07:31:15AM +0200, Lionel Elie Mamane wrote:
> I understand gerrit is not able to "understand" such policies and we
> will continue to enforce them "manually" by giving only codereview+1
> unless there are already two other codereview+1.
But a bot using:
http://gerrit
On Thu, Jun 21, 2012 at 07:53:42AM +0200, Lionel Elie Mamane wrote:
> What I fear the most in that is that I have no way to mark a patch as
> "I won't review it, not my area / I don't know / don't understand /
> ...". With publish-to-ML, I just mark the post / whole thread as
> "read". With gerrit,
On Thu, Jun 21, 2012 at 07:09:15AM +0200, Lionel Elie Mamane wrote:
> But frankly, why should Google, AOL, Wordpress or another person be
> able to impersonate me at the TDF systems?
If you created an account at one of those, you are trusting them. The trust
issue is with account creation, not wit
On Thu, Jun 21, 2012 at 02:10:05AM -0500, Norbert Thiebaud wrote:
> On Thu, Jun 21, 2012 at 12:53 AM, Lionel Elie Mamane wrote:
>> What I fear the most in that is that I have no way to mark a patch as
>> "I won't review it, not my area / I don't know / don't understand /
>> ...".
> No but...
> 1
On Thu, Jun 21, 2012 at 12:53 AM, Lionel Elie Mamane wrote:
>
> What I fear the most in that is that I have no way to mark a patch as
> "I won't review it, not my area / I don't know / don't understand /
> ...".
No but...
1/ you can 'star' patch
2/ patch are presented in reverse chronological ord
On 06/21/2012 08:08 AM, Norbert Thiebaud wrote:
On Wed, Jun 20, 2012 at 11:57 PM, David Ostrovsky
wrote:
[...]
As I explained on IRC: someone that _is_ a Committer can do some
modification and still push the patch with you as author and him as
commiter (git allow that, if we used svn like som
On 06/20/2012 10:27 PM, David Ostrovsky wrote:
On 20.06.2012 14:11, Stephan Bergmann wrote:
On 06/19/2012 09:32 PM, David Ostrovsky wrote:
I got one question with gerrit so far:
how can other people contribute code snippet into foreign gerrit patch
(so called extend it)?
During my work on gbuil
> > Still, this removes the comments from many people's (potential) sight.
> > The IMO big advantage of the "everything on a single mailing list"
> > approach is that everybody is forced ;) to see everything (modulo
> > information overload)
>
> So, IMHO that advantage not only has its drawbacks (
On Wed, Jun 20, 2012 at 11:57 PM, David Ostrovsky
wrote:
> While claiming other people's work to be your own may be not a problem in
> other contries,
> here in gemany it is: in fact minister of defence and other politicians
> stepped down for doing exactly that (copy/paste parts of their disserta
On Wed, Jun 20, 2012 at 02:34:13PM +0200, Bjoern Michaelsen wrote:
> On Wed, Jun 20, 2012 at 02:11:31PM +0200, Stephan Bergmann wrote:
>> Still, this removes the comments from many people's (potential)
>> sight. The IMO big advantage of the "everything on a single mailing
>> list" approach is that
On Wed, Jun 20, 2012 at 01:43:26PM +0200, Bjoern Michaelsen wrote:
> On Wed, Jun 20, 2012 at 12:26:23PM +0200, Lionel Elie Mamane wrote:
>> When the gerrit repos are the "true one source" and gerrit will do
>> the "push" automatically once someone validates the patch in the
>> web interface, what
On Wed, Jun 20, 2012 at 10:46:24PM +0200, Bjoern Michaelsen wrote:
> On Wed, Jun 20, 2012 at 09:47:48PM +0200, Lionel Elie Mamane wrote:
>> However, our current setup *requires* an OpenID; is it an option to
>> make that optional (and allow people to e.g. use a "classic"
>> username+password for
On 20.06.2012 22:47, Norbert Thiebaud wrote:
On Wed, Jun 20, 2012 at 3:27 PM, David Ostrovsky wrote:
AFAIKs it can not be solved with gerrit: only i can change my gerrit
patch/change.
really ?
I just did exactly that onhttps://gerrit.libreoffice.org/#/c/229/
Wow! no bad, not bad, but now this
foreword: please trim the quotation when you reply...
On Wed, Jun 20, 2012 at 3:27 PM, David Ostrovsky wrote:
>
> May be I'm missing something obvious here, but how would it change the
> things if you would use command line instead of web UI?
Choice is a great thing.
> AFAIKs it can not be sol
Hi,
On Wed, Jun 20, 2012 at 09:47:48PM +0200, Lionel Elie Mamane wrote:
> However, our current setup *requires* an OpenID; is it an option to
> make that optional (and allow people to e.g. use a "classic"
> username+password for the web interface)?
no.
> People like that (yes, I'm one of them) w
On 20.06.2012 14:11, Stephan Bergmann wrote:
On 06/19/2012 09:32 PM, David Ostrovsky wrote:
On 19.06.2012 19:24, Petr Mladek wrote:
Sounds good but how many people would know about the comments? How hard
would be to find them?
https://gerrit.libreoffice.org/#/c/179/4/
(may be you need to login
On Tue, Jun 19, 2012 at 04:46:26PM +0100, Michael Meeks wrote:
> On Tue, 2012-06-19 at 17:04 +0200, Lubos Lunak wrote:
> My hope is that by encouraging the use of gerrit in parallel with the
> mailing list, the benefits will become sufficiently obvious over time
> that the old way of mergin
On Wed, Jun 20, 2012 at 03:52:11PM +0200, Lubos Lunak wrote:
> Besides, is every committer required to study ESC minutes?
Good question. IMHO not in general. But this is one of the rare occations,
where I think making a difference between volunteers and full-time paid
developers is sensible. I pe
On Wed, Jun 20, 2012 at 8:52 AM, Lubos Lunak wrote:
>
> Besides, is every committer required to study ESC minutes?
That is the _one_ message a week that, yes, every committer should
read, or loose the right to complain about not being informed.
Norbert
_
On Wednesday 20 of June 2012, Bjoern Michaelsen wrote:
> On Wed, Jun 20, 2012 at 02:55:53PM +0200, Lubos Lunak wrote:
> > If you don't want people to miss important information, you need to
> > announce it properly and not as some offhand remark.
>
> A mail with "ACTION REQUIRED" in the subject is
On Wed, Jun 20, 2012 at 5:26 AM, Lionel Elie Mamane wrote:
> Ah, I understand. When the gerrit repos are the "true one source" and
> gerrit will do the "push" automatically once someone validates the
> patch in the web interface, what will "Committer" be? The one that
> uploaded the patch or the
On Wed, Jun 20, 2012 at 02:55:53PM +0200, Lubos Lunak wrote:
> If you don't want people to miss important information, you need to announce
> it properly and not as some offhand remark.
A mail with "ACTION REQUIRED" in the subject is not an offhand remark.
Having called it out with vigor in the
On Tuesday 19 of June 2012, Bjoern Michaelsen wrote:
> On Tue, Jun 19, 2012 at 05:04:58PM +0200, Lubos Lunak wrote:
> > Which is the problem. Besides asking just to do that it should have also
> > said why one should do that. I'm one of the people who haven't done that,
> > because 'Do it because.
On Wed, Jun 20, 2012 at 02:11:31PM +0200, Stephan Bergmann wrote:
> Still, this removes the comments from many people's (potential)
> sight. The IMO big advantage of the "everything on a single mailing
> list" approach is that everybody is forced ;) to see everything
> (modulo information overload)
On 06/19/2012 09:32 PM, David Ostrovsky wrote:
On 19.06.2012 19:24, Petr Mladek wrote:
Sounds good but how many people would know about the comments? How hard
would be to find them?
https://gerrit.libreoffice.org/#/c/179/4/
(may be you need to login into gerrit with your openId)
You can see it
On Wed, Jun 20, 2012 at 12:26:23PM +0200, Lionel Elie Mamane wrote:
> Ah, I understand. When the gerrit repos are the "true one source" and
> gerrit will do the "push" automatically once someone validates the
> patch in the web interface, what will "Committer" be? The one that
> uploaded the patch
On Wed, Jun 20, 2012 at 04:31:21AM -0500, Norbert Thiebaud wrote:
> On Wed, Jun 20, 2012 at 4:21 AM, Lionel Elie Mamane wrote:
>> On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote:
>>> gerrit is documented and ready to go.
>> It refuses to take patches (commits) whose author fiel
On Wed, Jun 20, 2012 at 4:21 AM, Lionel Elie Mamane wrote:
> On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote:
>
>> http://sweetshark.livejournal.com/13298.html
>
>> gerrit is documented and ready to go.
>
> It refuses to take patches (commits) whose author field is not an
> emai
On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote:
> http://sweetshark.livejournal.com/13298.html
> gerrit is documented and ready to go.
It refuses to take patches (commits) whose author field is not an
email address registered in my account.
How do I submit for review a patch
Quoting Norbert Thiebaud :
On Tue, Jun 19, 2012 at 7:05 AM, Jan Holesovsky wrote:
Thanks Robert for doing that! Please - is there any chance to use cgit
instead, so that it is compatible / familiar with the freedesktop
browsing?
in theory it is... but gitweb was working out of the box
Hi Kendy,
The configuration is trivial, you just edit /etc/cgitrc to point to the
repos, and you are done; but of course I have no idea how well does it
play with gerrit.
My "Problem" was the Integration of cgit in gerrit. If it helps, i can
install cgit as Standalone App beyond the gerrit-
Hi Tor,
On Tue, Jun 19, 2012 at 10:14:27PM +0300, Tor Lillqvist wrote:
> But if the intent is that *all* changes are to go through gerrit,
Its not. As said repeatedly on this thread already, everyone who has an fd.o
account will be able to continue to push to master. However, the hope is that
the
Hi Petr, all,
i am using gerrit for a while now and gathered some experience with it
already and would like
to share it with you.
On 19.06.2012 19:24, Petr Mladek wrote:
Bjoern Michaelsen píše v Út 19. 06. 2012 v 18:40 +0200:
Hi Petr,
On Tue, Jun 19, 2012 at 06:14:18PM +0200, Petr Mladek wr
I find it peculiar that in the discussion here people keep talking
about patches, as if gerrit was only a "patch" review tool. At least I
understand "patch" to mean a relatively local change to the code in
order to fix some specific bug. But if the intent is that *all*
changes are to go through ger
Hi,
On Tue, Jun 19, 2012 at 07:24:30PM +0200, Petr Mladek wrote:
> Sure but who will be the reviewer? The mailing list has the advantage
> that people step in when they are interested. It helps to balance the
> workload. Also it is very open for new reviewers. I am afraid that
> gerrit could make
Bjoern Michaelsen píše v Út 19. 06. 2012 v 18:40 +0200:
> Hi Petr,
>
> On Tue, Jun 19, 2012 at 06:14:18PM +0200, Petr Mladek wrote:
> > Ah, this bug is about a daily digest. I think that we first need to
> > decide how much we want to modify the current work flow. Do we want to
> > really move mos
On Tue, Jun 19, 2012 at 8:09 AM, Jan Holesovsky wrote:
> Hi Bjoern,
>
> On 2012-06-19 at 12:50 +0200, Bjoern Michaelsen wrote:
>
>> (*) That is, if you did the initial setup there on time. You were all asked
>> to
>> get yourself an account on gerrit more than a month ago. Dont blame the
>> admi
Hi Petr,
On Tue, Jun 19, 2012 at 06:14:18PM +0200, Petr Mladek wrote:
> Ah, this bug is about a daily digest. I think that we first need to
> decide how much we want to modify the current work flow. Do we want to
> really move most discussions from the mailing list to gerrit?
IMHO yes, they are n
Bjoern Michaelsen píše v Út 19. 06. 2012 v 13:38 +0200:
> On Tue, Jun 19, 2012 at 11:13:45AM +0200, Petr Mladek wrote:
> > It means that gerrit should be able to detect patches for review on the
> > mailing list, integrate them, and make them ready for review.
> >
> > My expectation would be that
something about this Gerrit stuff that wasn't just a
> random remark. I still have yet to see a good description of what Gerrit is
> actually supposed to do for us exactly.
http://nabble.documentfoundation.org/ANN-Please-use-Gerrit-from-now-on-for-Patch-Review-td3990754.html#a39910
On Tue, 2012-06-19 at 17:04 +0200, Lubos Lunak wrote:
> Which is the problem. Besides asking just to do that it should have also
> said
> why one should do that. I'm one of the people who haven't done that,
> because 'Do it because.' scores pretty low with my motivation.
My hope is th
On Tuesday 19 of June 2012, Bjoern Michaelsen wrote:
> On Tue, Jun 19, 2012 at 02:05:05PM +0200, Jan Holesovsky wrote:
> > > The second step however does not yet work as long as gerrit does not
> > > own the repository. Thats why it is so damn important, that everyone
> > > gets his gerrit account
On Tue, Jun 19, 2012 at 02:05:05PM +0200, Jan Holesovsky wrote:
> > The second step however does not yet work as long as gerrit does not own the
> > repository. Thats why it is so damn important, that everyone gets his gerrit
> > account set up as requested a month ago, so that we can switch over
On Tue, Jun 19, 2012 at 03:09:34PM +0200, Jan Holesovsky wrote:
> The wiki page says you have to create a ssh key; I hope it is not
> necessary, and one can reuse his fd.o key? If yes - can we automate
> that in any way, to save the admins work?
Thats a bit tricky - we can try to get the fd.o guy
Hi Bjoern,
On 2012-06-19 at 12:50 +0200, Bjoern Michaelsen wrote:
> (*) That is, if you did the initial setup there on time. You were all asked to
> get yourself an account on gerrit more than a month ago. Dont blame the admins
> if you stumble in with 400 others in the last minute.
The wiki pag
Hi Norbert,
On 2012-06-19 at 07:23 -0500, Norbert Thiebaud wrote:
> > Thanks Robert for doing that! Please - is there any chance to use cgit
> > instead, so that it is compatible / familiar with the freedesktop
> > browsing?
>
> in theory it is... but gitweb was working out of the box
> Is
On Tue, Jun 19, 2012 at 7:05 AM, Jan Holesovsky wrote:
> Thanks Robert for doing that! Please - is there any chance to use cgit
> instead, so that it is compatible / familiar with the freedesktop
> browsing?
in theory it is... but gitweb was working out of the box
Is there any significant di
Hi Bjoern,
On 2012-06-19 at 13:03 +0200, Bjoern Michaelsen wrote:
> > If you answer was that the new workflow would be:
> >
> > - click a link in a mail from gerrit
> > - that will open the syntax-highlighted cgit-like patch in the
> > browser, on a page with a big [Push it!] button + spac
On Tue, Jun 19, 2012 at 4:54 AM, Jan Holesovsky wrote:
> I would be happy. But is it going to be so? So far the best I've got
> from gerrit was clicking [Diff all unified], that opened one browser
> window per file (ugh!), with more clicking to actually do the review.
We added gitweb in gerrit
On Tue, Jun 19, 2012 at 11:13:45AM +0200, Petr Mladek wrote:
> It means that gerrit should be able to detect patches for review on the
> mailing list, integrate them, and make them ready for review.
>
> My expectation would be that it sends a replay to the mailing list with
> a link to diff, link
On Tue, Jun 19, 2012 at 11:54:25AM +0200, Jan Holesovsky wrote:
> If you answer was that the new workflow would be:
>
> - click a link in a mail from gerrit
> - that will open the syntax-highlighted cgit-like patch in the
> browser, on a page with a big [Push it!] button + space to write the
On Tue, Jun 19, 2012 at 08:57:28AM +0100, Caolán McNamara wrote:
> On Mon, 2012-06-18 at 12:09 +0200, Bjoern Michaelsen wrote:
> > gerrit is documented and ready to go.
>
> Can I get superquick overview of "why gerrit?". e.g. the problems we
> have that gerrit fixes. My biggest concern has always
On Tue, Jun 19, 2012 at 11:54:25AM +0200, Jan Holesovsky wrote:
> Maybe the command line interface will be easier to use, but
>
> https://wiki.documentfoundation.org/Development/gerrit/PatchReview
>
> did not convince me that it "simplifies things a lot over manual patch
> fiddling" - described i
Hi Bjoern,
On 2012-06-19 at 11:30 +0200, Bjoern Michaelsen wrote:
> > > http://sweetshark.livejournal.com/13298.html
> > >
> > > gerrit is documented and ready to go. Please use it for code review as
> > > much as
> > > possible now as it simplifies things a lot over manual patch fiddling on
>
On Tue, Jun 19, 2012 at 10:31:08AM +0200, Jan Holesovsky wrote:
> Hi Bjoern,
>
> On 2012-06-18 at 12:09 +0200, Bjoern Michaelsen wrote:
>
> > http://sweetshark.livejournal.com/13298.html
> >
> > gerrit is documented and ready to go. Please use it for code review as much
> > as
> > possible now
On Tue, Jun 19, 2012 at 08:57:28AM +0100, Caolán McNamara wrote:
> Can I get superquick overview of "why gerrit?". e.g. the problems we
> have that gerrit fixes.
Gerrit will prevent exactly what you describe below, that is people having to
harvest across the mailing list for patches and never bei
Bjoern Michaelsen píše v Po 18. 06. 2012 v 12:09 +0200:
> Hi all,
>
> with:
>
> http://sweetshark.livejournal.com/13298.html
>
> gerrit is documented and ready to go.
Ah, there are several strange and long commands.
Also I miss the cooperation with the mailing list. I remember that the
main re
Hi Bjoern,
On 2012-06-18 at 12:09 +0200, Bjoern Michaelsen wrote:
> http://sweetshark.livejournal.com/13298.html
>
> gerrit is documented and ready to go. Please use it for code review as much as
> possible now as it simplifies things a lot over manual patch fiddling on
> mailing lists.
Can yo
On Mon, 2012-06-18 at 12:09 +0200, Bjoern Michaelsen wrote:
> gerrit is documented and ready to go.
Can I get superquick overview of "why gerrit?". e.g. the problems we
have that gerrit fixes. My biggest concern has always been that patches
go into gerrit and disappear in an out of sight out of m
Hi all,
with:
http://sweetshark.livejournal.com/13298.html
gerrit is documented and ready to go. Please use it for code review as much as
possible now as it simplifies things a lot over manual patch fiddling on
mailing lists. I will update the EasyHacks to point to gerrit instead in the
next d
86 matches
Mail list logo
