Hye Maarten,
during the last days, I have take some time to look at some improvements to
bring to LibreOffice code base on CppCheck report that you've setted up.
I don't know the configuration you did, and have just questions/remarks.
Here are some point I've noted :
1. there is a 'missingConfi
chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx |2 +-
chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx |2 +-
connectivity/source/drivers/macab/MacabRecords.cxx |3 +--
desktop/source/lib/init.cxx
Great job guys. It's been a long run, and you did it.
Thank to anyone involved in stabilising this suite.
Michaël
2015-07-20 11:37 GMT+02:00 Caolán McNamara :
> On Mon, 2015-07-20 at 09:08 +, Crashtest VM wrote:
> > New crashtest update available at
> http://dev-builds.libreoffice.org/crash
dbaccess/source/ui/querydesign/JoinTableView.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 2e5af8d69f38463f4563efec3bfb177f031520a0
Author: Michaël Lefèvre
Date: Thu Mar 12 22:09:46 2015 +0100
CppCheck cleaning : avoid unnecessary affectation
filter/source/config/cache/typedetection.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit c83476ab28544c25ab72e7e51131ab481bcbcc5d
Author: Michaël Lefèvre
Date: Fri Mar 13 16:34:28 2015 +0100
CppCheck cleaning : unnecessary assignment
Change-Id: I1e2562631f37befc
sal/android/uthash.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
New commits:
commit b18bd0b774436ad2a85b95491a3efd02c249
Author: Michaël Lefèvre
Date: Fri Mar 13 15:46:44 2015 +0100
CppCheck cleaning : scope reduction and printf format
Change-I
oox/source/drawingml/table/tableproperties.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit c1689141dde7ed7b4a134c63023d4cf4dacb3b24
Author: Michaël Lefèvre
Date: Fri Mar 13 15:18:14 2015 +0100
CppCheck cleaning : unnecessary affectation
Change-Id: Ia86b49cb5f643
desktop/unx/source/args.c | 33 -
1 file changed, 16 insertions(+), 17 deletions(-)
New commits:
commit 81886532bf6cfce93f3d7fdd73150d9dd1abbcfb
Author: Michaël Lefèvre
Date: Fri Mar 13 16:15:01 2015 +0100
CppCheck cleaning : remove unused struct member
sal/osl/w32/profile.cxx |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
New commits:
commit 386a85ed50a3e4832644072950a30304ba6c58a6
Author: Michaël Lefèvre
Date: Thu Mar 12 22:27:09 2015 +0100
CppCheck cleaning : avoid static string comparison
Change-Id: I6a737
sw/source/uibase/app/swwait.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 0845cdbdaedd7f556c471399c3bbc76d5cafffd2
Author: Michaël Lefèvre
Date: Thu Mar 12 22:32:54 2015 +0100
CppCheck cleaning : redundant checking of elemet existence
Change
dbaccess/source/ui/querydesign/JoinTableView.cxx |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit e0d4227d313aa77f11b3ee773859649629a906bb
Author: Michaël Lefèvre
Date: Thu Mar 12 21:37:31 2015 +0100
CppCheck cleaning : Redundant checking for element exis
dbaccess/source/ui/misc/WNameMatch.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit aa580276e5415bdf7c5e6eba445f812acd1cbe32
Author: Michaël Lefèvre
Date: Thu Mar 12 21:27:17 2015 +0100
CppCheck cleaning : reduce scope
Change-Id: Iefb21089b
basic/source/comp/dim.cxx|
4 ---
chart2/source/controller/main/ChartController_EditData.cxx |
3 --
chart2/source/view/axes/VCartesianAxis.cxx |
12 --
connectivity/source/drivers/mozab/
sw/source/uibase/inc/view.hxx|1 +
sw/source/uibase/shells/annotsh.cxx |7 +--
sw/source/uibase/shells/drawsh.cxx |7 +--
sw/source/uibase/shells/drwtxtex.cxx |7 +--
sw/source/uibase/shells/frmsh.cxx|7 +--
sw/source/uibase/shells/textsh1.cxx |
sw/source/uibase/inc/view.hxx|1 +
sw/source/uibase/shells/annotsh.cxx |9 +
sw/source/uibase/shells/drawsh.cxx |9 +
sw/source/uibase/shells/drwtxtex.cxx |9 +
sw/source/uibase/shells/frmsh.cxx|9 +
sw/source/uibase/shells/textsh1
sw/source/uibase/inc/view.hxx|1 +
sw/source/uibase/shells/annotsh.cxx | 29 +
sw/source/uibase/shells/drawsh.cxx | 12 +---
sw/source/uibase/shells/drwtxtex.cxx | 12 +---
sw/source/uibase/shells/frmsh.cxx| 14 ++
include/sfx2/shell.hxx |1 +
sfx2/source/control/shell.cxx| 14 ++
sw/source/uibase/shells/annotsh.cxx | 11 +--
sw/source/uibase/shells/drawsh.cxx | 13 +
sw/source/uibase/shells/drwtxtex.cxx | 10 +-
sw/source/uibase/sh
include/vcl/textdata.hxx | 15 ---
vcl/source/edit/textdoc.cxx | 33 +++
vcl/source/edit/textdoc.hxx |6 +-
vcl/source/edit/texteng.cxx | 90 +--
vcl/source/edit/textundo.cxx |8 +--
vcl/source/edit/textview.cxx | 44 ++
Hye,
you could also have a look at a presentation given last year at Fosdem :
Here are the slides :
https://archive.fosdem.org/2014/schedule/event/writer_internals_how_are_the_pages_rendered/attachments/slides/434/export/events/attachments/writer_internals_how_are_the_pages_rendered/slides/434/k
sw/inc/docary.hxx | 12 +++-
sw/source/core/tox/tox.cxx |6 +++---
2 files changed, 14 insertions(+), 4 deletions(-)
New commits:
commit 7c181e5e0aa218ba0abff6c8ea42e107f59bf3f0
Author: Michaël Lefèvre
Date: Mon Dec 15 15:46:32 2014 +0100
fdo#75757 Remove inherita
sw/source/core/layout/paintfrm.cxx | 43 ++---
1 file changed, 22 insertions(+), 21 deletions(-)
New commits:
commit ababde703007557c59595d551efb118cf84a3911
Author: Michaël Lefèvre
Date: Mon Dec 1 23:20:11 2014 +0100
Use parameter instead of static glo
sw/source/core/layout/paintfrm.cxx | 60 +++--
1 file changed, 31 insertions(+), 29 deletions(-)
New commits:
commit 4edba25561758bf4302279bd24385cc2a66d4bcf
Author: Michaël Lefèvre
Date: Mon Dec 1 17:15:36 2014 +0100
Use parameter instead of static acc
sw/source/core/layout/paintfrm.cxx | 104 ++---
1 file changed, 52 insertions(+), 52 deletions(-)
New commits:
commit 5c72a036aa4bed91fcedab963828ea4ba6fe6198
Author: Michaël Lefèvre
Date: Mon Dec 1 10:02:20 2014 +0100
Use reference instead of pointer
sw/source/core/layout/paintfrm.cxx | 183 -
1 file changed, 99 insertions(+), 84 deletions(-)
New commits:
commit cccf054a4353d1efdb8318e8dbed73de6d9c3d70
Author: Michaël Lefèvre
Date: Mon Nov 24 11:07:32 2014 +0100
Use parameters instead of static a
include/vcl/textdata.hxx | 15 ---
vcl/source/edit/textdoc.cxx | 80 -
vcl/source/edit/textdoc.hxx | 16 +--
vcl/source/edit/texteng.cxx | 92 +--
vcl/source/edit/textundo.cxx |8 +--
vcl/source/
sw/source/core/layout/paintfrm.cxx | 138 +
1 file changed, 67 insertions(+), 71 deletions(-)
New commits:
commit 0bb0522b21cd0f43c295606d63059730c04dab14
Author: Michaël Lefèvre
Date: Sun Nov 16 15:48:11 2014 +0100
Move remaining static vars into th
sw/source/core/layout/paintfrm.cxx | 38 ++---
1 file changed, 19 insertions(+), 19 deletions(-)
New commits:
commit 3fc4449bfbfc52dce5d107479520848b1c9dad79
Author: Michaël Lefèvre
Date: Sun Nov 16 15:37:07 2014 +0100
Move static pSpecsSubLines into pr
sw/source/core/layout/paintfrm.cxx | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
New commits:
commit 6a4b21f373739f6aac9a7c4cf70838c265094414
Author: Michaël Lefèvre
Date: Sun Nov 16 15:34:13 2014 +0100
Move static pProgress into properties conta
sw/source/core/layout/paintfrm.cxx | 122 ++---
1 file changed, 60 insertions(+), 62 deletions(-)
New commits:
commit fa0f753ec87d279c82680ef661fc47a81e315721
Author: Michaël Lefèvre
Date: Sun Nov 16 15:23:03 2014 +0100
Move static n*Pixel* into properti
sw/source/core/layout/paintfrm.cxx | 55 ++---
1 file changed, 27 insertions(+), 28 deletions(-)
New commits:
commit 69881c0fabe1c37d3564735d13210d1b14e8b153
Author: Michaël Lefèvre
Date: Sun Nov 16 15:10:59 2014 +0100
Move *RetoucheFly* into properties
sw/source/core/layout/paintfrm.cxx | 50 +
1 file changed, 24 insertions(+), 26 deletions(-)
New commits:
commit 86662e137726ce7f13da9d116b9ce97e374322fd
Author: Michaël Lefèvre
Date: Sun Nov 16 14:40:09 2014 +0100
Move bFlyMetafile and pFlyMetafile
sw/source/core/layout/paintfrm.cxx | 234 ++---
1 file changed, 116 insertions(+), 118 deletions(-)
New commits:
commit 7b2985edba87c8b4c081611beeef0d597a826032
Author: Michaël Lefèvre
Date: Sun Nov 16 14:26:15 2014 +0100
Move pGlobalShell into propertie
sw/source/core/layout/paintfrm.cxx | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
New commits:
commit 250391009aec9930abcc57930ddd4b6f56f4df9c
Author: Michaël Lefèvre
Date: Sun Nov 16 14:18:49 2014 +0100
Move pFlyOnly into properties container
Cha
sw/source/core/layout/paintfrm.cxx | 76 ++---
1 file changed, 39 insertions(+), 37 deletions(-)
New commits:
commit 39fe63b8b998894f4f7c3736188bdde1b4cc6c71
Author: Michaël Lefèvre
Date: Sun Nov 16 13:51:18 2014 +0100
Move scale factors inside the prop
sw/source/core/layout/paintfrm.cxx | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
New commits:
commit 7ad6eb2c9b0b6e7f6d3993d293d8ee0cf3dcbc7f
Author: Michaël Lefèvre
Date: Sun Nov 16 12:13:23 2014 +0100
Remove dead code
Change-Id: Ieac5dec327f520322
sw/source/core/layout/paintfrm.cxx |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
New commits:
commit 612a5f54015eedf832ce1d0ff9062ba819976ea6
Author: Michaël Lefèvre
Date: Sun Nov 16 12:10:28 2014 +0100
Make const variables const
Change-Id: Ib29fa559028327ffb88
sw/source/core/layout/paintfrm.cxx | 58 +
1 file changed, 34 insertions(+), 24 deletions(-)
New commits:
commit b66f1edef2a64803b8ebde913c26a3c0727e9186
Author: Michaël Lefèvre
Date: Sun Nov 16 11:38:35 2014 +0100
Put properties in their own struct
Added to https://wiki.documentfoundation.org/Development/Developers
Michaël
2014-11-18 1:43 GMT+01:00 TANAKA Hidemune :
> All of my past & future contributions to LibreOffice may be
>
> licensed under the MPLv2/LGPLv3+ dual license.
>
>
> TANAKA Hidemune
>
>
> _
vcl/source/edit/textdat2.hxx | 19 ++---
vcl/source/edit/textdata.cxx | 30 +++---
vcl/source/edit/texteng.cxx | 87 ++-
vcl/source/edit/textview.cxx | 34
4 files changed, 75 insertions(+), 95 deletions(-)
New commits:
sfx2/source/appl/linksrc.cxx | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
New commits:
commit 9769a69f49c77599053ab8f15b149506af555134
Author: Michaël Lefèvre
Date: Mon Oct 6 11:39:22 2014 +0200
fdo#75757: remove inheritance to std::vector
sw/inc/undobj.hxx |2 -
sw/source/core/inc/UndoCore.hxx | 40 ---
sw/source/core/undo/undobj.cxx | 51 +++-
sw/source/core/undo/unredln.cxx |2 -
4 files changed, 48 insertions(+), 47 deletions(-)
New commi
vcl/source/edit/textdat2.hxx | 13 ++---
vcl/source/edit/textdata.cxx | 14 ++
2 files changed, 12 insertions(+), 15 deletions(-)
New commits:
commit 07f9ccf99c6746351dfdd26a046c788693632dfb
Author: Michaël Lefèvre
Date: Mon Oct 13 16:13:31 2014 +0200
fdo#75757:
sfx2/source/dialog/templdlg.cxx | 54 +++-
1 file changed, 21 insertions(+), 33 deletions(-)
New commits:
commit ae77dc81c33ab0817264bcf5fc8bb71a55b78a73
Author: Michaël Lefèvre
Date: Mon Oct 6 15:51:21 2014 +0200
fdo#75757: remove inheritance to st
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Thanks for the tips, I will continue to build with avmedia ;)
Cheers,
Michael
2014-05-26 21:25 GMT+02:00 Tor Lillqvist :
> You must have missed the "Work in progress, use only if you are hacking on
> it."
>
> --tml
>
___
LibreOffice mailing list
Libre
Hello,
just to let you know that while build with the following options,
--disable-database-connectivity --disable-extensions --disable-avmedia
--disable-vba --disable-odk --without-java
I got this failure message :
/home/michael/code/libreoffice/workdir/CxxObject/slideshow/source/engine/shapes
hello,
i'm actually looking at https://bugs.freedesktop.org/show_bug.cgi?id=45168 .
"LibreOffice-Printing and PDF export enhancement/medium NEW Add Option to
crop Images in PDF Export"
As I understood, if an new option to be created is selected in the PDF
export dialog, the pdf writer must put in
basic/source/runtime/runtime.cxx|4 +-
dbaccess/source/core/api/resultset.cxx |4 +-
dbaccess/source/core/recovery/subcomponentrecovery.cxx |2 -
dbaccess/source/filter/xml/xmlExport.cxx|2 -
dbaccess/source/ui/dlg/dsselect.
include/osl/diagnose.h |2 --
registry/test/regdiagnose.h |2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
New commits:
commit fe075edc27a1fc301c31cfdff5ddbc83e52d929f
Author: Michaël Lefèvre
Date: Mon Apr 7 15:33:26 2014 +0200
fdo#43157 : [API CHANGE] Remove OSL_THIS
include/osl/diagnose.h |6 --
registry/test/regdiagnose.h |4 ++--
2 files changed, 2 insertions(+), 8 deletions(-)
New commits:
commit df2c663fef3435a8c3d541b364780876229ccd29
Author: Michaël Lefèvre
Date: Mon Apr 7 16:10:57 2014 +0200
fdo#43157 [API CHANGE] Remove dep
connectivity/source/commontools/RowFunctionParser.cxx |4 ++-
include/osl/diagnose.h| 12 --
slideshow/source/engine/smilfunctionparser.cxx|9 +--
svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx |
accessibility/source/extended/textwindowaccessibility.cxx |7 ---
canvas/source/tools/spriteredrawmanager.cxx |6 --
connectivity/source/commontools/parameters.cxx|7 +--
connectivity/source/drivers/hsqldb/HConnection.cxx|
To unsubscribe, visit https://gerrit.libreoffice.org/settings
>
> Gerrit-MessageType: merged
> Gerrit-Change-Id: I770b8b9fb82f873ccb88dc26ac05206f703ddf33
> Gerrit-PatchSet: 3
> Gerrit-Project: core
> Gerrit-Branch: master
> Gerrit-Owner: Michaël Lefèvre
> Gerrit-Reviewer: C
chart2/source/tools/NumberFormatterWrapper.cxx |2 +-
chart2/source/view/charttypes/VSeriesPlotter.cxx |2 +-
forms/source/xforms/datatypes.cxx|2 +-
include/sal/log-areas.dox|7 ++-
sfx2/source/doc/sfxbasemodel.cxx |
sal/osl/unx/security.c | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
New commits:
commit 5b4b6b2aad548cdc27ba2aa7d87ff584ec7e97dd
Author: Michaël Lefèvre
Date: Thu Mar 20 21:27:40 2014 +0100
fdo#56284 : soffice fails to start unless ~/.confi
d 4.0. It's 10% change.
If responding to this mail, be informed that I'm not suscribe to the list.
Regards,
Michaël Lefèvre
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Dammit, I forget about license one more time ;)
Submit under LGPLv3+ / MPL license !
Forgive me for the 9 patches to push. I've just commited on local
repository #define by #define. That gave me 3 patches for a single
file. I definitively have to learn more about git usage.
On Thu, Apr 14, 2011 a
Actually, this was part of the easy hack "hunt and destroy obsolete
macros". As I have very little time (2h/week) to join the fun, and
taking some vacation for a month, I didn't "apply" to this on the
wiki. To any one, fill free to complete the task.
After vcl enum, Christina ;) you' re in ?
Re
As usual, under LPGLv3+/MPL ;)
On Mon, Mar 21, 2011 at 10:18 PM, Michael Lefevre wrote:
> Xavier SVX_LIGHT deletion forgot just on occurence.
> This patch delete the last one.
> ---
> editeng/source/items/borderline.cxx | 4
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --g
As I started simple easy hack on libreoffice a month ago, I'm using
opengrok.libreoffice.org to search for code.
But anytime I load the page, it still show
"Indexes created Thu Feb 17 00:44:12 CET 2011"
at the bottom.
And a quick search did show that my last patch from march 17th, has
not been r
Thank. No problems with the license. It will be the case for any of
the next patches also.
Michaël
2011/3/17 Thorsten Behrens :
> Michaël Lefèvre wrote:
>> Damned misunderstanding ;)
>>
>> I've posted the patches once the compilation succeeds yesterday evening.
>>
Damned misunderstanding ;)
I've posted the patches once the compilation succeeds yesterday evening.
Michaël
2011/3/16 Michaël Lefèvre :
> Actually not tested :(
> Just keep compiling.
>
> Solar.h
> #define F_PI 3.14159265358979323846
>
> And ftools.h
> #define
Actually not tested :(
Just keep compiling.
Solar.h
#define F_PI 3.14159265358979323846
And ftools.h
#define F_PI M_PI
M_PI defined in OdgExporter.cxx as
#define M_PI 3.14159265358979323846
Same values.
The value changed in the other constants F_PI*. In solar.h, these are
fixed, where in ftool
On Thu, Feb 24, 2011 at 5:17 PM, Caolán McNamara wrote:
> On Wed, 2011-02-23 at 22:17 +0100, Michael Lefevre wrote:
>> Go on with comments suppression.
>
> Looks good, pushed, thanks for this.
>
> Are these patches submitted under our recommended LGPv3+/MPL combo ?
> (http://www.documentfoundation
Hye,
I'm joining the fun.
Here's my first time to git, and first patch for Libreoffice.
Take it under LGPLv3+ / MPL.
regards,
Michael
From ae373b2ff0594ee00f2e832d4d11f5f321c0d5e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C3=ABl=20Lef=C3=A8vre?=
Date: Tue, 22 Feb 2011 23:07:28 +0100
Subject
85 matches
Mail list logo
