Hints for Bug 61495 - Indentation difference for Backspace and Shift+Enter after conversion to .doc/.docx

Hi *, I have found a Bug in LibreOffice Writer https://bugs.freedesktop.org/show_bug.cgi?id=61495 and I would like to hack on this. I need a hint, where is code for export filter to docx or doc? Best Regards, Maciek ___ LibreOffice mailing list Lib

The meaning of core/starmath/sdi/smath.sdi

Hi *, does someone know what is the meaning of this ( http://opengrok.libreoffice.org/xref/core/starmath/sdi/smath.sdi) file? It uses a lot of SfxVoidItem which I am currently investigating and trying to use as DisabledItem mark. http://cgit.freedesktop.org/libreoffice/core/tree/svl/source/items/

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Hi Bjoern, 2012/11/30 Bjoern Michaelsen > Yes, there are quite a few evil cornercases lurking there. Before changing > those conditionals, I think it is a good idea to just add assertions that > make > sure these assumptions are kept consistent all the time. A start would be > to > check that wh

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Hi Bjoern, thanks for reply :) So, to change the conditionals, we need to make sure the state is > consistent. > Thus: > - adding the asserts > Do you mean DBG_ASSERT or real assert? How do debug those DBG_ASSERT, when compiling I don't get a lot of output. My command is make 2>&1 | tee build.l

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Just Ping if someone could help me on that. 2012/11/26 Maciej Rumianowski > I failed here. Every place Item with which-id 4040 (EE_FEATURE_LINEBR) is > created/copied/setWhich is a valid SfxVoidItem with Type() method. Only > fails in SfxItemSet destructor as below > > Program

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

I failed here. Every place Item with which-id 4040 (EE_FEATURE_LINEBR) is created/copied/setWhich is a valid SfxVoidItem with Type() method. Only fails in SfxItemSet destructor as below Program received signal SIGSEGV, Segmentation fault. > 0x4496cc33 in SfxItemSet::~SfxItemSet (this=0xbfff51e8, >

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

> > Ok I lack knowledge about inheritance and what really is called. Above are > not equal :( > (gdb) print (*ppFnd)->StaticType() == (*ppFnd)->Type() >> $7 = false >> > > Ok, I have found (maybe) why it is going so. A class that inherits from SfxPoolItem does not use TYPEINFO() macro and i have to

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

2012/11/22 Maciej Rumianowski > > > 2012/11/22 Maciej Rumianowski > >> Hi Bjoern, >> >> I have hit a problem that i don't fully understand. Disabled items are >> SfxVoidItem with Which 0, but inserted with different one. State of Item is >> che

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

2012/11/22 Maciej Rumianowski > Hi Bjoern, > > I have hit a problem that i don't fully understand. Disabled items are > SfxVoidItem with Which 0, but inserted with different one. State of Item is > check with TYPE Macro as below > >> if ( (*ppFnd

Re: Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Hi Bjoern, I have hit a problem that i don't fully understand. Disabled items are SfxVoidItem with Which 0, but inserted with different one. State of Item is check with TYPE Macro as below > if ( (*ppFnd)->Type() == TYPE(SfxVoidItem) ) > return SFX_ITEM_DISABLED; > So it

Bug 34465 - get rid of all calls to virtual const SfxPoolItem* Put( const SfxPoolItem&, USHORT nWhich)

Hi Björn, I've started to work on the *Bug 34465*and I have some questions: 1) What do you suggest to find all places where Put( const SfxPoolItem&, USHORT nWhich) is used? I came up with idea to make function private and fix all places wher

Re: JUnit sc_complex fails in Localized enviroment

Dnia 2012-02-27, pon o godzinie 10:58 +, Michael Meeks pisze: > Hi there, > > On Sat, 2012-02-25 at 17:52 +0100, Maciej Rumianowski wrote: > > I hjave discovered a problem when checking libreoffice build (master), > > below is log. It seems that test i

JUnit sc_complex fails in Localized enviroment

lc-filters-test-problem-in-Localized-enviroment-td3382023.html). I don't know How Michael fixed it. Best Regards, Maciej Rumianowski > maciej@maciej-desktop:~/Dokumenty/LibreOffice-Dev/master/sc$ make -sr -j10 > /home/maciej/Dokumenty/LibreOffice-Dev/master/workdir/unxlngi6.pro/Juni

[PATCH] EasyHacks fdo#38831 VARARR and VARARR_SORT

Hi *, small patches partially cleaning svltools from svarrays. Best Regards, Maciej Rumianowski >From 574028e9cef7bfcfc5d7fcaafa075ad1b8e9bb49 Mon Sep 17 00:00:00 2001 From: Maciej Rumianowski Date: Sat, 25 Feb 2012 14:58:16 +0100 Subject: [PATCH 1/3] Replace VARARR_SORT TESortedPositi

Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

2011/10/6 Stephan Bergmann > > Btw, &v[0] (as well as &v.front()) are only valid if !v.empty() -- but > (without checking it in detail right now) I guess the patch already takes > account of that, Maciej? > Yes it does. Mostly it is one function that takes also the size of data. Cheers, Mac

Re: [Libreoffice] [PUSHED] Re: [PATCH] Replace WW8Bytes with ww::bytes

2011/10/7 Jan Holesovsky > No need to, I took this approach > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1eda55a0670cd571d676b46d2ac19fe86d51a3f > > and modified your patches myself. I've pushed them under your name, as > all I did was a sed :-) > > > http://cgit.freedesktop.or

Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

Dnia 2011-10-05, śro o godzinie 17:35 +0200, Lubos Lunak pisze: > On Wednesday 05 of October 2011, Jan Holesovsky wrote: > > Hi Maciej, > > > > On 2011-10-05 at 10:39 +0200, Maciej Rumianowski wrote: > > > There was a lot of WW8Bytes( SV_DECL_VARARR ) which was partly

[Libreoffice] [PATCH] Remove last instance and Finally remove SvULongs

Hi *, I'm sending 2 patches removing finally SvULongs from LibreOffice:) Cheers, Maciej >From 820bb5c8f68c2cb0219dfa49cacae094c32f62f2 Mon Sep 17 00:00:00 2001 From: Maciej Rumianowski Date: Fri, 30 Sep 2011 15:55:58 +0200 Subject: [PATCH] Finally remove SvULongs In all places

[Libreoffice] calc filters-test problem in Localized enviroment

Hi *, I am building LibreOffice since July and I have never set any Localization Options. I don't know if it is necessary for build without install. But now Calc's Filter-test fails with such output (DEBUG_CSV_HANDLER is on) > [ build CXX ] sc/qa/unit/filters-test > [ build DEP ] LNK:CppunitTes

Re: [Libreoffice] Build Error - Graphite2-1.0.3

Dnia 2011-09-29, czw o godzinie 10:29 +0200, Maciej Rumianowski pisze: > Hi, > > I have encountered an error while building latest source. > > > > = > > (1/1) Building module graphite > > = > > Entering /home/maciej/Do

Re: [Libreoffice] [PATCH][PUSHED] Replace-SvULongs-with-std-vector-in-sfx2

Hi David, > > @@ -53,7 +54,7 @@ TYPEINIT1_FACTORY( SvxClipboardFmtItem, SfxPoolItem , new > > SvxClipboardFmtItem(0 > > SvxClipboardFmtItem_Impl::SvxClipboardFmtItem_Impl( > > const SvxClipboardFmtItem_Impl& rCpy ) > > { > > -aFmtIds.Insert( &rCpy.aFmtIds, 0 );

[Libreoffice] Build Error - Graphite2-1.0.3

Hi, I have encountered an error while building latest source. > = > (1/1) Building module graphite > = > Entering /home/maciej/Dokumenty/LibreOffice-Dev/master/graphite > > Compiling: > libgraphite2_off/unxlngi6.pro/misc/build/graphite2-1.0.3/src/direct_machine.cpp > Co

[Libreoffice] [PATCH] Replace-SvULongs-with-std-vector-in-sfx2

Hi *, Simple Patch replacing SvULongs with std::vector. Related Bug 38831. Cheers, Maciej >From 6e3f88f2673c507ce2f3d9ab4bdc92c8be75bd0a Mon Sep 17 00:00:00 2001 From: Maciej Rumianowski Date: Tue, 27 Sep 2011 22:04:20 +0200 Subject: [PATCH] Replace SvULongs with std::vector in sfx2 Bug 38

[Libreoffice] [PATCH] Re: Replace SvULongs and SvUShorts in svx with std::vector

Marking as PATCH. Might got lost. Cheers Maciej ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Replace SvULongs and SvUShorts in svx with std::vector

Hi, This is another one patch replacing SvULongs and SvUShorts with std::vector. Cheers, Maciej >From 06db1aa6489e2fac7b088f30fe6cd85629c7ef08 Mon Sep 17 00:00:00 2001 From: Maciej Rumianowski Date: Wed, 21 Sep 2011 09:19:50 +0200 Subject: [PATCH] Replace SvULongs and SVUShorts with

[Libreoffice] [PATCH] Use STL find in SvxNumberFormatShell

Hi, My patch got lost on mailing list, so I am attaching it now against actual master. Discussion was here http://lists.freedesktop.org/archives/libreoffice/2011-August/016218.html Best Regards, Maciej >From 63ca5f6af27123f821446e39eaa4b152652eec7f Mon Sep 17 00:00:00 2001 From: Mac

[Libreoffice] [PATCH] Use STL find() in SvxNumberFormatShell

iej >From 3e1925dec379e88832594b3f6032df1ca6569026 Mon Sep 17 00:00:00 2001 From: Maciej Rumianowski Date: Tue, 9 Aug 2011 01:15:16 +0200 Subject: [PATCH] Use STL find() in SvxNumberFormatShell With SvULongs replaced by std::vector std::find can be used in IsRemoved_Impl IsAdded_Impl --- s

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

Dnia 2011-08-07, nie o godzinie 21:31 +0200, Eike Rathke pisze: > I suggest > > ::std::vector::iterator GetAdded_Impl( size_t nKey ); > > with logically the content of IsAdded_Impl() but using ::std::find() > instead of the awkward loop and returning the position's iterator that > can be used in

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

d in other places try to use size_t. Best Regards, Maciej >From ba07b8f694f9736b9c43dc3f0a34d1248d8fcd77 Mon Sep 17 00:00:00 2001 From: Maciej Rumianowski Date: Sun, 7 Aug 2011 16:46:17 +0200 Subject: [PATCH] Replace SvULongs with vector and code clean up Instead of SvULongs use std::v

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

Hi Eike, Thanks for review! Dnia 2011-08-06, sob o godzinie 17:35 +0200, Eike Rathke pisze: > > > { > > -if ( aDelList[i] == nAddKey ) > > +if ( *it == nAddKey ) > > { > > bFound = sal_True; > > -

[Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

88,7 @@ String SvxNumberFormatShell::GetComment4Entry(short > nEntry) > if(nEntry < 0) > return String(); > > -if(nEntry +if(nEntry < (short)aCurEntryList.size()) > { 5. Should short type be replaced with sal_Int16 or more appropriate type?

Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

Dnia 2011-08-04, czw o godzinie 23:23 +0200, Maciej Rumianowski pisze: > Okay so I will work further on SvULongs, there is some in libs-gui, > and > than come back to writer. Sorry, I meant libs-core. If I see any sal_Bool (sal_True, sal_False), should I change it to standard bo

Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

Dnia 2011-08-04, czw o godzinie 12:09 -0400, Kohei Yoshida pisze: > On Thu, 2011-08-04 at 00:40 +0200, Maciej Rumianowski wrote: > > Ok. The new patch looks good (to me). Pushed to master. Thanks :) > > > > Other than that, the rest looks okay to me. I&

Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

ore > experienced in Writer's code to sanity-check though. O, so by the way there is in wrtww8.hxx a VARARR WW8Bytes which should be migrated to ww::bytes. Is it okay to do? Best Regards, Maciej >From 80b069e455f1f6f166d279235f3b8c14da07c9b8 Mon Sep 17 00:00:00 2001 From:

[Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

rom fd48141c12a6e9abd84d32fd1553a789bd9e2a4b Mon Sep 17 00:00:00 2001 From: Maciej Rumianowski Date: Tue, 2 Aug 2011 17:27:34 +0200 Subject: [PATCH] Get rid of SvULongs in writer Replace SvULongs with std::vector. In SwHTMLWriter simultaneously replace aOutlineMarks with boost::ptr_vector. --- sw/sou

Re: [Libreoffice] [Libreoofice] build errors - missing SvStream::remainingSize

Dnia 2011-07-22, pią o godzinie 03:07 +0700, thamht pisze: > Hi, > > I'm trying to build libreoffice right after './g pull -r' to get the > latest source code, however, there are some errors as the following: I see that SvStream was added 3 days ago, are you sure ./g pull -r went fine? > /media

Re: [Libreoffice] [Fwd: RE: LibreOffice Build Problem]

Hi, I forwarded Tugay's message to list, because he forgot. @Michael there is part to you. > > /home/ilbay/Desktop/libreoffice/bootstrap/svtools/source/contnr/imivctl1.cxx:295: > > error: prototype for ‘void > > SvxIconChoiceCtrl_Impl::InsertEntry(SvxIconChoiceCtrlEntry*, size_t, const > > Po

[Libreoffice] [Fwd: RE: LibreOffice Build Problem]

--- Begin Message --- Hi, I did the following: > > rm -Rf /home/ilbay/Desktop/libreoffice/bootstrap/svtools/unxlngi6.pro > > # optional module 'clean' > > /bin/bash > > cd /home/ilbay/Desktop/libreoffice/bootstrap > > source ./LinuxX86Env.Set.sh > > cd svtools > > make -r and I got this error

Re: [Libreoffice] [PATCH] Get rid of SvULongs in calc

Dnia 2011-07-20, śro o godzinie 17:12 -0400, Kohei Yoshida pisze: > > So, I've reviewed your revised patches and they look good. I've > pushed > them to master with one minor syntactic change. Great thanks :) > Anyway, thanks for your patches again, and we look forward to > receiving > more pat

Re: [Libreoffice] LibreOffice Build Problem

Hi, > I would like to join the LibreOffice development community, but i have > a problem. Recently I have also joined LibreOffice development me first patch is waiting to be pushed, so Hello:) > I tried to build LibreOffice as shown on > http://www.libreoffice.org/get-involved/developers/. But wh

Re: [Libreoffice] sylk unit tests

Hi Michael, > Hey ! - so unit tests are -never- useless, particularly if they are > fast, small and run during the build. Indeed - I would -love- to have > much more unit test coverage of calc. I also like the Idea of unit tests and an Easy Hack with calc unit tests is on my radar :) >

Re: [Libreoffice] [PATCH] Get rid of SvULongs in calc

r patches > under LGPLv3+/MPL 1.1. Of course and future also. Best Regards, Maciej >From a4f2da5241afdd8062f9611ca1f580df1c2ffe54 Mon Sep 17 00:00:00 2001 From: Maciej Rumianowski Date: Tue, 19 Jul 2011 10:50:54 +0200 Subject: [PATCH] Get rid of SvULongs in calc Instead of Sv

Re: [Libreoffice] [PATCH] Get rid of SvULongs in calc

Spotted some mistakes in calc patch. >From e7db01344f8fef4ca2f2f59868736033d0126b1b Mon Sep 17 00:00:00 2001 From: Maciej Rumianowski Date: Mon, 18 Jul 2011 09:22:57 +0200 Subject: [PATCH] Get rid of SvULongs in calc Instead of SvULongs use ::std::vector < sal_uLong > --- .../items

[Libreoffice] [PATCH] Get rid of SvULongs in calc

ionsItemConverter are copying from Sequence to SvULongs and then in > SfxIntegerListItem SvLongs is copied to Sequence. As I wrote before I have added a constructor to SfxIntegerListItem, is it okay? Best Regards, Maciej >From 6af35271b8738116393900ba349354d1f3f0bf1b Mon Sep 17 00:

[Libreoffice] SfxIntegerListItem constructor used by DataPointItemConverter and SeriesOptionsItemConverter

ter.cxx:436 /libs-gui/svl/source/items/ilstitem.cxx:47 Best Regards, Maciej Rumianowski ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] sylk unit tests

Hi Caolán, > Hmm, well I've now added a sylk import unit test to sc, i.e. > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8ac49ef8ab4f065d7b729dcb15505c602c77 > Thanks, but as Nigel pointed out it's hard to unit test every peace of LO and I don't think my small change is worth it.

Re: [Libreoffice] [PATCH] [PUSHED] Re: svtools/source/contnr/imivctl1.cxx not matching imivctl1.hxx

Dnia 2011-07-17, nie o godzinie 06:49 -0700, Joseph Powers pisze: > I changed the .hxx instead of the .cxx; we really should be using > size_t instead of sal_uLong. Thanks! I will remember this. Maciej ___ LibreOffice mailing list LibreOffice@lists.free

[Libreoffice] [PATCH] Re: svtools/source/contnr/imivctl1.cxx not matching imivctl1.hxx

Dnia 2011-07-16, sob o godzinie 15:37 +0200, Maciej Rumianowski pisze: > Hi, > > in latest commit: > http://cgit.freedesktop.org/libreoffice/libs-gui/diff/svtools/source/contnr/imivctl1.cxx?id=593060f913a253b5a1998c7791e7ed87e7f49c97 > > imivctl.hxx and imivctl1.cxx

[Libreoffice] svtools/source/contnr/imivctl1.cxx not matching imivctl1.hxx

Hi, in latest commit: http://cgit.freedesktop.org/libreoffice/libs-gui/diff/svtools/source/contnr/imivctl1.cxx?id=593060f913a253b5a1998c7791e7ed87e7f49c97 imivctl.hxx and imivctl1.cxx were changed, but SvxIconChoiceCtrl_Impl::InsertEntry declaration doesn't match definition. I have changed it an

[Libreoffice] Bug 38831 - [EasyHack] Get rid of SV_DECL_VARARR, SV_DECL_VARARR_PLAIN, SV_DECL_VARARR_SORT ....

Hi, First all you awesome Developers are doing great Software! I would like to help you:) I picked up this bug and tried to get rid of SvULongs. I found for example in ScImportExport::Sylk2Doc and thought it would be good to first write a unit test (since there are unit tests of calc). But I wasn