This patch should fix the cppcheck style warnings for grfmgr.cxx:
core/svtools/source/graphic/grfmgr.cxx
278 variableScope style The scope of the variable 'nNewLeft' can be
reduced
278 variableScope style The scope of the variable 'nNewTop' can be
reduced
278 variableScope
Hi,
this patch fixes two "unchecked return value"-warnings in svpclient
// Kenneth
diff --git a/vcl/workben/svpclient.cxx b/vcl/workben/svpclient.cxx
index e7e32d7..af56dc3 100644
--- a/vcl/workben/svpclient.cxx
+++ b/vcl/workben/svpclient.cxx
@@ -248,10 +248,15 @@ rtl::OString MyWin::processComm
Hi,
there are a lot of compiler warnings when building ICC. It seems that
building ICC consists of extracting
src/fdb27bfe2dbe2e7b57ae194d9bf36bab-SampleICC-1.3.2.tar.gz and applying a
patch, then compiling it.
Most, if not all, of the warnings are in the SampleICC code.
"IccTagLut.cpp:4336: warn
Norbert,
thanks for the feedback.
2011/1/30 Norbert Thiebaud
> On Sat, Jan 29, 2011 at 5:43 PM, Kenneth Venken
> wrote:
> > Hi,
> >
> > i came across gendict.cxx while fixing a possible memleak. It took me
> some
> > time to figure out what the code did.
>
Hi,
this removes the unreadVariable lame_frame_size in
./filters/filter/source/flash/swfwriter.cxx<http://libreoffice.boldandbusted.com/269.html>
-- Kenneth
From 10e64f12f50fb2186676b053d9d130fdbccaf91b Mon Sep 17 00:00:00 2001
From: Kenneth Venken
Date: Sun, 30 Jan 2011 01:32:09 +0100
S
hi,
this removes unread variable pTargetPage from
./impress/sd/source/core/drawdoc2.cxx<http://libreoffice.boldandbusted.com/368.html>
-- Kenneth
From 790ae5ce71d14ce6100fc97d81b24f960e8323d5 Mon Sep 17 00:00:00 2001
From: Kenneth Venken
Date: Sun, 30 Jan 2011 01:05:55 +0100
Subject:
butor some time in understanding
gendict ;)
BTW, i tested the code on ja.dic and output is still the same.
-- Kenneth
From 7155a3675cf3410ab74dc7032bceaef719548d3c Mon Sep 17 00:00:00 2001
From: Kenneth Venken
Date: Thu, 27 Jan 2011 22:27:24 +0100
Subject: [PATCH 1/8] added some documentati
2011/1/28 Michael Meeks
> Hi there,
>
> On Thu, 2011-01-27 at 20:55 +0100, Kenneth Venken wrote:
> > these patches remove some comments
> > from ./filters/binfilter/bf_svx/source/editeng/svx_editobj.cxx and
>
> I've pushed these two.
>
> > fixe
Fixes two memleaks.
-- Kenneth
From 4cd88904ea50619dbc0965ea2683ea270a74013b Mon Sep 17 00:00:00 2001
From: Kenneth Venken
Date: Wed, 26 Jan 2011 19:39:13 +0100
Subject: [PATCH] cpp cleanliness: fixed some memleaks
---
fpicker/source/unx/kde/kdecommandthread.cxx |1 +
1 files changed, 1
Hi,
these patches solve some of the 'redundant assignment to self' warnings.
Released under LGPLv3
-- Kenneth
From 29ee756d84415238dbbd4785dc6d7f4d2b0be296 Mon Sep 17 00:00:00 2001
From: Kenneth Venken
Date: Tue, 25 Jan 2011 18:39:18 +0100
Subject: [PATCH] Cpp cleanliness: redundant
Hi,
released under LGPLv3
-- Kenneth
From 240f4ce00923fe9487518378972d80e893506d56 Mon Sep 17 00:00:00 2001
From: An Leenders
Date: Tue, 25 Jan 2011 17:37:59 +0100
Subject: [PATCH] cpp cleanliness: check for assignment to self
---
extensions/source/abpilot/datasourcehandling.cxx |8 +--
hey,
more use of the SAL_N_ELEMENTS macro like replacing the
STATIC_TABLE_SIZE macro.
-- Kenneth
>From 62a94ea8d83b129ef479304865d3f2085b191c32 Mon Sep 17 00:00:00 2001
From: Kenneth Venken
Date: Fri, 3 Dec 2010 01:41:20 +0100
Subject: [PATCH] more Sal n elements
---
chart2/source/to
hi,
these patches will replace the last occurrences of
sizeof(foo)/sizeof(foo[0]) with SAL_N_ELEMENTS(foo)
-- Kenneth
diff --git a/extensions/source/activex/main/SOActionsApproval.cpp b/extensions/source/activex/main/SOActionsApproval.cpp
index fd4abb1..c0da27f 100644
--- a/extensions/source/acti
Michael Meeks schreef op ma 18-10-2010 om 19:49 [+0100]:
> Hi there,
>
> On Mon, 2010-10-18 at 13:50 +0200, Kenneth Venken wrote:
> > this patch replaces all occurrences of sizeof.*/.*sizeof.*\[ with
> > SAL_N_ELEMENTS in ure
>
> Thanks - there
Hi,
this patch replaces all occurrences of sizeof.*/.*sizeof.*\[ with
SAL_N_ELEMENTS in ure
-- Kenneth
diff --git a/sal/inc/systools/win32/uwinapi.h b/sal/inc/systools/win32/uwinapi.h
index 6c19788..7fda61e 100644
--- a/sal/inc/systools/win32/uwinapi.h
+++ b/sal/inc/systools/win32/uwinapi.h
@@ -1
Hi,
patches replace sizeof/sizeof[0] with SAL_N_ELEMENTS in testing and sdk
-- Kenneth
diff --git a/odk/examples/OLE/activex/SOComWindowPeer.cpp b/odk/examples/OLE/activex/SOComWindowPeer.cpp
index 0b2fabf..a3f4d50 100644
--- a/odk/examples/OLE/activex/SOComWindowPeer.cpp
+++ b/odk/examples/OLE/a
Hi,
this patch removes the unused bufsizeof macro.
BTW, this patch and all other patches submitted by me to be used in
LibreOffice are released under LGPLv3+.
-- Kenneth
diff --git a/sal/osl/w32/module.cxx b/sal/osl/w32/module.cxx
index 57ec786..ad67487 100644
--- a/sal/osl/w32/module.cxx
+++ b
replaces the ELEMENTS_OF_ARRAY macro, defined in sal/osl/os2/file_url.h,
with the SAL_N_ELEMENTS, defined in sal/macros.h
diff --git a/sal/osl/os2/file_url.cxx b/sal/osl/os2/file_url.cxx
index 04d103a..6ea7490 100644
--- a/sal/osl/os2/file_url.cxx
+++ b/sal/osl/os2/file_url.cxx
@@ -52,6 +52,7 @@
Hi,
these patches removes the elementsof macro, defined in
, and replaces it with the SAL_N_ELEMENTS
macro, defined in
Kenneth
diff --git a/crashrep/source/win32/soreport.cpp b/crashrep/source/win32/soreport.cpp
index f7918ee..bb4821b 100644
--- a/crashrep/source/win32/soreport.cpp
+++ b/crashre
Hi,
some patches to fix EASY HACK 2.6
found some equivalent macros:
- elementsof
- ELEMENTS_OF_ARRAY
- bufsizeof
i'll try and replace them all with SAL_N_ELEMENTS tomorrow.
diff --git a/connectivity/source/drivers/dbase/DTable.cxx b/connectivity/source/drivers/dbase/DT
some patches that replace sizeof(a)/sizeof(a[0]) with SAL_N_ELEMENTS(a)
diff --git a/sc/source/ui/vba/vbapagesetup.cxx b/sc/source/ui/vba/vbapagesetup.cxx
index 3b1a8ae..c80e407 100644
--- a/sc/source/ui/vba/vbapagesetup.cxx
+++ b/sc/source/ui/vba/vbapagesetup.cxx
@@ -41,6 +41,7 @@
#include
#inc
some "shadows a member of 'this'" and "unused parameter" warnings.
i've added an underscore prefix to the parameters that shadowed the
members. Are there any naming conventions i should know of?
what is the correct way to handle the "unused parameter" warnings?
In this case the whole function pr
Jan Holesovsky schreef op vr 15-10-2010 om 22:18 [+0200]:
> Hi Kenneth,
>
> On 2010-10-15 at 21:10 +0200, Kenneth Venken wrote:
>
> > Fixes a compiler warning: "suggest parentheses around && within || "
> > I also improved the readability of the code
Fixes a compiler warning: "suggest parentheses around && within || "
I also improved the readability of the code a bit.
diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index 1ef3e3d..41f470e 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cx
Michael Meeks schreef op vr 15-10-2010 om 18:23 [+0100]:
> Hi Kenneth,
Hi Michael,
>
> On Fri, 2010-10-15 at 01:29 +0200, Kenneth Venken wrote:
> > this is my first patch for Libreoffice.
> > contributed under the LGPLv3+
>
> Welcome ! :-) many thanks for your
Hi,
this is my first patch for Libreoffice.
contributed under the LGPLv3+
greetings,
Kenneth Venken
diff --git a/basctl/source/basicide/doceventnotifier.cxx b/basctl/source/basicide/doceventnotifier.cxx
index 297be9a..6335be5 100644
--- a/basctl/source/basicide/doceventnotifier.cxx
+++ b
26 matches
Mail list logo
