License statement

2012-05-10 Thread Keith McRae
To whom it may concern All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license Thanks and regards Keith McRae ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop

Re: [LibreOffice] [Bug 39428] audit / remove SvStream long operators

2012-02-06 Thread Keith McRae
On Wed, Feb 1, 2012 at 3:09 PM, wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=39428 > > --- Comment #9 from Caolán McNamara 2012-02-01 > 07:09:32 PST --- > here's one place I know about where the current std::stream-alike "failed > reads > leave the original value untouched" is relied up

Re: [Libreoffice] [LibreOffice] [39428] Remove SvStream operator>>/<

2012-01-26 Thread Keith McRae
Given that these are almost exclusively called with , I would simply un-template'ize the functions, substituting sal_uInt16 for prefix. > > For instantiations with prefix != sal_uInt16, I count four uses of > read_lenPrefixed_uInt8s_ToOString, two of > read_lenPrefixed_uInt8s_ToOUString, and one us

[Libreoffice] [LibreOffice] [39428] Remove SvStream operator>>/<

2012-01-26 Thread Keith McRae
Hello all I've removed all the operator>>/<< from SvStream and replaced with Read/Write[sal_type] functions. While fixing up the references I noticed the template'd functions below: template rtl::OString read_lenPrefixed_uInt8s_ToOString(SvStream& rStrm) { prefix nUnits = 0; rStrm >> nUni

[Libreoffice] [LibreOffice] #fdo39428 Remove/audit SvStream operator>>/<<(long)

2012-01-18 Thread Keith McRae
Keith From fa4257356472f466673cd88cb2c4331386a30dda Mon Sep 17 00:00:00 2001 From: Keith McRae Date: Wed, 18 Jan 2012 14:51:03 + Subject: [PATCH 1/7] fdo#39428 Remove/audit SvStream operator>>/<<(long) Removed declarations & definitions for operator<<(long),(int)&(short) Re

Re: [Libreoffice] [LibreOffice] fdo#39428 Remove/audit SvStream operator long

2012-01-11 Thread Keith McRae
On Wed, Jan 11, 2012 at 3:39 PM, Keith McRae wrote: > Hello all > > I've hacked the tools/inc/stream.hxx and tools/source/stream/stream.cxx to > remove operator >>(long&) and operator <<(long). > To make tools/ build correctly I've also had to hack: &

[Libreoffice] [LibreOffice] fdo#39428 Remove/audit SvStream operator long

2012-01-11 Thread Keith McRae
Hello all I've hacked the tools/inc/stream.hxx and tools/source/stream/stream.cxx to remove operator >>(long&) and operator <<(long). To make tools/ build correctly I've also had to hack: tools/source/generic/fract.cxx tools/source/generic/gen.cxx tools/source/generic/poly.cxx SvStream& operator

[Libreoffice] Bug 39428 (https://bugs.freedesktop.org/show_bug.cgi?id=39428#c1)

2012-01-06 Thread Keith McRae
Hello all... Progress to date: In tools/inc/tools/stream.hxx Removed operator>> declarations for types long, short, int Removed operator<< declarations for types long, short, int Added operator>> declarations for types sal_uInt16, sal_uInt32, sal_uInt64, sal_Int16, sal_Int32, sal_Int64 Added oper