RE: Debugging on Visual Studio (Windows)

2024-07-19 Thread Kaganski Mike
On 19.07.2024 11:14, Miklos Vajna wrote: > On Thu, Jul 18, 2024 at 07:30:53PM -0700, Kira Tubo > wrote: >> 2. In Cygwin: make vs-ide-integration >> 3. In Visual Studio, open LibreOffice.sln >> 4. Add breakpoints to a .cxx file > > To be clear, this is for the IDE integration, debuggin

Re: build error : 'f__faststorefence': is not a member of 'GrGLInterface::Functions'

2020-01-31 Thread Kaganski Mike
On 2020-02-01 8:58, himajin10 wrote: > I'm getting the following error. how should I fix this error?(and why > doesn't Jenkis fail?) > > C:/build/workdir/UnpackedTarball/skia/src/gpu/gl/GrGLGpu.cpp(3771): > error C2039: 'f__faststorefence': is not a member of > 'GrGLInterface::Functions' >

Re: o3tl::make_unsigned

2020-01-31 Thread Kaganski Mike
On 2020-01-30 17:25, Luboš Luňák wrote: > On Thursday 30 of January 2020, Kaganski Mike wrote: >> Can the hypothetical make_signed function return a signed integer when >> there's a bigger integer type exist, > > Yes. > >> and a struct with overloaded >&g

Re: o3tl::make_unsigned

2020-01-30 Thread Kaganski Mike
On 2020-01-30 15:30, Stephan Bergmann wrote: > On 30/01/2020 12:56, Luboš Luňák wrote: >> On Thursday 30 of January 2020, Stephan Bergmann wrote: >>> On 29/01/2020 17:14, Luboš Luňák wrote:    Exactly my point. It's just that you seem to find it guaranteed that people won't mess up range

Re: Gsoc 2020

2020-01-26 Thread Kaganski Mike
Hi! On 2020-01-26 20:18, Ilmari Lauhakangas wrote: > You could try > --with-jdk-home=/cygdrive/c/Program Files/Java/jdk-13.0.1 In cygwin, I usually use forward-slash paths, which are perfectly-valid cygwin paths, like --with-jdk-home=C:/Program Files/Java/jdk-13.0.1 -- Best regards, Mike Kaga

Re: Duplicate .uno commands

2020-01-07 Thread Kaganski Mike
On 2020-01-05 17:22, Kaganski Mike wrote: > On 2020-01-05 2:38, Maxim Monastirsky wrote: >> The separate .uno:BulletsAndNumberingDialog command predates the >> handling of .uno:OutlineBullet in Writer. The latter was introduced >> only in 2013 as part of the sidebar

Re: Duplicate .uno commands

2020-01-05 Thread Kaganski Mike
Hi Maxim, On 2020-01-05 2:38, Maxim Monastirsky wrote: > The separate .uno:BulletsAndNumberingDialog command predates the > handling of .uno:OutlineBullet in Writer. The latter was introduced > only in 2013 as part of the sidebar feature work (commit > d02f75a8c36705924ddd6a5921fe3012fafce812, "Re

Re: Duplicate .uno commands

2020-01-03 Thread Kaganski Mike
Hi Miklos, Thanks for your comments! On 2020-01-03 11:28, Miklos Vajna wrote: >> The problem with this, besides duplication itself (including e.g. >> drawing icons), is that both of them appear in customization dialog, and >> that's confusing. > > You can avoid duplicated icons via icon-themes/.

Duplicate .uno commands

2020-01-01 Thread Kaganski Mike
Hi! In tdf#129549 [1], two .uno commands were identified as duplicating: .uno:BulletsAndNumberingDialog and .uno:OutlineBullet. First of them is Writer-specific [2]; second is not [3]. In Writer, both of them are routed to SwTextShell::ExecEnterNum, and handled identically (in the same switch

Re: Print dialog window too big with 6.4.0~rc1

2019-12-31 Thread Kaganski Mike
On 2019-12-31 16:32, Paul Menzel wrote: > LibreOffice 6.4.0.1 40(Build:1) seems to have redesigned the print > dialog. The window is too big now, causing the buttons in the bottom not > to be seen on a laptop with 1366x768 resolution and GNOME Shell, which > does not allow you to move the window

Re: Failing UI tests on Winx64 build

2019-12-29 Thread Kaganski Mike
Hi Stepas Toliautas, On 2019-12-30 0:32, Stepas Toliautas wrote: > > However, we're not out of the woods yet, since a single new error of > presumably the same type (access violation at shutdown) cropped up > in impress_demo uitest suite -- at /backgrounds.ImpressBackgrounds/, > i

Re: Benchmark results on mdds::multi_type_vector

2019-12-29 Thread Kaganski Mike
Hi Kohei, On 2019-12-14 1:38, Kohei Yoshida wrote: > Alright, since now one person is raising objection on hastily > integrating this piece, I should hold on to integrating this piece for > now, and let the discussion continue. If I understand correctly, there was no objections on integrating t

Re: Failing UI tests on Winx64 build

2019-12-29 Thread Kaganski Mike
Hi, On 2019-12-26 22:59, Stepas Toliautas wrote: > I happened to launch some "live" UI tests on my Windows 10 x64 machine > and noticed that some of them keep failing -- all with the same exit > status 3221225477 (0xC005, access violation) and, supposedly, right > at the end of testing, bec

Re: Avoid "JRE required" msg upon extension installation

2019-12-24 Thread Kaganski Mike
Hi Alexis, On 2019-12-25 3:23, Alexis de Lattre wrote: > I developed a LibreOffice Extension that contains a Python macro (and > the required Python libs): > > https://github.com/akretion/factur-x-libreoffice-extension  file > "factur-x_macro.oxt" (source code in "extension/" subdir) > > But,

Re: [libreoffice-design] Minutes from the UX/design meeting 2019-DEC-12

2019-12-13 Thread Kaganski Mike
Dear Paul, 12 дек. 2019 г. 17:30 пользователь paul hofseth написал: Sirs, please do not waste scarce coding resources on thoroughly trivial matters like colours and signage, but rather on making the programs more practical to use - such as for instance having the choice of typeface as a sdepar

Re: chart2.check fails in testAxisTitlePositionDOCX

2019-12-10 Thread Kaganski Mike
On 11.12.2019 1:32, Luke Benes wrote: > I bisected this regression to > https://cgit.freedesktop.org/libreoffice/core/commit/?id=d10db7846602c16701dde019f12f61fd536e9ae4 > > tdf#128133 WIN don't exit after link-output filter I would assume this not to be a regression from that commit, but ra

Re: Accessing code for Calc functions

2019-11-26 Thread Kaganski Mike
Hi Steve, On 26.11.2019 17:15, Steve Fanning wrote: > I am currently working as a member of the Documentation Team, updating > Chapter 18 of the Calc Guide (Description of Functions). From time to > time during this task, I would benefit from viewing the code that > implements individual functi

Re: About replacing some "C-Array" into std::array

2019-11-22 Thread Kaganski Mike
On 22.11.2019 18:31, julien2412 wrote: > Taking a look at cppcheck report, I noticed this kind of reports: > vcl/source/treelist/transfer.cxx > 132 useStlAlgorithm 398 style Consider using std::fill algorithm > instead of > a raw loop > > To use std::fill, we'd need to convert the C array

Re: Fwd: [comment] uitest for bug tdf#126685

2019-11-20 Thread Kaganski Mike
On 20.11.2019 21:58, Crhonek Zdenek wrote: > Probably I found the reason - document is opened with macro warning and > test stuck here. I don't know why it worked on my computer and on gerrit > bots, but now I can reproduce it.  Unfortunately I cannot reproduce the > bug after copy of sheets to

C++ initialization talk wideo

2019-10-04 Thread Kaganski Mike
Hi All, Stephan, Noel, possibly https://youtu.be/2jJumNzcp6Y would have something interesting for you regarding different initialization syntaxes in C++. Personally for me it was really unexpected that using "=default" in method definition is different for inline (inside class definition) and o

Re: Review for "improve import/export of line styles"

2019-09-02 Thread Kaganski Mike
On 02.09.2019 9:20, Németh László wrote: >> And technical question: What do I need to do locally in Git, so >> that the >> information, that the no longer needed file >> "lo_preset_dashes.odt" has >> to be deleted, is included in my commit? > > > If you

Re: Crash test update

2019-08-07 Thread Kaganski Mike
On 27.04.2019 18:33, Caolán McNamara wrote: > On Sat, 2019-04-27 at 00:33 +, Crashtest VM wrote: >> New crashtest update available at >> http://dev-builds.libreoffice.org/crashtest/0b56eb2c10ab4ca027f1a37e04519366b3cd7433/ > > > soffice.bin --headless --convert-to xlsx ooo83250-1.ods > semi-r

Re: sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

2019-07-14 Thread Kaganski Mike
On 14.07.2019 22:23, Jan-Marek Glogowski wrote: > > If you want to debug Windows AnyInput handling, feel free > to contact me on IRC (or even mail), if you have questions. I have tried putting some tracing breakpoints to WinSalInstance::AnyInput, and I can say that at least when the process is

sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

2019-07-14 Thread Kaganski Mike
Hi! I see sw_uiwriter hanging locally in testDateFormFieldCurrentDateInvalidation (added in commit d0ff1090762ac61ce08f54bc76685232699d98a0), never returning from Scheduler::ProcessEventsToIdle. Killing the test after some time produces multiple lines in console: > warn:vcl.schedule:5488:1382

Re: Reveal code, old macros convert them to LO

2019-07-05 Thread Kaganski Mike
Hi! On 04.07.2019 20:08, Uwe Brauer wrote: > > > From time to time the question pops up whether LO could support > Wordperfects reveal code. Sometimes it is stated that this feature could > be implemented by a macro/extension. > > Now I remember that long time ago such macros existed and using

Re: [GSoC - QR Code] Week Report 5 (June 24 - June 30)

2019-07-01 Thread Kaganski Mike
Hi! On 02.07.2019 11:40, shubham goyal wrote: > Status of project > - I will be left with calling QR Code feature in Word/impress/ and other > applications if requires. Not sure that making the feature for Word is within the scope of the project ;-) -- Best regards, Mike Kaganski ___

Can mimalloc turn out to be useful for LibreOffice?

2019-06-23 Thread Kaganski Mike
MS has released its mimalloc [1] under BSD license as a drop-in replacement for malloc. It is said to have excellent performance. It's also cross-platform. Can it be useful for LibreOffice (on supported platforms)? What is required to actually make LibreOffice use it, and how to test possible p

Re: Request for review: Convert Fontwork to TextWarp on export

2019-06-14 Thread Kaganski Mike
On 15.06.2019 10:04, Regina Henschel wrote: > My patch would implement the export from "Fontwork" to "TextWarp" > without character fill and outline. My question is, whether you agree, > that such step is useful? Even if character fill and outline will not be > implemented soon? I suppose that

CppunitTest_sc_macros_test hanging indefinitely with font scaling on Windows

2019-06-07 Thread Kaganski Mike
Hi! On Windows 10 x64 (1903 build 18362.116), having "all items scaling" set to 150%, with current master (now at b170256fb6ebaf774b02b89835b19d9f3a1afb89) built for x64 in dbgutil config, running > make CppunitTest_sc_macros_test reliably hangs indefinitely. It never returns from Scheduler

Using Amazon Corretto as Oracle JDK replacement for building LibreOffice on Windows

2019-05-30 Thread Kaganski Mike
Hi, Since Oracle JDK versions prior to 12 are now unavailable from the official site [1] for unregistered users (and version 12 is said to still have problems/needs workarounds [2]), I decided to give Amazon Corretto [3] a try. I downloaded and installed the two MSIs listed on that page (amazo

Re: Crash test update, now with backtraces

2019-05-26 Thread Kaganski Mike
On 26.05.2019 17:14, Caolán McNamara wrote: > On Fri, 2019-05-24 at 10:31 +0200, Luboš Luňák wrote: >> Could you please name those .backtrace.txt? I can't view those files >> online, because they get treated as binary files and so Firefox only >> offers to download them. > > Yeah, I changed that

Re: Permission not granted to push my patch

2019-05-04 Thread Kaganski Mike
Hi, On 04.05.2019 12:45, Cyrille wrote: > I tried: > git push ssh://lafric...@gerrit.libreoffice.org:29418/dictionaries > HEAD:refs/for/master > > I got now this error: > remote: Resolving deltas: 100% (1/1) > remote: Processing changes: refs: 1, done > remote: ERROR: [b5f81e8] missing Change-Id

Re: is gerrit #26348 still somewhere?

2019-04-29 Thread Kaganski Mike
Hi, On 29.04.2019 15:04, Eike Rathke wrote: > Maybe changes marked as abandoned get purged after a while? I don't know. ... but definitely, if a user deletes a draft patch, without publishing it, it is deleted irreversibly (or at least irreversibly for the user). -- Best regards, Mike Kaganski

Fwd: Tinderbox failure, Android-ARM@24-Bytemark-Hosting, MASTER, last success: 2019-04-26 20:22:54

2019-04-27 Thread Kaganski Mike
Hi! After my commit ac419786b324 "Don't use std::function in scope guard for performance reasons", errors are generated by Android-ARM, as in the forwarded message below. According to https://stackoverflow.com/questions/43514188/lambda-passed-to-template-not-defined, it's https://bugs.llvm.o

Re: bug 74702

2019-04-22 Thread Kaganski Mike
Hi Adrien, On 22.04.2019 12:43, Adrien Ollier wrote: > sorry I meant impedit3.cxx, lines 2805 and 2806. > > Ok I'll try to make some changes in gerrit. Nice, looking forward to see it mentioned here in the thread. Please note that answering someone's answer directly, without CCing the mailing

Re: bug 74702

2019-04-22 Thread Kaganski Mike
Hi Adrien, First of all, it's best to have a tentative change in gerrit, with your proposed changes, to have better overview. Please create if you haven't yet, and post the link here. Thanks! On 22.04.2019 11:58, Adrien Ollier wrote: > 2. In editeng/source/editeng/impedit2.cxx it is required t

Re: Properly notify gpgme about spawn executable location on Windows

2019-04-21 Thread Kaganski Mike
On 21.04.2019 0:22, Thorsten Behrens wrote: >> 1. First of all - do I understand it correctly that the problem is real >> - so there are possible scenarios involving e.g. python (or another >> process which executable is not in LO's instdir/program), that might >> need gpgme? >> > See above - but e

Re: Properly notify gpgme about spawn executable location on Windows

2019-04-20 Thread Kaganski Mike
Hi Thorsten, Thanks for your analysis! On 21.04.2019 0:22, Thorsten Behrens wrote: > Kaganski Mike wrote: >> However, I suppose that it's possible in theory that some user python >> script could ultimately need initializing gpgme. In that case, the >> problem would hi

Properly notify gpgme about spawn executable location on Windows

2019-04-20 Thread Kaganski Mike
Hi Thorsten, *, When working on a 6-0-based branch on Windows, in make check, two python tests emit modal error dialogs about missing gpgme-w32spawn.exe: > --- > GpgME not installed correctly > --- > gpgme-w32spawn.exe was not found in the detected

FastSerializerHelper::singleElement/startElement internal API changed

2019-04-19 Thread Kaganski Mike
Hi! This is just to notify those who might currently use FastSerializerHelper in patches being prepared. Commit 1fe24bb1e2fbe44a4bf2c03297e259b3a18b1235 has modified the singleElement/startElement[NS] APIs by removing FSEND (which was a remnant of old C-style varargs implementation). So if you

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

2019-04-15 Thread Kaganski Mike
On 15.04.2019 10:44, Adrien Ollier wrote: > And what is written is not really equivalent to what you wrote because > if AcquireGraphics() is false, there is not a second check for mpGraphics Also note that when AcquireGraphics() is false (telling it could not acquire mpGraphics successfully), we

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

2019-04-15 Thread Kaganski Mike
On 15.04.2019 10:44, Adrien Ollier wrote: > OutputDevice::AcquireGraphics() is a pure virtual function, so we cannot > know in the general case what it does. > And what is written is not really equivalent to what you wrote because > if AcquireGraphics() is false, there is not a second check for

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

2019-04-15 Thread Kaganski Mike
On 15.04.2019 10:33, Adrien Ollier wrote: > Hello everybody, > > working on bug #74702 >  led me to > read file core/vcl/source/outdev/nativecontrols.cxx. > > I think there is an issue here: > > > > If mpGraphics == nullptr and Acqui

CppunitTest_sc_macros_test fails after commit 7282014e362a1529a36c88eb308df8ed359c2cfa

2019-04-14 Thread Kaganski Mike
Hi! After commit 7282014e362a1529a36c88eb308df8ed359c2cfa, now CppunitTest_sc_macros_test fails when testing sc/qa/extras/testdocuments/Window.xls: > C:/lo/src/core/sc/qa/extras/macros-test.cxx(338) : error : Assertion > Test name: ScMacrosTest::testVba > equality assertion failed > - Expected:

Re: libreoffice converstion of egistrymodifications.xcu user items to systemwide xml registry share

2019-04-12 Thread Kaganski Mike
See also: https://wiki.documentfoundation.org/Deployment_and_Migration#Post_deployment_configuration https://ask.libreoffice.org/en/question/185522/how-do-i-turn-off-opengl-while-deploying-libreoffice/ https://ask.libreoffice.org/en/question/167622/how-to-disable-java-in-configuration-files/ https

Re: Gitiles VCS browser

2019-04-06 Thread Kaganski Mike
On 06.04.2019 17:18, Luke Benes wrote: > Mike, > That is not an apples to apples comparison. In your browser open and compare > side-by-side: > > https://git.libreoffice.org/core/+/6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676a > and > https://cgit.freedesktop.org/libreoffice/core/commit/?id=6a9cf9ba2d

Re: Gitiles VCS browser

2019-04-06 Thread Kaganski Mike
Hi, On 06.04.2019 1:46, Luke Benes wrote: > No one in QA and no developers have voiced a preference for gitiles. > Because it's slower, it's UI and UX is harder to read, it lacks useful > tools like search,  and the URLs are a pain to work with. It's inferior > in every way. Personally I like

Re: Gitiles VCS browser

2019-04-05 Thread Kaganski Mike
On 05.04.2019 19:55, Guilhem Moulin wrote: > Hi Miklos, > > On Fri, 05 Apr 2019 at 09:17:01 +0200, Miklos Vajna wrote: >> One more aspect: perhaps I'm just unlucky, but on average, I found >> cgit to load much faster than these git.libreoffice.org links. > > Hmm that's interesting. That's not so

Re: [GSoC] Subpixel glyph positioning - Looking for a mentor

2019-04-04 Thread Kaganski Mike
On 04.04.2019 19:56, Alexander Farrow wrote: > Hi Jan-Marek, > > Thank you for your reply. > >     I have added some potential mentors, which are normally also > interested in font >     rendering. As much as I could potentially do some mentoring, as I > know a share >     of Sal

Difference in a test behavior on Windows and Linux

2019-03-13 Thread Kaganski Mike
In commit b37b299d5228beeecb913980780f463756c5a878 [1] I have tested a hung sc_stylefamilyobj problem on Windows, that was caused by a bug in IndexedStyleSheets::FindPositionsByNameAndPredicate fixed later in commit 362082b57b2d6e9119acb3fb033aefcbce8cf8bb [2]. It was introduced in 2014 [3], an

Re: offline help

2019-02-28 Thread Kaganski Mike
Hi S.! On 28.02.2019 6:51, pnbs! wrote: > I can not find where to download offline Help. I really need it, I also > wish it was easier to find and also I wished they would put a link in > office program. Unfortunately, you didn't mention what is your LibreOffice version and operating system ar

Re: need help to insert an image with a caption with the Libo java API

2019-02-13 Thread Kaganski Mike via LibreOffice
On 13.02.2019 12:45, Miklos Vajna via LibreOffice wrote: > Hi, > > On Tue, Feb 12, 2019 at 09:27:15AM +, LORENZO Vincent > wrote: >> I would like to add a caption, to an inserted image in a text >> document, but I don't find how to do that... Please do you have >> pointer/documentation for m

Re: Trying to put LO Firebird patches upstream, license issue?

2019-02-09 Thread Kaganski Mike
On 09.02.2019 22:19, Michael Meeks wrote: > Hi Julien, > > On 04/02/2019 21:15, Julien Nabet wrote: >>> Well - since our patches are modifications to Firebird, which requires >>> all modifications to have IDPL licensing, then all our modifications >>> cannot be under a different license? > >

Re: Principle of least surprise

2019-02-08 Thread Kaganski Mike
Hi! Well - I tend to agree that having the hyperlinks malfunctional is not nice. *Possibly* the idea behind showing "hand" cursor over such URLs even without holding CTRL required for their activation could be to allow user an easy way to identify the links... but even then, showing cursor doe

Re: Trying to put LO Firebird patches upstream, license issue?

2019-02-04 Thread Kaganski Mike
Hi, On 04.02.2019 22:36, julien2412 wrote: > Following my abandoning of Firebird 3.0.4 upgrade, I wonder if it may help > to try to submit some LO Firebird patches upstream. > For example, Cygwin is still not present in configure.ac file of Firebird > master sources. > Is it ok to submit a patch

Re: Boolean configuration settings not editable in tools - advanced - expert configuration

2019-02-04 Thread Kaganski Mike
On 04.02.2019 11:53, Winfried Donkers wrote: > (moving discussion from https://gerrit.libreoffice.org/#/c/67280/ to mailing > list) > >>> For reasons unknown to me, boolean configuration settings are read only on >>> the >>> expert configuration dialog, int/long values can be edited. This is not

Re: Conflict with submitted change

2019-02-02 Thread Kaganski Mike
Hi, On 02.02.2019 9:48, Aditya Sahu wrote: > Hi, > I submitted a change ( Change-Id: > I440c637dd2a566f820a6e8fac826f35cabb9c05f ) but after doing that, I > found out that it is having conflict with some other change ( Change-Id: > I937ed12f2a96943664087ddcdd035f1347e84a57 ). > What should be m

Re: Possible extensions to OUString class

2019-01-30 Thread Kaganski Mike
On 31.01.2019 0:40, Stephan Bergmann wrote: > Also, a better approach overall would probably be some string_view-based > getToken functionality (converting from an OUString to a string_view is > cheap), and then string_view-based toInt etc. functions. Is there a C++ magic to automatically select

Re: Encoding problem when migration hsqldb->Firebird

2019-01-30 Thread Kaganski Mike
On 30.01.2019 14:00, Kaganski Mike wrote: > ... a valid UTF-18 escape sequence ... Why not, if there is UTF-9? :-) Sorry for the typo. -- Best regards, Mike Kaganski ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org ht

Re: Encoding problem when migration hsqldb->Firebird

2019-01-30 Thread Kaganski Mike
Hi Julien, On 30.01.2019 12:13, Julien Nabet wrote: > Giving a try to tdf#123020 (which is finally a dup), I added some traces > and noticed this kind of string (OUString): > "CREATE CACHED TABLE "\u00c5r"("\u00c5r" INTEGER NOT NULL PRIMARY KEY)" > ... > How to convert \u... to the "real" charact

Re: First-time development/C++ Contributor

2019-01-28 Thread Kaganski Mike
On 28.01.2019 14:40, Michael Weghorn wrote: > The use of "lode" is not mandatory, you can also manually do the > required setup, but be aware that lode will simplify the setup True, but > and > you're more on your own if you encounter any issues while doing things > by yourself. Personally I fee

Re: [Bug 115747] Can't edit file on samba shares

2019-01-27 Thread Kaganski Mike
Hi Thorsten! On 28.01.2019 5:32, Thorsten Behrens wrote: > Kaganski Mike wrote: >> My vision of this would me that if inability to create lockfiles >> needs to be handled specially at all, then at maximum a warning >> infobar telling that "no lockfile was created,

Re: Could not determine MSC version (Visual Studio 2017)

2019-01-25 Thread Kaganski Mike
On 25.01.2019 14:06, julien2412 wrote: > > Now to avoid to patch the package, the idea would be to know why I get > something else than a plain space. Perhaps something to configure on Cygwin > (codepage, LC, ...) > Let's dig on Google... You could change your VS language to English possibly. And

Re: [Bug 115747] Can't edit file on samba shares

2019-01-25 Thread Kaganski Mike
On 12.01.2019 13:28, Thorsten Behrens wrote: > Context: >> https://bugs.documentfoundation.org/show_bug.cgi?id=115747 > >> Because >> A) this is a regression, >> B) which already had an alternate solution (SystemLocking = false), >> C) and the description uses the terminology "Allow" instead of >>

Re: Building LO 6.1.4.2 --with-system-jpeg and jpeg-9c fails

2019-01-22 Thread Kaganski Mike
On 22.01.2019 23:56, Dilyan Palauzov wrote: > Hello Caolán, > > what is the usefulness of a test, that behaves differently with different > jpeg libraries, but none of the test-outcomes is clearly wrong? You could notice that the failing test is called testCVEs. It tests that known vulnerabilit

Re: Stable, conservative, unsupported versions | libreoffice.com/download

2019-01-16 Thread Kaganski Mike
On 16.01.2019 15:41, Дилян Палаузов wrote: > Hello, > > it is confusing, when the most stable version does not compile, as it > happened to me, and when this is not going to > change. > > I suggest recomending only versions, which either compile, or in case they > don’t compile, they are suppos

Re: Stable, conservative, unsupported versions | libreoffice.com/download

2019-01-16 Thread Kaganski Mike
On 16.01.2019 14:49, Дилян Палаузов wrote: > Hello, > > what I wanted to ask was, why does the LO-ebpage recommend for enterprises > end of life products. > > My understanding of the processes is, that there are usually a stable > version, that is not end-of-live, and a most > current version,

Re: xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override

2019-01-14 Thread Kaganski Mike
Hi! On 15.01.2019 1:40, Дилян Палаузов wrote: > Hello, > > the LO source code requires const GooString*, but the > /usr/local/include/poppler/OutputDev.h file had no const in the > declaration of drawString. The installed poppler was newer than 0.64.0. > > The hack is, that in the past I insta

Re: xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override

2019-01-14 Thread Kaganski Mike
On 14.01.2019 11:46, Stephan Bergmann wrote: > On 13/01/2019 23:57, Дилян Палаузов wrote: >> LO 6.0.7.3 fails compiling with gcc 8.2.1 20190101 I emitting: >> >> [build SPP] scp2/source/ooo/ure >> [build SCP] scp2/source/writer/file_writer >> [build SPP] scp2/source/xsltfilter/file_xsltfilter >> [b

Re: Problem in running make file on Ubuntu 16.04

2019-01-08 Thread Kaganski Mike
On 08.01.2019 10:44, Komal Bharadiya wrote: > I have been trying to setup libreoffice dev-environment lately. After > executing ./autogen.sh file, I hit make command. The execution takes > ample amount of time. It hangs my laptop, and I end up switching it off. > I have tried multiple no. of tim

Re: libreoffice pdfimport w/ poppler-0.72.0: build failure

2019-01-07 Thread Kaganski Mike
Hi Andreas! On 08.01.2019 3:12, Andreas Sturmlechner wrote: > In git master, libreoffice fails to build with: > > sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:558:70: error: ‘const > class GooString’ has no member named ‘getCString’ > > The relevant change in poppler 0.72 release notes:

Re: Fwd: About Build dependencies Environment setup

2019-01-06 Thread Kaganski Mike
Hi! On 06.01.2019 21:13, Mohit Kumar wrote: > Hi, > I am trying to build dependencies in linux by following the coomand : > sudo apt-get build-dep libreoffice but it showing some error.I am > attaching the screenshot, Please Help First of all, please always mention your OS information. Next, th

Re: OpenGrok for core

2018-12-26 Thread Kaganski Mike
On 26.12.2018 16:38, Justin Luth wrote: > kompi: upgraded on xmas night (as announced to status.tdf) but > the index & history namespace changed so I had to trigger a full reindex > (which is still ongoing for core) > 11:28 Possibly core has not indexed yet (as the one > largest opengrok proje

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

2018-12-24 Thread Kaganski Mike
Hi, On 16.12.2018 22:57, Luke Benes wrote: > Mike, > The fix for *Bug 121685* > , > https://cgit.freedesktop.org/libreoffice/core/commit/?id=7263d223ddf4 > ​ > Is causing the core Unit Test CppunitTest_chart2_xshape to fail when you >

Re: Libre Office Local Installation

2018-12-23 Thread Kaganski Mike
Hi Komal! Welcome! On 23.12.2018 10:43, Komal Bharadiya wrote: > Moreover, I have directly downloaded the libre office > repository from github. Then followed the steps given on official site > of libre office. Although possibly unrelated to the problem, this is clearly wrong. Where have you rea

Re: When file truncation happens by Basic's Open statement

2018-12-21 Thread Kaganski Mike
Hi! On 21.12.2018 20:37, Takeshi Abe wrote: > In order to tell whether the behavior reported in tdf#119102 [1] is a bug > or not, I would like to understand the specification of LibO Basic's Open > statement [2]. > > The following table summarizes what current (master) LibO does, which I read > f

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

2018-12-16 Thread Kaganski Mike
Hi Luke! On 12/16/2018 10:57 PM, Luke Benes wrote: > The fix for *Bug 121685* > , > https://cgit.freedesktop.org/libreoffice/core/commit/?id=7263d223ddf4 > ​ > Is causing the core Unit Test CppunitTest_chart2_xshape to fail when you >

Re: Subsequent Unit Test CppunitTest_sc_ddelinkobj Failing Under Windows

2018-12-13 Thread Kaganski Mike
On 12/13/2018 3:05 AM, Jens Carl wrote: > Hello Luke, > > On 12/8/18 7:09 AM, Luke Benes wrote: > >> Would you like any additional debugging info? > > I personally don't have access to any Windows machines and my knowledge > about Windows Devolvement (Virtual Studio) is very limited. So I > un

Re: Windows build failure - C2131: expression did not evaluate to a constant

2018-12-04 Thread Kaganski Mike
On 04.12.2018 14:18, Kaganski Mike wrote: > On 04.12.2018 14:17, Kaganski Mike wrote: >> >> I have just pulled, and I confirm this with 64-bit build, with VS >> version 15.9.3. >> > > I mean, I confirm that with my version of compil

Re: Trying to create editor using LibreOffice

2018-12-04 Thread Kaganski Mike
Hi, On 04.12.2018 13:33, Rohit Garg Satpal Garg wrote: > Hi Team, > > I am trying to create editing application for my one of the research > projects but I am stuck on implementation of  getLinreOfficeKitHandler() > which is missing from the source files. It is not missing. See implementation

Re: Windows build failure - C2131: expression did not evaluate to a constant

2018-12-04 Thread Kaganski Mike
On 04.12.2018 14:17, Kaganski Mike wrote: > > I have just pulled, and I confirm this with 64-bit build, with VS > version 15.9.3. > I mean, I confirm that with my version of compiler, the problem is reproducible. ___ LibreOffice

Re: Windows build failure - C2131: expression did not evaluate to a constant

2018-12-04 Thread Kaganski Mike
On 04.12.2018 10:37, Stephan Bergmann wrote: > > Our recently-bumped MSVC baseline is Visual Studio 2017 version 15.7 > (the "version 15.7" suffix is important, there are many different > releases of Visual Studio 2017, with ever-increasing C++ standard > compliance).  That should be enforced b

Re: Windows build failure - C2131: expression did not evaluate to a constant

2018-12-03 Thread Kaganski Mike
On 04.12.2018 9:30, Noel Grandin wrote: > > >> I'm seeing the following build failure on Windows 32-bit release build: >> D:/core/vcl/source/bitmap/BitmapTools.cxx(1078): error C2131: >> expression did not evaluate to a constant >> D:/core/vcl/source/bitmap/BitmapTools.cxx(1097): error C2131: >

Re: Help regarding Transliteration in LO writer

2018-11-26 Thread Kaganski Mike
Hi! On 26.11.2018 13:39, Harshad Gorde wrote: > Hello everyone, > > I am interested in introducing transliteration facility (English to > Devnagari) to LibreOffice writer. But, after downloading the huge source > code I am unable to decide where to start. > > Kindly suggest me some initial ste

Re: remove followed by a push_back of same var (SwSpellDialogChildWindow)

2018-11-24 Thread Kaganski Mike
On 24.11.2018 10:23, julien2412 wrote: > I noticed these lines: > 737 if(pCurrentTextObj) > 738 { > 739 m_pSpellState->m_aTextObjects.remove(pCurrentTextObj); > 740 > m_pSpellState->m_aTextObjects.push_back(pCurrentTextObj); > 741 } > See

Re: Failing JunitTest_framework_complex

2018-11-21 Thread Kaganski Mike
On 21.11.2018 16:37, Jan-Marek Glogowski wrote: > Hi Mike > > Am 21.11.18 um 14:01 schrieb Kaganski Mike: >> JunitTest_framework_complex fails reliably for me on current master with >> assertion >> >>assert( mpWindowContext.is() ); > >

Failing JunitTest_framework_complex

2018-11-21 Thread Kaganski Mike
JunitTest_framework_complex fails reliably for me on current master with assertion assert( mpWindowContext.is() ); failing at OpenGLSalGraphicsImpl::doFlush(). I could debug it to WinOpenGLContext::ImplInit() having m_aGLWin.hDC == nullptr, thus ChoosePixelFormat fails. The call stack for th

Failing

2018-11-21 Thread Kaganski Mike
After last pull, JunitTest_chart2_unoapi reliably fails for me on master on Win10 with this call stack: ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28) ucrtbased.dll!__acrt_report_runtim

Re: Unable to build with poppler 0.71.0

2018-11-20 Thread Kaganski Mike
On 19.11.2018 16:07, Andrey Cherepanov wrote: > If build with poppler 0.71.0 I get errors for missing type GBool: > > In file included from > /usr/src/RPM/BUILD/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx:20:0: > /usr/src/RPM/BUILD/libreoffice-6.0.7.3/sdext/source/pdfimp

Re: Changing soffice.bin to be console application on Windows

2018-11-19 Thread Kaganski Mike
On 19.11.2018 18:48, Stephan Bergmann wrote: > On 19/11/2018 16:38, Kaganski Mike wrote: >> I have prepared a patch making soffice.bin a proper console Windows >> application: https://gerrit.libreoffice.org/63572. The patch also >> introduces a new launcher soffice.com (in

Changing soffice.bin to be console application on Windows

2018-11-19 Thread Kaganski Mike
Hi! Currently soffice.bin on Windows is built with subsystem set to GUI. This creates a number of problems, including impossibility to output --version/--help into a text using command like soffice --help > somefile (or do similar things piping the output to other commands in batch files); ab

Re: Replacing /.vs by *.vs in .gitignore

2018-11-14 Thread Kaganski Mike
Hi! On 15.11.2018 9:43, Kévin Dlle wrote: > With VS2017 integration, when a module solution in opened (for example > vcl/vcl.sln), VS2017 creates a folder vcl/.vs > These folders are not masked by the actuel gitignore. > We should replace the line /.vs by *.vs Please come with a patch to gerrit.

Re: Please update XML Security Library to 1.2.27 for LibreOffice 6.2/6.1.4/5.5 from Windows/Linux.

2018-11-12 Thread Kaganski Mike
Hi, On 12.11.2018 19:50, maxbook2020 maxbook2020 wrote: > Please update XML Security Library for LibreOffice version 6.2/6.1.4/5.5 > from Windows/Linux. > > Current xmlsec 1.2.23 to new xmlsec 1.2.27. > > Because now is old > > https://wiki.documentfoundation.org/ReleaseNotes/5.3 > > >

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

2018-11-06 Thread Kaganski Mike
On 11/6/2018 4:12 PM, Miklos Vajna wrote: > So what to change? https://git.libreoffice.org/core/+log/HEAD -- Best regards, Mike Kaganski ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libre

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

2018-11-05 Thread Kaganski Mike
On 10/31/2018 9:15 AM, Guilhem Moulin wrote: > On Tue, 30 Oct 2018 at 16:18:36 +, Luke Benes wrote: >> The date gitiles displays in the log is the author date, rather than >> the much more useful commit date. > > Quoting my own <20181023142926.GB21836@localhost.localdomain>: > > | It's shows

Re: Seg fault on Windows in xmlsecurity_signing Unit Test

2018-10-31 Thread Kaganski Mike
On 10/31/2018 7:13 PM, Luke Benes wrote: > Both my Windows box and @42 and @62 are failing with the following error: > [build CUT] xmlsecurity_pdfsigning > /usr/bin/sh: line 1: 8100 Segmentation fault ( > PATH="C:\core\instdir\program;C:\core\instdir\program;C:\core\workdir\LinkTarget\Librar

Re: Cppcheck: Reduction of False Positives: Manual Approach

2018-10-26 Thread Kaganski Mike
Hi Luke, I believe that continuing the "manual approach" is moot. It was mentioned that the correct way is to generate the proper project structure for cppcheck using our existing tools that generate IDE integrations (and they have correct include correct includes, deps and all). -- Best rega

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

2018-10-23 Thread Kaganski Mike
On 10/23/2018 12:29 PM, Adolfo Jayme Barrientos wrote: > Gitiles lacks this kind of per-file-diff links, so I can only load a > diff of all the files touched by the commit. This isn’t nice for my > underpowered computer, and it really breaks my workflow. Well - e.g., https://gerrit.libreoffice.or

Re: "GpgME not installed correctly" in unit tests

2018-10-18 Thread Kaganski Mike
On 10/18/2018 2:48 AM, Thorsten Behrens wrote: > Ah - so it seems also LinkTarget\Executable needs a copy of that silly > program - can you try to add a line to > > external/gpgmepp/ExternalPackage_gpgmepp.mk > > that copies it there? I have prepared a gerrit change: https://gerrit.libreoffice.o

"GpgME not installed correctly" in unit tests

2018-10-16 Thread Kaganski Mike
Hi! While doing make check on my Windows box with gpg4win (default-installed, but not configured), I get these dialog boxes popping up a dozen of times, e.g. in test_xmlsecurity_pdfsigning or test_sw_odfexport: --- GpgME not installed correctly -

  1   2   >